Re: [C++] ResumeProducing Future Causing Blocking

2022-07-20 Thread Weston Pace
> 4) control is not returned to the processing thread Yes, it looks like the current implementation does not return control to the processing thread, but I think this is correct, or at least "as designed". The thread will be used to continue iterating the source. > control is not returned to the

Re: [C++] ResumeProducing Future Causing Blocking

2022-07-20 Thread Sasha Krassovsky
Hi, Futures run callbacks on the thread that marks then as finished. It seems that inside of the Source node’s generator loop does add a callback (https://github.com/iChauster/arrow/blob/asof_join2/cpp/src/arrow/compute/exec/source_node.cc#L130

Re: [C++] Moving from -O3 to -O2 optimization level in release builds

2022-07-20 Thread Sasha Krassovsky
I’d +1 on this - in my past experience I’ve mostly seen -O2. It would make sense to default to -O2 and only enable -O3 on source files selectively that can be demonstrated to benefit from it (if anyone actually spends the time to look into it). Sasha > On Jul 20, 2022, at 2:10 PM, Wes McKinney

[C++] ResumeProducing Future Causing Blocking

2022-07-20 Thread Ivan Chau
Hi all, I am currently working on writing a manual back-pressure mechanism for AsOfJoin. We are trying a simple version where we maintain a buffer of batches from one of the input sources (our left table source). We want to pause production when we reach a certain number of batches, and resume pro

[C++] Moving from -O3 to -O2 optimization level in release builds

2022-07-20 Thread Wes McKinney
hi all, Antoine and I were digging into a weird issue where gcc in -O3 generated ~40KB of optimized code for a function which was less than 2KB in -O2, and where a "leaner" implementation (in PR 13654) was yet faster and smaller. You can see some of the discussion at https://github.com/apache/arr

Re: Arrow sync call July 20 at 12:00 US/Eastern, 16:00 UTC

2022-07-20 Thread Gavin Ray
Awesome, thanks for the clarification David! On Wed, Jul 20, 2022 at 2:40 PM David Li wrote: > It was pulled out of the ADBC project so you can see an example at [1] > (API changed slightly when ported though). > > Yes, it'll bind one row of values at a time, and your description is > correct. >

Re: Arrow sync call July 20 at 12:00 US/Eastern, 16:00 UTC

2022-07-20 Thread David Li
It was pulled out of the ADBC project so you can see an example at [1] (API changed slightly when ported though). Yes, it'll bind one row of values at a time, and your description is correct. [1]: https://github.com/apache/arrow-adbc/blob/cf43e0cc2ae15ad0ce669b531d475ee218698100/java/driver/jdb

Re: Arrow sync call July 20 at 12:00 US/Eastern, 16:00 UTC

2022-07-20 Thread Gavin Ray
That JDBC PreparedStatement binding utility looks super useful! I had one question about the behavior of it, if that's alright: The doc says: "Each call to next() will bind parameters > from the next row of data, and then the application can execute the > statement, call addBatch(), etc. as desir

Re: Arrow Flight usage with graph databases

2022-07-20 Thread Gavin Ray
> > We considered the option to analyze data to build a schema on the fly, > however it will be quite an expensive operation which will not allow us to > get performance benefits from using Arrow Flight. I'm not sure if you'll be able to avoid generating a schema on the fly, if it's anything like

Re: Arrow sync call July 20 at 12:00 US/Eastern, 16:00 UTC

2022-07-20 Thread Will Jones
Attendees: - Jacob Wujciak-Jens - James Duong - Rok Mihevc - Raul Cumplido - Eduardo Ponce - Jeremy Parr-Pearson - Will Jones - Joris Van den Bossche Discussion Arrow 9.0.0 Release Increased capacity for crossbow, like 3x, including Macs. Devs are encouraged to use more

Re:Closed PR ARROW-16778: [C++] Fixing build/unit test issues in msvc/win32

2022-07-20 Thread Arkadiy Vertleyb (BLOOMBERG/ 120 PARK)
Please disregard. I confused two different PRs with the same name :-) From: dev@arrow.apache.org At: 07/20/22 09:11:32 UTC-4:00To: dev@arrow.apache.org Subject: Closed PR ARROW-16778: [C++] Fixing build/unit test issues in msvc/win32 Hi guys, Sorry for the delay, but I am ready to re-submit

Closed PR ARROW-16778: [C++] Fixing build/unit test issues in msvc/win32

2022-07-20 Thread Arkadiy Vertleyb (BLOOMBERG/ 120 PARK)
Hi guys, Sorry for the delay, but I am ready to re-submit this PR... but the comment seems to indicate James Duong is fixing the issue "from the ground up". What is going on with this and do you still need my PR? If not, what is the ETA on fixing the issue? Thanks, Arkadiy