Re: [C++] Question about "Code style and Linting"

I see. Thanks for the quick reply! On Thu, Apr 28, 2022 at 11:09 AM Antoine Pitrou wrote: > > Le 28/04/2022 à 17:07, Li Jin a écrit : > > Aha thanks Antoine! > > > > After digging the log I think I found the issue: > > " > > -- clang-tidy 12 not found > > -- clang-format 12 not found > > " > > >

Re: [C++] Question about "Code style and Linting"

Le 28/04/2022 à 17:07, Li Jin a écrit : Aha thanks Antoine! After digging the log I think I found the issue: " -- clang-tidy 12 not found -- clang-format 12 not found " after installing those two it got me over that step.. A side question - does running " archery lint --cpplint --clang-form

Re: [C++] Question about "Code style and Linting"

Aha thanks Antoine! After digging the log I think I found the issue: " -- clang-tidy 12 not found -- clang-format 12 not found " after installing those two it got me over that step.. A side question - does running " archery lint --cpplint --clang-format --clang-tidy --fix " supposed to fix the

Re: [C++] Question about "Code style and Linting"

Le 28/04/2022 à 16:54, Li Jin a écrit : Hello! I am preparing for submitting a PR and reading the "Code style and Linting" section of the development doc: https://github.com/apache/arrow/blob/master/docs/source/developers/cpp/development.rst#code-style-linting-and-ci I got to the point that

[C++] Question about "Code style and Linting"

Hello! I am preparing for submitting a PR and reading the "Code style and Linting" section of the development doc: https://github.com/apache/arrow/blob/master/docs/source/developers/cpp/development.rst#code-style-linting-and-ci I got to the point that I am running "" archery lint --cpplint --cla

Re: [ANNOUNCE] New Arrow committer: Liang-Chi Hsieh

Congratulations! On Thu, Apr 28, 2022 at 5:36 PM David Li wrote: > Congrats and welcome Liang-Chi! > > On Thu, Apr 28, 2022, at 05:07, Rok Mihevc wrote: > > Congrats! > > > > Rok > > > > On Thu, Apr 28, 2022 at 7:49 AM L. C. Hsieh wrote: > >> > >> Thanks all! Looking forward to working with you

Re: [ANNOUNCE] New Arrow committer: Liang-Chi Hsieh

Congrats and welcome Liang-Chi! On Thu, Apr 28, 2022, at 05:07, Rok Mihevc wrote: > Congrats! > > Rok > > On Thu, Apr 28, 2022 at 7:49 AM L. C. Hsieh wrote: >> >> Thanks all! Looking forward to working with you on the project! >> >> On Wed, Apr 27, 2022 at 9:26 PM Gidon Gershinsky wrote: >> > >>

Re: [ANNOUNCE] New Arrow committer: Liang-Chi Hsieh

Congrats! Rok On Thu, Apr 28, 2022 at 7:49 AM L. C. Hsieh wrote: > > Thanks all! Looking forward to working with you on the project! > > On Wed, Apr 27, 2022 at 9:26 PM Gidon Gershinsky wrote: > > > > Congrats Liang-Chi! > > > > Cheers, Gidon > > > > > > On Thu, Apr 28, 2022 at 4:17 AM Yang hao