Re: [Discuss][Format] Add 32-bit and 64-bit Decimals

2022-04-23 Thread Jacques Nadeau
I'm generally -0.01 against narrow decimals. My experience in practice has been that widening happens so quickly that they are little used and add unnecessary complexity. For reference, the original Arrow code actually implemented Decimal9 [1] and Decimal18 [2] but we removed both because of this e

Re: [C++] output field names in Arrow Substrait

2022-04-23 Thread Jacques Nadeau
In the specification, there are both read and intermediate write rels. No one has implemented the protobuf yet for write. Both carry field names. The names of fields is an internal rel node concern just like condition is for filter. This is because many formats require names. For example, parquet