Re: [VOTE] Release Apache Arrow 5.0.0 - RC1

2021-07-24 Thread Benjamin Kietzman
+1 verified C++ and Python on Windows 10 with: dev\release\verify-release-candidate.bat 5.0.0 1 On Thu, Jul 22, 2021 at 11:25 PM Krisztián Szűcs wrote: > Hi, > > I would like to propose the following release candidate (RC1) of Apache > Arrow version 5.0.0. This is a release consisting of 551 >

Re: Accidental push to master

2021-07-24 Thread Wes McKinney
Makes sense, I didn't think about automatic synchronization. I agree that we should not force push to master (we have discussed renaming to "main"), so using revert commits when there is a mistake sounds fine, too. On Sat, Jul 24, 2021 at 12:09 PM Jarek Potiuk wrote: > > Also one comment for forc

Re: Accidental push to master

2021-07-24 Thread Jarek Potiuk
Also one comment for force-pushes to the main branch - I did it twice before (before we enabled protection) and It turned out that it broke some of our users whole setup automated synchronization of 'airflow' repo (they added automated patching of they patches on top of our repo and force-pushed ch

Re: Accidental push to master

2021-07-24 Thread Jarek Potiuk
Hey Wes, others. It also protects you if you merge/push with git commands. I stopped worrying and double-checking if I have the "right" remote when I push directly to master when we enabled the protection because I simply can't push directly to master of "apache/airflow" any more (unless I am pus

Re: [VOTE] Release Apache Arrow 5.0.0 - RC1

2021-07-24 Thread Matt Topol
So, looking at the error message in the Go integration tests and looking at the stack trace, I was able to confirm the bug. I'm not sure why it showed up in that run but not subsequent / reproducible but the issue comes down to the following: In decimal128.go in the `FromBigInt` function you have

Re: Accidental push to master

2021-07-24 Thread Wes McKinney
hi Jarek, We don't merge with the GitHub UI, so I am not sure if that will help us. Weston, in the future if you make a mistake like this and notice right away, IMHO it's acceptable to force-push master reverting the mistake. If some time has lapsed then reverting is better. I have had my git

Re: [VOTE] Release Apache Arrow 5.0.0 - RC1

2021-07-24 Thread Yibo Cai
+1 Verified C++ and Python on Arm64 Linux (Ubuntu 20.04, aarch64). ARROW_CMAKE_OPTIONS="-DCMAKE_CXX_COMPILER=/usr/bin/clang++-10 -DCMAKE_C_COMPILER=/usr/bin/clang-10" TEST_DEFAULT=0 TEST_SOURCE=1 TEST_CPP=1 TEST_PYTHON=1 dev/release/verify-release-candidate.sh source 5.0.0 1 On 7/23/21 11:2

Re: Accidental push to master

2021-07-24 Thread Jarek Potiuk
FYI. You can protect branches with .asf.yaml against those kind of incidents: https://github.com/apache/airflow/blob/8e94c1c64902b97be146cdcfe8b721fced0a283b/.asf.yaml#L43 On Sat, Jul 24, 2021 at 7:04 AM Weston Pace wrote: > Thanks. I went ahead and did that. > > On Fri, Jul 23, 2021 at 6:53 P