Re: [Java] Source control of generated flatbuffers code

2021-03-23 Thread Micah Kornfield
> > I have a concern, though. Four other languages (Java would be five) check > in the generated flatbuffers code, and it appears (based on a quick scan of > Git logs) that this is done manually. Is there a danger that the binary > format could change, but some language might get forgotten, and thu

Re: [Java] Source control of generated flatbuffers code

2021-03-23 Thread bobtins
I'm happy to check in the generated Java source. I would also update the Java build info to reflect this change and document how to regenerate the source as needed. I have a concern, though. Four other languages (Java would be five) check in the generated flatbuffers code, and it appears (based

Re: [VOTE] Accept donation of Rust Ballista project

2021-03-23 Thread Rok Mihevc
+1 (non-binding) On Tue, Mar 23, 2021 at 4:40 PM Eric Burden wrote: > +1 > > On Tue, Mar 23, 2021 at 7:18 AM Francois Saint-Jacques < > fsaintjacq...@gmail.com> wrote: > > > +1 > > > > On Mon, Mar 22, 2021 at 8:33 AM Andrew Lamb > wrote: > > > > > > +1 > > > > > > On Sun, Mar 21, 2021 at 7:08 P

Re: [VOTE] Accept donation of Rust Ballista project

2021-03-23 Thread Eric Burden
+1 On Tue, Mar 23, 2021 at 7:18 AM Francois Saint-Jacques < fsaintjacq...@gmail.com> wrote: > +1 > > On Mon, Mar 22, 2021 at 8:33 AM Andrew Lamb wrote: > > > > +1 > > > > On Sun, Mar 21, 2021 at 7:08 PM paddy horan > wrote: > > > > > +1 (non-binding) > > > > > > > > > __

Re: [VOTE] Accept donation of Rust Ballista project

2021-03-23 Thread Francois Saint-Jacques
+1 On Mon, Mar 22, 2021 at 8:33 AM Andrew Lamb wrote: > > +1 > > On Sun, Mar 21, 2021 at 7:08 PM paddy horan wrote: > > > +1 (non-binding) > > > > > > > > From: Sutou Kouhei > > Sent: Sunday, March 21, 2021 4:34:43 PM > > To: dev@arrow.apache.org > > Subject: R

[NIGHTLY] Arrow Build Report for Job nightly-2021-03-23-0

2021-03-23 Thread Crossbow
Arrow Build Report for Job nightly-2021-03-23-0 All tasks: https://github.com/ursacomputing/crossbow/branches/all?query=nightly-2021-03-23-0 Failed Tasks: - conda-linux-gcc-py37-aarch64: URL: https://github.com/ursacomputing/crossbow/branches/all?query=nightly-2021-03-23-0-drone-conda-linux

Re: Wrap Unwarp Scalars in Cython API

2021-03-23 Thread Antoine Pitrou
Hi Vibhatha, The APIs exist and are declared (in Cython) as: cdef public object pyarrow_wrap_scalar(const shared_ptr[CScalar]& sp_scalar) cdef public shared_ptr[CScalar] pyarrow_unwrap_scalar(object scalar) However, it appears that we forgot to document them. Regards Antoine. Le 23/03/20

Re: [Java] Source control of generated flatbuffers code

2021-03-23 Thread Micah Kornfield
I think checking in the java files is fine and probably better then relying on a third party package. We should make sure there are instructions on how to regenerate them along with the PR On Monday, March 22, 2021, Antoine Pitrou wrote: > > Le 22/03/2021 à 20:17, bobtins a écrit : > >> TL;DR: