Re: C++: Covariant Return Types for Array::type()

2018-05-19 Thread Wes McKinney
> This will break a lot of stuff, e.g. a lot of the IPC read path > (https://github.com/apache/arrow/blob/master/cpp/src/arrow/ipc/reader.cc) > would have to be rewritten. Just to highlight a point from the IPC part of the project -- the entire read path for record batches does not touch the Arr

Re: C++: Covariant Return Types for Array::type()

2018-05-19 Thread Wes McKinney
On Sat, May 19, 2018 at 10:28 PM, Joshua Storck wrote: > In regards to the CopyData function that you mentioned in util-internal.h, > I don't think you need an ArrayData class to achieve that functionality. If > that data was in the Array base class, that function could have been > defined with ei

Proposed Arrow Graph representations

2018-05-19 Thread Paul Taylor
At GTC San Jose last month, NVidia's Joe Eaton (cc'd) presented on the nvGraph team's goals for accelerating in-memory graph processing and analytics. A major component of that is advancing and standardizing a common, efficient representation for graphs that c

Re: C++: Covariant Return Types for Array::type()

2018-05-19 Thread Joshua Storck
In regards to your question about returning DataType&, one of the goals of the proposal is to pass shared pointers to concrete data type sub-classes in array constructors to increase type safety. If you return a reference in the type() function, you would need to make a copy of the data type to get

Re: C++: Covariant Return Types for Array::type()

2018-05-19 Thread Joshua Storck
In regards to the CopyData function that you mentioned in util-internal.h, I don't think you need an ArrayData class to achieve that functionality. If that data was in the Array base class, that function could have been defined with either of these signatures: template void CopyData(const I& in,

Re: Rust IPC and Integration Testing

2018-05-19 Thread Wes McKinney
Sorry to hear, it's a bit of a rough situation with Flatbuffers and Rust. One possibility is to build an interface to the Flatbuffers data via flatcc (https://github.com/dvidelabs/flatcc) -- I wonder if these bindings are header-only like C++ and if that makes things any easier for you. If you def

Re: C++: Covariant Return Types for Array::type()

2018-05-19 Thread Wes McKinney
hi Josh, On Sat, May 19, 2018 at 1:53 PM, Joshua Storck wrote: > I've updated the document with an extra section to include code snippets > for alternative designs to address concerns raised here on the mailing list. Thanks, I will look in more detail and reply more later > > MSVC 19 2017 suppo

Re: C++: Covariant Return Types for Array::type()

2018-05-19 Thread Joshua Storck
I've updated the document with an extra section to include code snippets for alternative designs to address concerns raised here on the mailing list. MSVC 19 2017 supports covariant return types, and the code presented above successfully compiled on gcc.godbolt.org using that compiler. I would ag

[jira] [Created] (ARROW-2615) [Rust] Refactor introduced a bug around Arrays of String

2018-05-19 Thread Andy Grove (JIRA)
Andy Grove created ARROW-2615: - Summary: [Rust] Refactor introduced a bug around Arrays of String Key: ARROW-2615 URL: https://issues.apache.org/jira/browse/ARROW-2615 Project: Apache Arrow Issue

[jira] [Created] (ARROW-2614) [CI] Remove 'group: deprecated' in Travis

2018-05-19 Thread Uwe L. Korn (JIRA)
Uwe L. Korn created ARROW-2614: -- Summary: [CI] Remove 'group: deprecated' in Travis Key: ARROW-2614 URL: https://issues.apache.org/jira/browse/ARROW-2614 Project: Apache Arrow Issue Type: Task

[jira] [Created] (ARROW-2613) [Docs] Update the gen_apidocs docker script

2018-05-19 Thread Uwe L. Korn (JIRA)
Uwe L. Korn created ARROW-2613: -- Summary: [Docs] Update the gen_apidocs docker script Key: ARROW-2613 URL: https://issues.apache.org/jira/browse/ARROW-2613 Project: Apache Arrow Issue Type: New

Re: C++: Covariant Return Types for Array::type()

2018-05-19 Thread Wes McKinney
hi Josh, Thank you for putting together this document. These changes are interesting and worth giving some consideration. Some initial reactions / questions to get a discussion going: * How is MSVC support for covariant return types? It doesn't look like it's supported, which (I'm sorry to say) w

Re: [RESULT] [VOTE] Accept donation of Arrow Ruby bindings

2018-05-19 Thread Wes McKinney
Hi Kou -- I plan to update the IP clearance website and start the vote on the Incubator mailing list. I apologize for not getting it done yet, I have some time today to work on it. Best Wes On Sat, May 19, 2018, 2:53 AM Kouhei Sutou wrote: > Hi, > > Thanks all! > > What should I do as the next