Re: Writing empty strings to parquet files

2018-05-04 Thread Wes McKinney
Thanks Sergio. If we don't have any unit tests explicitly testing this, it would be a good idea to add some anyway. - Wes On Fri, May 4, 2018 at 12:26 PM, wrote: > Hi Uwe: > > Thanks a lot for your feedback. > > While preparing a simple example to reproduce this issue, I have been able to > ge

[jira] [Created] (ARROW-2542) [Plasma] Refactor object notification code

2018-05-04 Thread Philipp Moritz (JIRA)
Philipp Moritz created ARROW-2542: - Summary: [Plasma] Refactor object notification code Key: ARROW-2542 URL: https://issues.apache.org/jira/browse/ARROW-2542 Project: Apache Arrow Issue Type:

[jira] [Created] (ARROW-2541) [Plasma] Clean up macro usage

2018-05-04 Thread Philipp Moritz (JIRA)
Philipp Moritz created ARROW-2541: - Summary: [Plasma] Clean up macro usage Key: ARROW-2541 URL: https://issues.apache.org/jira/browse/ARROW-2541 Project: Apache Arrow Issue Type: Improvement

Re: Writing empty strings to parquet files

2018-05-04 Thread scarrascoso
Hi Uwe: Thanks a lot for your feedback. While preparing a simple example to reproduce this issue, I have been able to get the expected behavior (empty strings properly written as ‘’ in the parquet file). So actually there’s no problem with the Parquet.write_table The problem was rather in a bu

Re: Refactoring the Rust API

2018-05-04 Thread Andy Grove
Here's my blog post explaining the refactor: https://andygrove.io/2018/05/apache-arrow-traits-generics/ The Reddit thread is going to be here for anyone wanting to see the feedback: https://www.reddit.com/r/rust/comments/8gy45t/refactoring_apache_arrow_to_use_traits_and/ Thanks, Andy. On Wed, M

Re: Writing empty strings to parquet files

2018-05-04 Thread Uwe L. Korn
Hello Sergio, this is definitely unwanted behaviour. Can you open an issue on https://issues.apache.org/jira/projects/PARQUET and provide a minimal reproducing example. There is definitely a difference between empty strings and null strings. Parquet also supports the differentiation thus we sho

[jira] [Created] (ARROW-2540) [Plasma] add constructor/destructor to make sure dlfree is called automatically

2018-05-04 Thread Zhijun Fu (JIRA)
Zhijun Fu created ARROW-2540: Summary: [Plasma] add constructor/destructor to make sure dlfree is called automatically Key: ARROW-2540 URL: https://issues.apache.org/jira/browse/ARROW-2540 Project: Apache

[jira] [Created] (ARROW-2539) [Plasma] Use unique_ptr instead of raw pointer

2018-05-04 Thread Zhijun Fu (JIRA)
Zhijun Fu created ARROW-2539: Summary: [Plasma] Use unique_ptr instead of raw pointer Key: ARROW-2539 URL: https://issues.apache.org/jira/browse/ARROW-2539 Project: Apache Arrow Issue Type: Impro