Re: Release Apache APISIX 2.11.0 Round 2

2021-11-25 Thread Zeping Bai
+1 (non-binding) I checked: 1. Download links are OK. 2. Checksum and signature are OK. 3. LICENSE and NOTICE files are exist. 4. Building on Gitpod (Ubuntu 20.04) was successful. Zeping Bai @bzp2010 孙毅 于2021年11月23日周二 下午8:48写道: > Hello, Community, > This is a call for the vote to release Apa

Re: Here are some feedbacks from our developers

2021-11-25 Thread Zexuan Luo
> Community maintainers should lead us to learn about them as well. >From the above 3 PRs, I have led us to contribute in a good way. For the first case: In https://github.com/apache/apisix/pull/4892, I told the contributor: > Smart people like you should focus on advanced issues. See https://g

Re: Here are some feedbacks from our developers

2021-11-25 Thread Ming Wen
Hi, zexuan, I think this is a discussion, not blamed, please relax :) We may have different views on PR, but we should respect each other. In my opinion, low-quality PRs will indeed increase the workload of maintainers, so you can choose different PRs to review, and ignore PRs that you are not int

Re: Here are some feedbacks from our developers

2021-11-25 Thread Zexuan Luo
The word from Zhiyuan Ju is misleading. These words will hurt my reputation if I don't explain myself clear. Unfortunately, I am a person who sees his honor as very important. If I don't tell my story, I can not go asleep. Let me quote his sentences and **correct** them here: > 2.1.3 This PR gets

Consumer identification from OpenId/Keycloak token

2021-11-25 Thread Joga, singh
Hi Guys, I was advised on the discussions group to post my query here to see if somebody has already similar in mind. I have my consumers already defined in Keycloak. Consumers get the token using Client Credentials flow i.e. using ClientId and ClientSecret. Using ‘openid-connect’ plugin I am a

[Proposal] AWS lambda serverless plugin into Apache APISIX

2021-11-25 Thread Bisakh Mondal
Hi folks, This is a proposal to integrate AWS Lambda serverless support into Apache APISIX. We just have integrated the azure functions faas plugin into the ecosystem and the addition of lambda from aws will extend the use case of apisix in diverse scenarios. Proposed plugin name: `aws-lambda` T

Re: Consumer identification from OpenId/Keycloak token

2021-11-25 Thread ZhengSong Tu
1. Did you mean to put the consumer_name to the ctx in open-connect plugin? 2. Then we can limit by consumer_name in limit-* plugins. *ZhengSong Tu* My GitHub: https://github.com/tzssangglass Apache APISIX: https://github.com/apache/apisix Joga, singh 于2021年11月26日周五 上午12:26写道: > > Hi Guys, > I w

[Proposal] Add blog contribution guidelines to apisix-website repository

2021-11-25 Thread Yilin Zeng
Hi community, Currently apisix-website repository[1] does not have a set of blog contribution guidelines. It could block potential contributors who want to write blogs but cannot find the proper way to do it. As I was reaching out to other open-source communities in the last two weeks, I went

Re: [Proposal] Add blog contribution guidelines to apisix-website repository

2021-11-25 Thread Sylvia
Hi Yilin, I think this proposal is very good, and it is more convenient to help contributors who want to share content instantly. Look forward to the guideline! Best Regards, Sylvia Yilin Zeng 于2021年11月26日周五 下午2:20写道: > Hi community, > > > Currently apisix-website repository[1] does not have

Re: [Proposal] Add blog contribution guidelines to apisix-website repository

2021-11-25 Thread jing li
Nice proposal +1~ There are indeed many people who have written blogs related to APISIX , but don’t know how to submit to our website. On Fri, Nov 26, 2021 at 2:27 PM Sylvia wrote: > Hi Yilin, > > I think this proposal is very good, and it is more convenient to help > contributors who want to s

Re: [Proposal] Add blog contribution guidelines to apisix-website repository

2021-11-25 Thread Serendipity 96
Hi Yilin, Great idea! I also think we should add contribution guidelines, it will help new partners. What do you think to add a blog template? just like: 1 What can you contribute 1.1 the way to add a new blog 1.2 Fix typos or formats 1.3 blog template Looking forward++! Best Regards, @Seren

Re: Release Apache APISIX 2.11.0 Round 2

2021-11-25 Thread JinChao Shuai
+1 (binding) I checked: 1. Download links are OK. 2. Checksum and signature are OK. 3. LICENSE and NOTICE have existed. 4. Building on Ubuntu 20.04 was successful. Zeping Bai 于2021年11月25日周四 下午5:44写道: > +1 (non-binding) > > I checked: > 1. Download links are OK. > 2. Checksum and signature are OK

Re: Here are some feedbacks from our developers

2021-11-25 Thread Serendipity 96
> In my own opinion, lacking a "Contribution Chain/Workflow" is the key point why Apache APISIX will receive those PRs. We think they know, actually not. I agree with this view. I didn't know what to do before I contributed code for the first time. I consulted my friend who had contributed to open

Re: [ANNOUNCE] New committer Shivam Singh

2021-11-25 Thread Serendipity 96
Congratulations! Best Regards @Serendipity96 Sylvia 于2021年11月25日周四 09:46写道: > Hi Shivam, > > I'm Sylvia. After our discussion, I think you should go to the official > website(https://github.com/apache/apisix-website) and submit PR for this > article( > https:/

Re: [ANNOUNCE] New committer Shivam Singh

2021-11-25 Thread Bozhong Yu
Congratulations! Serendipity 96 于2021年11月26日周五 下午3:22写道: > Congratulations! > > Best Regards > @Serendipity96 > > Sylvia 于2021年11月25日周四 09:46写道: > > > Hi Shivam, > > > > I'm Sylvia. After our discussion, I think you should go to the official > > website(https:/