Re: [DISCUSS] Share a site about commit specification

2019-10-26 Thread Justin Mclean
Hi, > Happy to be that we use a squash based workflow as this link says[3], and > only collaborators have access to Squash & Merge PR into the master branch. Who do you mean by collaborators? Only project committers will have access to the master branch. Thanks, Justin

Re: [DISCUSS] Share a site about commit specification

2019-10-25 Thread Zhiyuan Ju
Send a PR after several conversations in an issue is pretty clear & good :) Ming Wen 于 2019年10月26日周六 10:19写道: > thanks, zhiyuan. > Apache APISIX has a simple guidance[1] for PR and commit message now, but I > think conventionalcommits is better, > especially it can be generated changelog automa

Re: [DISCUSS] Share a site about commit specification

2019-10-25 Thread Ming Wen
thanks, zhiyuan. Apache APISIX has a simple guidance[1] for PR and commit message now, but I think conventionalcommits is better, especially it can be generated changelog automatically. [1] https://github.com/iresty/apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-

[DISCUSS] Share a site about commit specification

2019-10-25 Thread Zhiyuan Ju
Hi, I'm glad to *share* a site[1][2], which contains some specifications about Git commit messages. Happy to be that we use a squash based workflow as this link says[3], and only collaborators have access to Squash & Merge PR into the master branch. [1] Chinese Version https://www.conventionalco