Hi,
+1,
I checked:
- Download links are valid.
- Checksums and PGP signature are valid.
- DISCLAIMER file is included.
- LICENSE and NOTICE files are good.
- No binary files.
- compiled and ran quick start on CentOS 7
Zhiyuan Ju 于2020年1月7日周二 上午10:20写道：
> Hi,
>
> +1,
>
> I checked:
>
> - Downl
+1
---Original---
From: "Linsir Wu"https://github.com/apache/incubator-apisix/blob/v1.0/CHANGELOG.md#100
>
>
> The release candidates:
>
> https://dist.apache.org/repos/dist/dev/incubator/apisix/1.0-rc1/
>
>
> Git tag for the release:
>
> https://github.com/apache/i
+1 ( binding )
I checked:
- download links are valid
- signatures and hashes fine
- DISCLAIMER exists
- LICENSE and NOTICE good
- no binary files in release
- all source file have ASF headers
- compiled and ran quick start on CentOS 7
YuanSheng Wang 于2020年1月3日周五 下午3:58写道：
> Hello, Community,
>
cool, the Apache Kafka plugin is really what we want.
Looking forward to this PR.
Thanks,
Ming Wen, Apache APISIX
Twitter: _WenMing
蔡兴 于2020年1月7日周二 上午11:02写道：
> Hi, all,
> I want to add a log plugin which produce log through kafka
>
> The general information is as follows:
> 1. Collect log inf
Hi, all,
I want to add a log plugin which produce log through kafka
The general information is as follows:
1. Collect log information
2. Get kafka config
3. Send kafka msg
A brief code presentation:
```
local producer = require "resty.kafka.producer"
function _M.log(conf, ctx)
local cons
Hi:
https://github.com/apache/incubator-apisix/pull/840
Features are duplicated, but for CORS this plugin is easier to use.
On Tue, Jan 7, 2020 at 10:31 AM Ming Wen wrote:
> Hi, dequan,
> looks good to me. We can discuss the details in PR.
>
> Thanks,
> Ming Wen, Apache APISIX
> Twitter: _Wen
Hi, dequan,
looks good to me. We can discuss the details in PR.
Thanks,
Ming Wen, Apache APISIX
Twitter: _WenMing
li dequan 于2020年1月7日周二 上午10:17写道：
> Hi:
>
> Add a CORS plugin to APISIX.
>
> The following is the code of the cors plugin
>
> --
> -- Created by IntelliJ IDEA.
> -- User: lidequan
Hi, yuansheng,
I guess the link[1] in your first email is misleading.
I think your original intention was to add a driver to parse the GeoIP2
library,
and it will not add a binary GeoIP2 database to the repo, right?
Back to Justin's question, GeoIP2 also provides the geolite2 version[2],
which is
Hi,
+1,
I checked:
- Download links are valid.
- Checksums and PGP signature are valid.
- DISCLAIMER file is included.
- LICENSE and NOTICE file are good.
- No binary files.
- All files have valid ASF header by executing *ack -L "(ASF)"* command on
MacOS.
BTW, it seems that gmail couldn't handl
Hi:
Add a CORS plugin to APISIX.
The following is the code of the cors plugin
--
-- Created by IntelliJ IDEA.
-- User: lidequan
-- Date: 2019-10-10
-- Time: 20:40
-- To change this template use File | Settings | File Templates.
--
local func = require("apisix.libs.func")
local core = require("ap
> Perhaps / perhaps not - it will depend on how this is done and how the
user is informed.
1. this is an optional feature.
2. only some users need to enable this feature.
3. add more documents about how to enable this feature.
BTW, I searched the projects in Apache, the `GeoIP2` library has be
+1
I just checked:
- Download links are valid.
- Checksums and PGP signatures are valid.
- DISCLAIMER is included.
- LICENSE and NOTICE files are good.
- No binary file.
- All files have license headers if necessary.
On Tue, Jan 7, 2020 at 7:29 AM Ming Wen wrote:
> Hi,
> +1
>
> I ju
On Tue, Jan 7, 2020 at 8:22 AM Willem Jiang wrote:
> Oh, it could confuse the user, even he install the APISIX 1.0-RC1, the
> command line response 0.9.0.
> In my option, we need to cut a new release to fix this issue .
>
Agree with this.
Voting for the 1.0-RC2 version started yesterday.
>
>
Oh, it could confuse the user, even he install the APISIX 1.0-RC1, the
command line response 0.9.0.
In my option, we need to cut a new release to fix this issue .
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Tue, Jan 7, 2020 at 8:12 AM Ming Wen wrote:
>
> Hi, Willem,
> This bug will not
Hi, Willem,
This bug will not affect the functionality of Apache APISIX.
When users check the version of Apache APISIX, they will get an old version
0.9 instead of the latest 1.0.
Because we forgot to update the version[1].
If we can specify it in the release note as a known issue, that would be
If the bug is critical issue, we may cancel the vote, but if it's a
minor one , we can specify it in the release note as a know issue.
Please share the information of the bug if it is not a security issue,
then we can revalue it.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Tue, Jan 7,
Hi,
+1
I just checked:
- Download links are valid.
- Checksums and PGP signatures are valid.
- DISCLAIMER is included.
- LICENSE and NOTICE files are good.
- No binary file.
- All files have license headers if necessary.
Thanks,
Ming Wen, Apache APISIX
Twitter: _WenMing
YuanSh
Hi,
> We only provide GeoIP2 driver code, APISIX users should fetch the IP
> database by himself if they want to enable the IP location feature.
>
> So I think that is fine for the license.
Perhaps / perhaps not - it will depend on how this is done and how the user is
informed. [1]
Thanks,
Jus
Hi,
> Because of this bug, we have to cancel this vote and release 1.0-rc2 later.
> Sorry for this mistake.
It's fine to release stuff with minor issues, bugs like this can be fixed in
the next release.
Thanks,
Justin
Hello, Community,
New changes between 1.0-RC1:
change: updated major version to 1.0 .
doc: updated version to 1.0 .
doc: update NOTICE year .
I am glad to invite everyone to move on to check and vote for our 1.0-RC2.
Release notes:
https://github.com/apache/incubator-apisix/blob/v1.0/CHANG
>
> My reading of that page is that you would need a commercial license and
> that would mean it's not compatible with the Apache License.
>
We only provide GeoIP2 driver code, APISIX users should fetch the IP
database by himself if they want to enable the IP location feature.
So I think that is
Because of this bug, we have to cancel this vote and release 1.0-rc2 later.
Sorry for this mistake.
Thanks,
Ming Wen, Apache APISIX
Twitter: _WenMing
YuanSheng Wang 于2020年1月6日周一 下午5:43写道：
> Hi:
>
> I will release a new version later.
>
> We need to update this version information[1].
>
> I am
+1 ( binding )
I checked the following.
1. Incubating in name.
2. PGP Signatures.
3. SHA512 Checksums.
4. DISCLAIMER exists.
5. LICENSE and NOTICE are fine.
6. No unexpected binary files.
Regards
Kevin
On Mon, Jan 6, 2020 at 3:13 PM YuanSheng Wang wrote:
> Hi:
>
> I will release a new versio
Hi:
I will release a new version later.
We need to update this version information[1].
I am writing a new script to check this.
[1]
https://github.com/apache/incubator-apisix/blob/v1.0/lua/apisix/core/version.lua#L18
On Mon, Jan 6, 2020 at 4:29 PM Justin Mclean
wrote:
> Hi,
>
> +1 (binding)
+1 (binding)
I check those:
[Y] Download links are valid.
[Y] Checksums and PGP signatures are valid.
[Y] DISCLAIMER is included.
[Y] LICENSE and NOTICE files are good.
[Y] No binary file.
[Y] All files have license headers if necessary.
It works fine on (docker) alpine 3.7, with:
luarocks: 3.2.
Hi,
+1 (binding) Please fix the NOTICE year for the next release.
I checked:
- incubating in name
- signatures and hashes are fine
- Disclaimer exists
- LICENSE is good
- NOTICE has wrong year please fix
- no unexpected binary files
- all source file have ASF headers
- can compile from source
Th
Hi,
> Add a free and available IP library to APISIX, what do you think about
> GeoIP2?
My reading of that page is that you would need a commercial license and that
would mean it's not compatible with the Apache License.
Thanks,
Justin
Hi,
Just a note only IPMC members are actually binding on incubator releases, but
it’s expected that you get 3 +1 PPMC votes on the dev list vote.
Thanks,
Justin
Hi:
Is there any way to avoid `decode_args` fully?
If you only need part fields, you can use other ways to parse it, for
example, we can use `string.find` + `string.sub`.
On Mon, Jan 6, 2020 at 3:36 PM hui li wrote:
> Hi, all.
> The ngx.decode_args interface is time consuming. Is there a bett
Hi:
Add a free and available IP library to APISIX, what do you think about
GeoIP2?
Here is the link[1].
[1] https://www.maxmind.com/en/geoip2-databases
--
*MembPhis*
My github: https://github.com/membphis
Apache APISIX: https://github.com/apache/incubator-apisix
30 matches
Mail list logo
