[DISCUSS] When will we support fill in domain to nodeX when adding an upstream?

2019-11-18 Thread Lang Wang
Hi devs, In the k8s service scenario, an upstream maybe like *$SVC.$NS.svc.cluster.local:$PORT, *and the service's ip is None when we set it's type to ClusterIP:None. but apisix only support ip for the Nodex value now.

Re: [VOTE] Release Apache APISIX (Incubating) 0.9-RC1 ROUND 2

2019-11-18 Thread 吴钧泽
+1 (binding) I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists - LICENSE and NOTICE good - no unexpected binary files in release - all source file have ASF headers - can compile and can work on ubuntu18.04 On MacOS10.15.1 AND ubuntu 18.04, the APISIX works fine.

Re: [VOTE] Release Apache APISIX (Incubating) 0.9-RC1 ROUND 2

2019-11-18 Thread junxu chen
+1 ( binding ) I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists - LICENSE and NOTICE good - no unexpected binary files in release - all source file have ASF headers - compiled and ran QuickStart on macOS On Tue, Nov 19, 2019 at 1:38 PM ke tang wrote: > +1 (bindin

Re: [VOTE] Release Apache APISIX (Incubating) 0.9-RC1 ROUND 2

2019-11-18 Thread ke tang
+1 (binding) I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists - LICENSE and NOTICE good - no unexpected binary files in release - all source file have ASF headers - can compile and can work on ubuntu18.04 On ubuntu 18.04, the APISIX works fine. Kevin Ratnasekera

Re: [VOTE] Release Apache APISIX (Incubating) 0.9-RC1 ROUND 2

2019-11-18 Thread Kevin Ratnasekera
+1 ( binding ) I checked the following. 1. Incubating in name. 2. PGP Signature. 3. SHA512 Checksum. 4. DISCLAIMER exists. 5. LICENSE and NOTICE are fine. 6. No unexpected binary files. Regards Kevin On Tue, Nov 19, 2019 at 9:41 AM YuanSheng Wang wrote: > +1 (binding) > > I checked: > - incub

Re: [VOTE] Release Apache APISIX (Incubating) 0.9-RC1 ROUND 2

2019-11-18 Thread YuanSheng Wang
+1 (binding) I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists - LICENSE and NOTICE good - no unexpected binary files in release - all source file have ASF headers After downloading the tar package and installing the dependencies, it is normal. Then I start the Apac

Re: [VOTE] Release Apache APISIX (Incubating) 0.9-RC1 ROUND 2

2019-11-18 Thread JinChao Shuai
Hi, +1 (binding) I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists - LICENSE and NOTICE good - no unexpected binary files in release - all source file have ASF headers Tested using the CentOS7 system, the verification, compilation, installation, and startup process

Re: [VOTE] Release Apache APISIX (Incubating) 0.9-RC1 ROUND 2

2019-11-18 Thread Linsir Wu
Hi, +1 (binding) This should probably be called RC2 (RC stands for release candidate). Putting it in the same spot as the previous one can be confusing. I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists - LICENSE and NOTICE good - no unexpected binary files in rele

Re: How to protect apis like apisix/admin/xxxx

2019-11-18 Thread liyong
Maybe the best practices we talked can apply back to apisix like dev mode and prod mode. On Mon, Nov 18, 2019 at 8:40 PM Lang Wang wrote: > This self mod nginx.conf maybe flushed by` apisix init`. > > > 在 2019年11月18日星期一,liyong 写道: > > > The simplest method is to only allow loopback interface(12

Re: [VOTE] Release Apache APISIX (Incubating) 0.9-RC1 ROUND 2

2019-11-18 Thread Justin Mclean
Hi, +1 (binding) This should probably be called RC2 (RC stands for release candidate). Putting it in the same spot as the previous one can be confusing. I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists - LICENSE and NOTICE good - no unexpected binary files in rel

Re: [DISCUSS] Is this the best practice to use dashboard on current master branch?

2019-11-18 Thread Lang Wang
Yep, i did it indeed.. :-( jenkins console log : + yarn install yarn install v1.12.1 [1/4] Resolving packages... success Already up-to-date. Done in 0.64s. [Pipeline] sh + yarn build:prod yarn run v1.12.1 $ vue-cli-service build 在 2019年11月18日星期一,Zhiyuan Ju 写道: > You need to execu

Re: [DISCUSS] Is this the best practice to use dashboard on current master branch?

2019-11-18 Thread Zhiyuan Ju
You need to execute `yarn build:prod` command :) Best Regards! @ Zhiyuan Ju Lang Wang 于2019年11月18日周一 下午8:54写道: > Hi zhenyuan, > > The dashboard cannot be reached (multi 404 errors) via current master > branch + files from : > https://github.com/apache/incubator-api

Re: [DISCUSS] Is this the best practice to use dashboard on current master branch?

2019-11-18 Thread Lang Wang
Hi zhenyuan, The dashboard cannot be reached (multi 404 errors) via current master branch + files from : https://github.com/apache/incubator-apisix-dashboard.git ( after `yarn install` & `yarn prod:build`) So i use files from repo : https://github.com/apache/incubator-apisix-dashboard-built , and

Re: How to protect apis like apisix/admin/xxxx

2019-11-18 Thread Lang Wang
This self mod nginx.conf maybe flushed by` apisix init`. 在 2019年11月18日星期一,liyong 写道: > The simplest method is to only allow loopback interface(127.0.0.1) access, > this can be done in the nginx.conf: > location /apisix/admin { > allow 127.0.0.0/24; > deny all; > > content_by_lua_blo

Re: [VOTE] Release Apache APISIX (Incubating) 0.9-RC1 ROUND 2

2019-11-18 Thread Linsir Wu
Hi, +1 (binding) I just checked: - Download links are valid. - Checksums and PGP signatures are valid. - DISCLAIMER is included. - LICENSE and NOTICE files are good. - No binary file. - All files have license headers if necessary. Ming Wen 于2019年11月16日周六 上午12:21写道: > Hello,