Re: Review of PRs

2019-11-01 Thread Ming Wen
Hi, yuan sheng, I don't think you have to ping me specifically. When one PR has new commit, I will receive emails and website notifications from Github. Thanks, Ming Wen, Apache APISIX Twitter: _WenMing YuanSheng Wang 于2019年11月1日周五 下午11:11写道: > This is because he reviewed the PR and requested

Re: [GitHub] [incubator-apisix-docker] moonming commented on a change in pull request #30: Simplify the docker run documentation and run quickly with docker-com…

2019-11-01 Thread Ming Wen
Thanks for your reminder. Thanks, Ming Wen, Apache APISIX Twitter: _WenMing Justin Mclean 于2019年11月1日周五 下午6:22写道: > Hi, > > > +$ docker pull iresty/apisix:latest > > > > Review comment: > > we will upload the image to Apache later. > > Take case that you don’t pull the latest from master, bu

Re: [incubator-apisix] branch master updated: Bugfix: change dir apisix into incubator-apisix (#762)

2019-11-01 Thread YuanSheng Wang
> This is not allowed as you are directing users to unreleased source code, they can only be directed to released versions of APISIX that have been voted on my the projects PPMC. Got it, I will try to fix it later. On Fri, Nov 1, 2019 at 6:30 PM Justin Mclean wrote: > Hi, > > > Apache APISIX ca

Re: Review of PRs

2019-11-01 Thread Justin Mclean
Hi, > This is because he reviewed the PR and requested a change. > > After resolving these issues, we need him to confirm that the changes are > correct. Is this workflow documented anywhere on the website? How would someone new to teh project find this out? Thanks, Justin

Re: [incubator-apisix] branch master updated: Bugfix: change dir apisix into incubator-apisix (#762)

2019-11-01 Thread YuanSheng Wang
I created a new issue about this question: https://github.com/apache/incubator-apisix/issues/788 On Fri, Nov 1, 2019 at 11:06 PM YuanSheng Wang wrote: > > This is not allowed as you are directing users to unreleased source > code, they can only be directed to released versions of APISIX that ha

Re: Review of PRs

2019-11-01 Thread YuanSheng Wang
This is because he reviewed the PR and requested a change. After resolving these issues, we need him to confirm that the changes are correct. That is why I ping him. On Fri, Nov 1, 2019 at 8:01 PM Justin Mclean wrote: > HI, > > I’m notice a lot of PRs with "@moonming

Review of PRs

2019-11-01 Thread Justin Mclean
HI, I’m notice a lot of PRs with "@moonming please take a look” or words rot that effect, why is this? Thanks, Justin

Re: [incubator-apisix] branch master updated: Bugfix: change dir apisix into incubator-apisix (#762)

2019-11-01 Thread Justin Mclean
Hi, > Apache APISIX can be installed via Luarocks automatically, but the Luarocsk > cannot fetch the folder dashboard, because of it is a git submodule. > > That is why we have to call "git clone" again. This is not allowed as you are directing users to unreleased source code, they can only be

Re: [GitHub] [incubator-apisix-docker] moonming commented on a change in pull request #30: Simplify the docker run documentation and run quickly with docker-com…

2019-11-01 Thread Justin Mclean
Hi, > +$ docker pull iresty/apisix:latest > > Review comment: > we will upload the image to Apache later. Take case that you don’t pull the latest from master, but only the last released version. Thanks, Justin

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #55: bug: Can't load plugin info from API

2019-11-01 Thread GitBox
juzhiyuan commented on issue #55: bug: Can't load plugin info from API URL: https://github.com/apache/incubator-apisix-dashboard/issues/55#issuecomment-548718101 https://github.com/apache/incubator-apisix/issues/785 This is a

[GitHub] [incubator-apisix-dashboard] juzhiyuan closed issue #55: bug: Can't load plugin info from API

2019-11-01 Thread GitBox
juzhiyuan closed issue #55: bug: Can't load plugin info from API URL: https://github.com/apache/incubator-apisix-dashboard/issues/55 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new issue #55: bug: Can't load plugin info from API

2019-11-01 Thread GitBox
juzhiyuan opened a new issue #55: bug: Can't load plugin info from API URL: https://github.com/apache/incubator-apisix-dashboard/issues/55 ## Plugin `serverless-pre-function`, `serverless-post-function` ## Request ``` http://apisix.iresty.com/apisix/admin/schema/plugi

[GitHub] [incubator-apisix-dashboard] justinmclean opened a new issue #54: License information goes in LICENSE not NOTICE

2019-11-01 Thread GitBox
justinmclean opened a new issue #54: License information goes in LICENSE not NOTICE URL: https://github.com/apache/incubator-apisix-dashboard/issues/54 https://github.com/apache/incubator-apisix-dashboard/blob/31cac84fc5f569f4c6b70e048c2bb6e9271bf3a2/NOTICE#L7

Re: [DISCUSS] Some questions about quarterly reports

2019-11-01 Thread Justin Mclean
Hi, > 2.How has the community developed since the last report? > > - Github stars grew from 800+ to 1201 in October. Why would the IPMC or board care about this? Being popular is not the same as community growth. > - Over 13 company users have announced that he is using APISIX: > https://githu

Podling Apisix Report Reminder - November 2019

2019-11-01 Thread jmclean
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 20 November 2019, 10:30 am PDT. The report for your podling will for

[LICENSE] question about apisix-dashboard

2019-11-01 Thread Ming Wen
hello, mentors, We have two standalone repositories about dashboard: incubator-apisix-dashboard[1] and incubator-apisix-dashboard-built [2]. The first one is the source code of APISIX dashboard, and not including in APISIX repo [3]; another one is the production build files from the first o