Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/048015b7d891edd74c8d458aa582a504511872c6#commitcomment-30695466
In src/main/org/apache/tools/ant/taskdefs/Javadoc.java:
In src/main/org/apache/tools/ant/taskdefs/Javadoc.java on line 572
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/d100b900324ad91f3de6e8c323720e1676bbb28d#commitcomment-30927697
In src/main/org/apache/tools/ant/taskdefs/AbstractJarSignerTask.java:
In src/main/org/apache/tools/ant/taskdefs
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/0cb9d22b77dda1dcabba91d4c2a1616d0042d16c#commitcomment-31140697
In
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java:
In
src/main/org/apache/tools/ant
GitHub user twogee opened a pull request:
https://github.com/apache/ant/pull/78
A new CharSet type to hold available Charset names
I believe that might be useful when validating "encoding" (or "charset")
attributes
You can merge this pull request into a Git r
GitHub user twogee opened a pull request:
https://github.com/apache/ant/pull/79
Make DataType and Reference generic
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twogee/ant checked-reference
Alternatively you can review and
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant/pull/78#discussion_r232795363
--- Diff: src/tests/junit/org/apache/tools/ant/types/CharSetTest.java ---
@@ -0,0 +1,20 @@
+package org.apache.tools.ant.types;
+
+import
Github user twogee commented on the issue:
https://github.com/apache/ant/pull/78
License headers added. Yes, it should be used with `setEncoding` (or in
some tasks `setCharset`). Now that I think about it image/imageio tasks have an
"encoding" attribute which is a misnomer
Github user twogee closed the pull request at:
https://github.com/apache/ant/pull/78
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user twogee closed the pull request at:
https://github.com/apache/ant/pull/79
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31691133
`src/etc/poms/ant/pom.xml` should exclude the new tasks from compilation;
Maven builds are Java 8 only
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31691241
Yes, that's the idea.
---
-
To unsubscribe, e-mail
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692367
Thanks, perhaps it's time for [multi-release
jars](https://maven.apache.org/plugins/maven-compiler-plugin/multirelease
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692461
In src/main/org/apache/tools/ant/types/ModuleVersion.java:
In src/main/org/apache/tools/ant/types/ModuleVersion.java on line 51
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/20
BasicURLHandler crashed... ":" need to be URL encoded?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/20
I am afraid that Ivy allows for a misfeature here. Note that you must test
this on Windows because colon is not allowed in NTFS filenames:
https://kb.acronis.com/content/39790
---
If your project
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/20
I can assure you that colon in version has NEVER have worked on Windows.
Test case
```
import java.io.*;
public class TestColonNTFS {
public static void main(String[] args
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/20
"Making something that worked previously on a specific platform in specific
circumstances work again" is not a good argument, especially when the coverage
of the test case is incomplete. U
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/20
On the second thought, if PR changes the way to identify the system root,
then the test cases should be specifically for that, not for parsing of
versions with reserved/unsafe URL characters
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/31
Convert tests to JUnit 4, clean up code
JUnit 4 has primarily two benefits, clarity through annotations and more
fine grained control of failures
You can merge this pull request into a Git
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/31
Thanks for a nice summary and pointing out a paradigm that I did not
investigate entirely. The essential work also included checking that all
appropriate setUp() and tearDown() were public and/or
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/31
I left a few `fail()`s where multiple assertions were made; I guess that
requires a custom @Rule.
Also, in `FileSystemResolverTest`, I moved `finally` blocks to
`tearDown()`. Strangely, that
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/32
A few loose bits in JUnit 4 migration
This adds annotations that are missing, migrates example code and fixes
whitespace
You can merge this pull request into a Git repository by running:
$ git
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/32
Why is Jenkins lacking org.apache.tools.ant.util.ProcessUtil? Something
wrong with Ant?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/31
I do ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/32
Unless I'm mistaken, `BuildFileRule` was available first in 1.9.5;
`ProcessUtil` needs 1.9.4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/32
Jenkins build was complete an hour ago, but status on Github is still
pending...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/33
More code cleanup
Your janitor is here again ð
This drops commons-lang as test dependency, removes unused imports,
simplifies if's and corrects a bunch of misspellings.
You can
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/36
Replace emma with jacoco
This modernises the reporting of code coverage.
Please try it out.
NB! On macOS, it tickles https://bugs.openjdk.java.net/browse/JDK-8022291
which is harmless
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/36
P.S. Any suggestions about finding out which rules do not work in
Checkstyle are much appreciated. I had to resort to trial and error.
Also, Ant includes a [different
variant](https
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/36
By default, jacoco "log" gets extension ".exec"; I'd rather call it
".data". I can amend the PR later tonight.
Could you please check your classpath fo
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/36
JaCoCo "log" gets an extension ".data";
JaCoCo reports are generated when JUnit fails;
Checkstyle rules sync'ed with Ant.
Anything else?
I found ou
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/37
Thanks, could this PR be merged? Then I'll clean up #36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/36
Revised accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/36
There are reports about the "log" file getting corrupt when it accumulates
results from multiple runs. If 'ant clean' helps, then perhaps the "log" file
must be removed
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/37
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/36
Thanks! BTW I had to keep the "test-coverage" target as an alias because
that's what the Jenkins scripts expect. That's another adjustment for later...
---
If your project is se
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/39
first batch of SVG replacements
Try them out and enjoy! The images have their width and height removed,
scaling must be controlled by CSS.
You can merge this pull request into a Git repository by
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/40
Thanks, I forgot to rebuild the snapshot before pushing the changes ð
Perhaps it's worth mentioning in developer doc, which sorely needs revision
now (another regression on my part
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/39
I inlined warning icon; ideally, it should go into CSS as a data URI, but
that belongs to xooki now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/41
Checkstyle
Now that checkstyle rules are sync'ed with Ant, here come the consequences
ð
I guess the famous https://issues.apache.org/jira/browse/IVY-511 is due for
an update...
Yo
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/41
Some of the SVGs are produced by directly by yEd. I guess they're the ones
that miss "Generator". I'll check them and amend accordingly.
---
If your project is set up for it, y
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/41
Sorry about the mess, #41 got conflated with #39.
It's due my inexperience, #39 is on master and #41 is on a branch of it's
own in my repo.
---
If your project is set up for it, you ca
Github user twogee closed the pull request at:
https://github.com/apache/ant-ivy/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/39
Sorry about messing around, I removed execute bits on several test files
and that ended up in #39, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/42
Checkstyle redux
Hopefully the last batch of whitespace changes...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twogee/ant-ivy master
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/43
Generics and other fixes in tests and tutorials
foreach loops are more terse than iterators, and they go well together with
generic -- here's the first stab ð
You can merge this pull re
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/43
Thank you for comments, I'll split the PR and correct according to your
suggestions. Should I remove common-colections altogether and use collections
with generics from Java runtime?
---
If
Github user twogee closed the pull request at:
https://github.com/apache/ant-ivy/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user twogee reopened a pull request:
https://github.com/apache/ant-ivy/pull/43
Generics and other fixes in tests and tutorials
foreach loops are more terse than iterators, and they go well together with
generic -- here's the first stab ð
You can merge this pull re
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/43
Here comes a bunch of new changes: I had to go for Commons Collections 4 to
use generics, and threw in Commons CLI 1.4 for a good measure. I left HTTP
Client 2.0 for the future lest this PR grows
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/43
Sorry for getting carried away with diamonds ð... I put back
`assertFalse(moduleId.equals(null));`
but that assertion is equivalent to
`assertFalse(null instanceOf ModuleId)`
which
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/43
That's exactly why I introduced assertNotNull :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/43
I mean, why use an NPE when one can have an assertion that fails? It's a
cleaner approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/45
Generics + foreach loops and Java 7 in util (except Filter)
Sorry for another largish commit, but I don't see much sense splitting it,
either.
You can merge this pull request into a Git repos
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/45
I pushed new commits which ended up in this PR ð
This adds more generics in ant and tools, only core and plugins left ð
To dispel all scares about generics I added a binary
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/45
I'll put japicmp into a separate PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user twogee closed the pull request at:
https://github.com/apache/ant-ivy/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/48
Generics and Java 7 syntax in osgi and plugins packages
These changes leave only core untouched. Generics are not applied where
Java compiler is unhappy (arrays of generics).
You can merge this
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/49
Aesthetic changes in .gitignore, build.xml and build-release.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twogee/ant-ivy master
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/50
Check spelling, fix whitespace and links
Why can't we drop configuration* in asciidoc?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twoge
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/49
This is a part of #50 now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user twogee closed the pull request at:
https://github.com/apache/ant-ivy/pull/49
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user twogee commented on the pull request:
https://github.com/apache/ant-ivyde/commit/b048846233286ed9bb1ae7fbeab9ab3f58983189#commitcomment-22871013
Isn't Eclipse Oxygen Java 8 only?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user twogee closed the pull request at:
https://github.com/apache/ant-ivy/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/48
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/52
Generics in core
This is as far as I can get without significant changes to API.
Any remaining points of contention are annotated by `@SuppressWarnings`
(and I'm not proud of what `NoF
Github user twogee commented on the pull request:
https://github.com/apache/ant-ivy/commit/6f22f4b49c2a3a59840d28e6cbe0c37a56ab1f90#commitcomment-23069324
Neat! ð Perhaps it would make sense to ask asciidoctorj team to add
support for inlined Ruby and ditto for asciidoctor-ant
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127408025
--- Diff:
src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java ---
@@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File jarjarjarLocation
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/52
Thanks! I will revert the changes regarding the checked exceptions as
suggested in a separate commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127474316
--- Diff:
src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java ---
@@ -148,7 +142,7 @@ public void put(File source, String destination
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127480601
--- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java ---
@@ -306,7 +306,7 @@ public boolean isClosedRange() {
return startVersion.equals
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/52
I committed proposed changes w/o contains(). Please let me know if should
amend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/53
Suppressed warnings
As described in previous PR, all compiler warnings are annotated.
This PR removes a few of them, along with some refactoring.
Changes are grouped in separate commits which
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/54
The PR contains additional changes to HttpClientHandler, introducing
HttpConnectionManagerParams, which is not available in Commons HTTP Client
version 2 (over 10 years old and virtually gone). It
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/54
JSch Session has a single (connection) timeout. There is a GitHub project
to mock ssh/sftp server based on Mina at
https://github.com/shamsoftware/sham-ssh
---
If your project is set up for it
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/54
VsftpRepository has DEFAULT_READ_TIMEOUT and DISCONNECT_COMMAND_TIMEOUT;
would that require an additional timeout attribute?
---
If your project is set up for it, you can reply to this email and
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/54
The code below apparently assumes that client 2.x might still be around; it
is obsolete and this is a perfect opportunity to remove it
```
private HttpClientHelper getHttpClientHelper
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/54
I'd rather have dropping support for 2.x up for vote a.s.a.p. because 3.x
is [EOL](http://hc.apache.org/httpclient-3.x/) already.
---
If your project is set up for it, you can reply to this
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/53
Sorry for additions to PR. I figured out a way to remove the last
inconsistencies with generics without breaking the API. This PR will not change
any more. I rebased my commits; you're welco
Github user twogee commented on the pull request:
https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286444
In asciidoc/tutorial/multiple.adoc, please replace Maven2 with Maven 2 for
consistency ð
---
If your project is set up for
Github user twogee commented on the pull request:
https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286714
In fact, there's a bunch of places where [Mm]aven2 is used...
[asciidoc-maven.zip](https://github.com/apache/ant-ivy/
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/53#discussion_r129660986
--- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
@@ -71,132 +71,139 @@
--- End diff --
It's a change fr
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/53#discussion_r129663139
--- Diff:
src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java
---
@@ -85,14 +85,12 @@ public LatestCompatibleConflictManager
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/53#discussion_r129668076
--- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
@@ -71,132 +71,139 @@
--- End diff --
Here's a "diff
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/53
This is strange, all tests still pass for me locally -- could someone
elucidate what the problem is, please?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/53
D'uh... getExtends() must respect insertion order -- array straitjacket
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/53
I'm sorry for not explaining the point with all the changes around foreach
loops: they take anything that is iterable rather than an array (which Ivy is
very fond of API-wise) and by doing so
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/55
use vectorised logo
I'd like to remove downloaded.gif, error.gif, evicted.gif and searched.gif
as well.
Maybe we could vote on colours for downloaded and evicted ð if green is
too da
Github user twogee commented on the pull request:
https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23334637
Perhaps `UnsupportedOperationException` would be a useful heuristic?
---
If your project is set up for it, you can reply to this
Github user twogee commented on the pull request:
https://github.com/apache/ant-ivy/commit/6607bdcb3ba69d2ab4f41be6292cc5a6df6365ba#commitcomment-23339716
In URLHandlerDispatcher,
```
@Override
public void download(final URL src, final File dest, final
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/53
With all due respect, there are some refactorings worth attention IMHO.
Besides, some deprecations need to be followed through ð
---
If your project is set up for it, you can reply to this email
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/56
use âMaven 2â consistently
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twogee/ant-ivy maven-2-in-asciidoc
Alternatively you can review
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/57
fix last inconsistencies in generics
... use collections, not arrays
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twogee/ant-ivy consistent
Github user twogee commented on the pull request:
https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23340291
Sorry for a terse suggestion, I meant we could provide more information to
the end user about the symlink/symlinkmass now that
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/57
The new method is taken from `AbstractOSGiResolver` where a corresponding
method is made public. All resolvers implement only the new method and the
fallback for the deprecated method is moved to
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/57
BTW, the old method is still there, the implementation is in the abstract
class, `AbstractResolver`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/57
The methods in `AbstractResolver` must be defined the other way around: the
default implementation of the method with new signature should call the method
with the old signature. May I amend the
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/57
The same applies to `ChainResolver` (which should check resolver type as
suggested by @jaikiran); actually, all custom resolvers that do not extend
`AbstractResolver` could be wrapped in chain
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/57
Is this sufficient, or should I add an extra check in `ChainResolver`
```
if (resolver instanceof AbstractResolver ||
hasGenericMethod(resolver
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/55
This fixes https://issues.apache.org/jira/browse/IVY-922
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1 - 100 of 248 matches
Mail list logo
