[Patch] FileUtils to use own close method

2004-12-13 Thread kj
-FileUtils now uses close to close inputstreams inside itself -added new private method to use java.nio memory mapped files for contentEquals method (this implementation doesn't care how large the files are, it simply tries to map the entire file, perhaps it would be better to check file size firs

Re: [Patch] FileUtils to use own close method

2004-12-14 Thread kj
On Mon, 2004-12-13 at 10:42 +0100, Stefan Bodewig wrote: > On Mon, 13 Dec 2004, kj <[EMAIL PROTECTED]> wrote: > > > -added new private method to use java.nio memory mapped files > > Ant is JDK 1.2 compatible, which means we can't use NIO for core > functionali

Re: [Patch] FileUtils to use own close method

2004-12-14 Thread kj
On Tue, 2004-12-14 at 10:40 +0100, Stefan Bodewig wrote: > That's why we have conditional compilations in Ant's build file - but > we can't compile a core service like FileUtils on JDK 1.4+ only. OK, thanks for explaining. Kev -

[Patch] Minor tweaks to ZipEntry and ZipOutputStream

2004-12-15 Thread kj
- changed format of for loops to remove method calls - removed other method calls - made access to ZipEntry.DEFLATED/STORED more explicit to stop compiler whining - changed one javadoc On large file sets the VM should work a little less (a few method calls/entry) -> minor performance improvement.

Re: [Patch] ChangeLogParser - hiding field

2004-12-17 Thread kj
On Fri, 2004-12-17 at 12:29 +0100, Stefan Bodewig wrote: > On Fri, 17 Dec 2004, Kev Jackson <[EMAIL PROTECTED]> wrote: > > > -class ChangeLogParser { > > +public class ChangeLogParser { > > why? why not? ;) No really, just habit - company standards where I've worked in past etc. Changing it can'

Re: [Patch] TaskLogger variable names + javadoc

2004-12-17 Thread kj
> > Index: JavaVersionTest.java > > === > > RCS file: JavaVersionTest.java > > I assume this went in by accident, correct? > Yes I noticed *after* I'd sent it - damn eclipse with it's automatic "insert new files" create patch option,

[Patch] Change to one of the MSVSS methods

2004-12-22 Thread kj
file: MSVSSTest.java diff -N MSVSSTest.java --- /dev/null 1 Jan 1970 00:00:00 - +++ MSVSSTest.java 1 Jan 1970 00:00:00 - @@ -0,0 +1,142 @@ +/* + * Created on Dec 22, 2004 + * + */ +package org.apache.tools.ant.taskdefs.optional.vss; + +import org.apache.tools.ant.Project; + +import junit.fra

[Patch] Added a basic MSVSSStatus task

2004-12-22 Thread kj
- not tested, no VSS to test against - incomplete, only supports -U and -R switches - change to MSVSSConstants Kev Index: MSVSSConstants.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSC