[GitHub] ant-ivyde pull request #7: Fix IVYDE-386

2018-02-28 Thread jonl-percsolutions-com
GitHub user jonl-percsolutions-com opened a pull request: https://github.com/apache/ant-ivyde/pull/7 Fix IVYDE-386 According to Eclipse documentation, IContributionItem can, in no way, be relied on to be a MenuManager and in Eclipse Oxygen, this code is causing an exception as

[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-02-28 Thread jonl-percsolutions-com
Github user jonl-percsolutions-com commented on the issue: https://github.com/apache/ant-ivyde/pull/7 I believe I did it correctly and it is now rebased. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-03-01 Thread jonl-percsolutions-com
Github user jonl-percsolutions-com commented on the issue: https://github.com/apache/ant-ivyde/pull/7 @jaikiran Your fix is much better. I did not understand enough about the code to see whether or not it was intentional for those to be MenuManager objects or not. I have updated to

[GitHub] ant-ivyde pull request #7: Fix IVYDE-386

2018-03-01 Thread jonl-percsolutions-com
Github user jonl-percsolutions-com closed the pull request at: https://github.com/apache/ant-ivyde/pull/7 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h