Re: Java 9 test failures

2018-01-23 Thread Jaikiran Pai
ile in detail to be sure. -Jaikiran On 22/01/18 10:21 AM, Stefan Bodewig wrote: On 2018-01-21, Gintautas Grigelionis wrote: I see three failures in ImageTest testSimpleScale (did not create largeimage.jpg) testSimpleScaleWithMapper (did not create largeimage-scaled.jpg) testOverwriteT

Re: [PATCH]

2018-01-24 Thread Jaikiran Pai
u are using and the exception stacktrace that you got) and attach the proposed patch there? -Jaikiran On 24/01/18 4:57 PM, Adam Retter wrote: If you previously used the Saxon XSLT Processor within you would get an error as the XSLT stylesheets provided with Ant do not work with Saxon, they in

Re: Cutting new releases?

2018-01-26 Thread Jaikiran Pai
extent that it can be used for the basic minimal functionality and then keep adding anything more that we want in this task in future releases. More details about this are in the other thread. [1] https://github.com/apache/ant/compare/

Re: Ant support for users who use JUnit5

2018-01-26 Thread Jaikiran Pai
sk. (Few other minor enhancements here and there and any user feedback reports) For those of you curious to see what the task usage is going to look like, here's an example[2] build file which shows its many usages. That file will be cleaned up a bit, before I send a PR for review/merge.

Re: Ant support for users who use JUnit5

2018-01-26 Thread Jaikiran Pai
One minor but important detail - this feature/task will only be available in the 1.10.x releases (whichever release we decide to include this in) and won't be available in 1.9.x releases of Ant. -Jaikiran On 27/01/18 8:40 AM, Jaikiran Pai wrote: Here's an update on where this

Re: Cutting new releases?

2018-01-26 Thread Jaikiran Pai
I just remembered - we probably have to investigate that image task test failure on Java 9 and see if its some setup issue or whether that task is genuinely broken against that runtime. I haven't yet found the time to dig deeper on that one. -Jaikiran On Friday, January 26, 2018, Stefan Bo

Re: ant-ivy git commit: IVY-1569 Avoid reflection warnings (or worse) in Java 9+

2018-02-04 Thread Jaikiran Pai
I think we should use java.specification.version system property instead which is the recommended one as per the JEP http://openjdk.java.net/jeps/223. We use this property in Ant too to determine the Java version. -Jaikiran - To u

Re: [VOTE] Release Ant 1.9.10 based on RC1

2018-02-04 Thread Jaikiran Pai
. Checked the presence of source files. All above tests done on Java 8 setup. -Jaikiran On 03/02/18 10:02 PM, Stefan Bodewig wrote: Hi all I've created a release candidate for 1.9.10: git tag: ANT_1_9_10_RC1 on commit: 528c94e tarballs: https://dist.apache.org/repos/dist/de

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz and installed locally. Setup ANT_HOME to this new version. - Ran some existing projects against this new version - Checked some documentation in the manual. Tested the projects using this version of Ant against both Java 8 and Java 9. -Jaikiran On 03/02/18

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-05 Thread Jaikiran Pai
I agree. -1. On a related note, I don't think we should be doing any of these commits especially when there's a RC out which we plan to release. IMO, only blocker issues need to be addressed when the RC is out. -Jaikiran On 06/02/18 1:41 AM, Stefan Bodewig wrote: Generate mani

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-06 Thread Jaikiran Pai
Just to be clear, my -1 was meant for both this commit as well as a subsequent commit where some specific jars have been tagged as JPMS modules. I think adding this automatic module names just for the sake of it isn't a good thing. -Jaikiran On 06/02/18 9:38 AM, Jaikiran Pai wrote: I

Re: github PR builds

2018-02-06 Thread Jaikiran Pai
ers, I'm talking about github users who belong to the apache organization. P.S: There are a few other keywords that the plugin recognizes and is documented at [1]. [1] https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin -Jaikiran On 06/02/18 4:59 PM, St

Re: github PR builds

2018-02-06 Thread Jaikiran Pai
So it looks like, although I did send a mail about this PR integration a while back[1], I did not include the details about this plugin which was used for the integration. Sorry about that. [1] https://www.mail-archive.com/dev@ant.apache.org/msg46284.html -Jaikiran On 06/02/18 5:12 PM

Re: Release Notes for 1.10.2 and 1.9.10

2018-02-06 Thread Jaikiran Pai
Maybe the new task is worth highlighting. But other than that I don't have anything specific. -Jaikiran On 06/02/18 11:18 PM, Stefan Bodewig wrote: Hi all as you can witness in https://svn.apache.org/viewvc/ant/site/ant/sources/antnews.xml?r1=1823368&r2=1823367&pathrev=18

Re: Ivy-2.5.0

2018-02-07 Thread Jaikiran Pai
and see if it solves the issue? -Jaikiran On 09/01/18 5:53 PM, Maarten Coene wrote: The change to the URLHandler class (TimoutConstraint) is also backwards incompatible.The IvyIdea plugin (IntelliJ) breaks on this which contains an extension of AbstractURLHandler. I didn't look into i

Re: Ivy-2.5.0

2018-02-08 Thread Jaikiran Pai
release. We have a good amount of bug fixes that have been done since 2.4.0 and I think we should start looking at what it takes to do the release formalities. -Jaikiran On 09/01/18 12:29 PM, Jaikiran Pai wrote: Hi Jan, My efforts to resolve IVY-1485 have taken longer than I expected, mainly

Re: github PR builds

2018-02-08 Thread Jaikiran Pai
On 06/02/18 10:10 PM, Stefan Bodewig wrote: On 2018-02-06, Jaikiran Pai wrote: The PR build on Jenkins is backed by the github PR integration plugin[1]. One of the features of that plugin is to prevent some malicious/rogue PR (imagine someone creating a PR with code which does some odd things

Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
https://bz.apache.org/bugzilla/show_bug.cgi?id=39960 [6] https://builds.apache.org/job/Ant-Build-Matrix-1.9.x-Linux/OS=xenial,jdk=JDK%201.5%20(latest)/lastCompletedBuild/testReport/src.tests.antunit.taskdefs/copy-test_xml/testResourceWithoutName/ -Jai

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
On 09/02/18 2:47 PM, Dominique Devienne wrote: On Fri, Feb 9, 2018 at 10:06 AM, Jaikiran Pai wrote: I need some inputs on how we should go about this specific change/test? Should this test continue to expect a exception or is it fine to expect that target to complete cleanly (without copying

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
Sure Stefan. -Jaikiran On 09/02/18 11:00 PM, Stefan Bodewig wrote: Jaikiran, just to avoid duplicate work, I'm currently running tests on the 1.9.x branch where I fix a bunch a FileNameMapper implementations that wouldn't handle null sourceFileNames (which could happen for reso

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
Thanks everyone for the inputs. Based on those, I have now updated the test to not expect a build failure exception and also have updated our release notes to mention this change in behaviour. -Jaikiran On 09/02/18 11:00 PM, Stefan Bodewig wrote: Jaikiran, just to avoid duplicate work, I&#

Include user mailing list for RC release?

2018-02-09 Thread Jaikiran Pai
t the RC, so that issues like these can hopefully be caught before we actually do a release. [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=62086 -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For addit

Re: Need a Second Pair of Eyes

2018-02-13 Thread Jaikiran Pai
indeed introduces a different behaviour. [1] https://github.com/jaikiran/ant/commit/f57b9d5fbca6e9648695bc9d37a27000c0b4aff2#diff-585ed59cf64ef6930e5148094adc322aR21 -Jaikiran On 13/02/18 11:20 PM, Stefan Bodewig wrote: Hi all I'm currently reviewing the big change that introduce

Re: Need a Second Pair of Eyes

2018-02-13 Thread Jaikiran Pai
I forgot to add that, as you note, as a result of the change, the new created path will retain all elements from destPath that aren't in dependClassPath, which is unlike the behaviour before the change. -Jaikiran On 14/02/18 9:59 AM, Jaikiran Pai wrote: Hi Stefan, You are right. The c

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
his loaded content is only held on for a short while in memory, during the report writing and will be immediately garbage collected once that's done. Please review the PR - mostly the Ant specific constructs and implementation details. [1] https://github.com/apache/ant/pull/60 [2] https://

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
regressions that we have found in our latest releases. -Jaikiran On 15/02/18 7:21 PM, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found h

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
I just realized that the manual that I linked in my mail isn't accessible to everyone. So here's an alternative link to the same https://home.apache.org/~jaikiran/temp_workspace/manual/Tasks/junitlauncher.html -Jaikiran On 15/02/18 7:21 PM, Jaikiran Pai wrote: I'm now done w

Re: Ant support for users who use JUnit5

2018-02-17 Thread Jaikiran Pai
On 17/02/18 12:51 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would suggest rea

Re: New Release(s)?

2018-02-18 Thread Jaikiran Pai
I am in favour of both a 1.10.3 and 1.9.11 release. -Jaikiran On 18/02/18 3:07 PM, Stefan Bodewig wrote: Hi all https://bz.apache.org/bugzilla/show_bug.cgi?id=62086 is a serious regression in 1.10.2 and it has been fixed in master by now. The 1.9.x branch has never been affected. By now I

Ivy release this month?

2018-02-18 Thread Jaikiran Pai
There are few PRs open, but except for this one https://github.com/apache/ant-ivy/pull/62 I don't plan to merge the rest given the nature of the changes. There's no release instructions that I could find, so I am not sure what's going to be involved in the actual release

Re: Ant support for users who use JUnit5

2018-02-18 Thread Jaikiran Pai
On 19/02/18 1:37 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would suggest rea

Re: Ant support for users who use JUnit5

2018-02-23 Thread Jaikiran Pai
On 19/02/18 9:23 AM, Jaikiran Pai wrote: On 19/02/18 1:37 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: We have 3 pre-defined formatters all of which are capable of receiving this streamed sysout/syserr data. Each of these do _not_ hold on to this sysout/syserr data in-memory

Ivy release instructions

2018-02-27 Thread Jaikiran Pai
initiate these steps (and ask for specific help as I go along) for an intermediate release. Once this goes well, we can then have any of us do the final release (which should be much smoother). -Jaikiran - To unsubscr

Re: Ivy release this month?

2018-02-27 Thread Jaikiran Pai
e here and why, it's difficult to say whatelse it might impact.     - It also brings in additional deps and again comes back to the original question about what use case we are trying to support. IMO, this is something that we can a

Re: ant-ivy git commit: initial WIP version of release instructions to follow for releasing Ivy

2018-02-27 Thread Jaikiran Pai
No I hadn’t :) Will check it out tonight. -Jaikiran On Tuesday, February 27, 2018, Jan Matèrne (jhm) wrote: > Have you seen doc/dev/makerelease.html ? > But updating (and maybe automating) is a good idea. ;) > > Jan > > > -Ursprüngliche Nachricht- > &g

Re: Ant 1.9.10 and Ivy

2018-02-27 Thread Jaikiran Pai
I'll grep through the sources and revert all changes to clone signatures unless anybody else beats me to it. Done https://github.com/apache/ant/commit/2e788849136bfd75e88ce0d959810f1191d43a33 -Jaikiran - To unsubscri

Re: ant-ivy git commit: initial WIP version of release instructions to follow for releasing Ivy

2018-02-28 Thread Jaikiran Pai
I read through it and (obviously) it covers the necessary details. So my new doc that I committed isn't needed. As for automating/changing things in that doc, I think it's something one of us can do once we try out that doc for this release. -Jaikiran On 27/02/18 8:12 PM, Ja

Re: Ant test failures on Java 9

2018-02-28 Thread Jaikiran Pai
l time: 25 seconds -Jaikiran On 01/03/18 1:05 PM, Gintautas Grigelionis wrote: I see following in my builds against master Build File: .../src/tests/antunit/taskdefs/copy-test.xml Tests run: 26, Failures: 0, Errors: 2, Time elapsed: 8,59 sec ... Target: test-with-some-resources-mapped-away

Ant nightly Jenkins job

2018-03-01 Thread Jaikiran Pai
Would it be OK if I redo the Ant nightly jenkins job[1] to be a bit more useful and publish an actual nightly binary, for users to try out if they wish to? [1] https://builds.apache.org/job/Ant_Nightly/ -Jaikiran - To

Ivy old docs removed - documentation now resides under asciidoc

2018-03-07 Thread Jaikiran Pai
ory of the repo, is the place where documentation for the project resides. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

User implementations of custom interfaces can have access to Task instance?

2018-03-12 Thread Jaikiran Pai
ations of the interface have access to this, then I will just go ahead and expose it without worrying about it. P.S: I realize in fork mode, the Task instance won't be available and I'll be taking that into account, but this question is more a ge

Re: User implementations of custom interfaces can have access to Task instance?

2018-03-17 Thread Jaikiran Pai
lugged in something like: classname="some.custom.class.implementing.an.task.specific.interface"/> plus the fact that this custom class can reside in a classloader defined by nested elements of this task. -Jaikiran On 13/03/18 3:36 PM, Stefan Bodewig wrote: On 2018-03-13, Jaikiran P

Re: When is Ant 1.10.3 release expected?

2018-03-17 Thread Jaikiran Pai
I (finally) merged the JUnit 5 work to master. Rest of the fork related work for this task is something that I don't plan to make available in this release (the work is going to take some time). So I guess, we can make a new release. -Jaikiran On 12/03/18 4:53 PM, Stefan Bodewig wrote

Re: AW: Ant nightly Jenkins job

2018-03-17 Thread Jaikiran Pai
This is now done. The Ant_Nightly job now generates the Ant distribution which can be used for testing the bug fixes/features that go into the "master" branch. The distribution is available at https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ -Jai

Snapshot access to regular users of Ant

2018-03-17 Thread Jaikiran Pai
e? After reading that policy, I'm starting to wonder if the Jenkins job should even publish these snapshots. [1] http://www.apache.org/legal/release-policy.html#publication -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...

Re: ant git commit: Add dependency description

2018-03-17 Thread Jaikiran Pai
ch I'll add now. -Jaikiran On 17/03/18 7:22 PM, gin...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master 50b9be737 -> a312b6728 Add dependency description Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: http://git-wip-us.apache.org/repos/asf/a

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Jaikiran Pai
ed to some other mails due to limited internet connectivity this few days. I'll respond to them soon. -Jaikiran On 20/03/18 8:57 PM, Stefan Bodewig wrote: Hi I've just added a POM for ant-junitlauncher and it currently fails to build as org.apache.tools.ant.taskdefs.optional.junitlaun

Re: [VOTE] Release Ant 1.10.3 based on RC1

2018-03-23 Thread Jaikiran Pai
ithub.com/apache/ant/commit/12c975888a762f0f901391a1bf27703360d179d0 -Jaikiran On 24/03/18 1:07 AM, Stefan Bodewig wrote: Hi all I've created a release candidate for 1.10.3: git tag: ANT_1.10.3_RC1 on commit: d00658c tarballs: https://dist.apache.org/repos/dist/dev/ant/

Re: [VOTE] Release Ant 1.9.11 based on RC1

2018-03-23 Thread Jaikiran Pai
to the binary distribution's layout to upstream[1], but I don't thinkthat's a big enough change to warrant another RCfor this release. [1] https://github.com/apache/ant/commit/a3b065b967b87641dc0e5a154a44002395f656c8 -Jaikiran On 23/03/18 11:03 PM, Stefan Bodewig wrote: correc

Re: ant git commit: Add dependency description

2018-03-24 Thread Jaikiran Pai
ars) within the classpath element of the junitlauncher task. I had attempted this in the very first version of this task, but ran into certain classloader issues which I did not time to investigate, so decided to push it out for now. [1] http://ant.apache.org/faq.html#delegating-classloader -Jaiki

Re: junitlauncher doc fix (was Re: [VOTE] Release Ant 1.10.3 based on RC1)

2018-03-24 Thread Jaikiran Pai
On 24/03/18 1:03 PM, Stefan Bodewig wrote: On 2018-03-24, Jaikiran Pai wrote: I'm not sure if for the documentation fix (which I have pushed upstream) we need to redo a new RC release. If I understand your change correctly then the manual as would be released with 1.10.3 is plain wron

Re: [VOTE] Release Ant 1.10.3 based on RC2

2018-03-25 Thread Jaikiran Pai
+1. Verified that the changes in the junitlauncher task documentation are present. Also ran some local projects with this new 1.10.3 tar.gz and all was fine. -Jaikiran On 24/03/18 6:18 PM, Stefan Bodewig wrote: Hi all I've created a new release candidate for 1.10.3 incorporating th

Re: [ANN] Apache Ant 1.9.11 and 1.10.3 Released

2018-03-27 Thread Jaikiran Pai
Stefan, thank you for running these releases. -Jaikiran On 28/03/18 10:52 AM, Stefan Bodewig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The Apache Ant Team is pleased to announce the releases of Apache Ant 1.9.11 and 1.10.3. Apache Ant is a Java library and command-line tool that

Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-06 Thread Jaikiran Pai
ed required or accepted. Could we please reconsider whether or not we should be doing such changes? -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: Ivy release

2018-04-09 Thread Jaikiran Pai
+1. Thanks Nicolas. -Jaikiran On Monday, April 9, 2018, Nicolas Lalevée wrote: > The last thread about a release has been stuck in the discussion about which PR, patch or Jira needed to be tackled before releasing. I suggest we just move forward with the current master. I volunteer to buil

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-10 Thread Jaikiran Pai
. Considering the commits that have been made (even just considering only the Ant ones), I don't see how those relate to some plan to refactor JUnit tests. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.

Re: [VOTE] Ivy 2.5.0-rc1 Release

2018-04-12 Thread Jaikiran Pai
bug fixes for some random fixes that were part of this release (IVY-1540 and IVY-1577). Worked fine. - Built some internal projects using the downloaded version of Ivy, using Java 9. All went fine. -Jaikiran On 12/04/18 9:59 PM, Nicolas Lalevée wrote: I have built a release candidate for

Re: ant git commit: More isEmpty()

2018-04-13 Thread Jaikiran Pai
NullPointerException, which most likely will be the case in a lot of places other than those that just set the incoming value to some member variable. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

JUnit 5 tests incorrectly picked up during Ant junit tests

2018-04-15 Thread Jaikiran Pai
It indeed looks like a build exclusion that I might have missed. I will take a look at this and fix it. -Jaikiran On 15/04/18 9:35 PM, Stefan Bodewig wrote: On 2018-04-15, Gintautas Grigelionis wrote: By the looks of it, JUnit 5 runner tests need an assumption check, too. Not sure why

Include ANT_HOME location in "ant -version" ?

2018-04-19 Thread Jaikiran Pai
nted from. Any thoughts? [1] https://www.mail-archive.com/user@ant.apache.org/msg42757.html -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: Ant JUnit tests

2018-04-19 Thread Jaikiran Pai
DE, by adding those assumptions? -Jaikiran On 20/04/18 10:39 AM, Gintautas Grigelionis wrote: I am refactoring Ant JUnit tests with a goal to make them more "IDE-friendly". I found several tests that are implictly dependent on ant.home property being set. In these cases, the

Re: [Announce] Release of Apache Ivy 2.5.0-rc1

2018-04-22 Thread Jaikiran Pai
Thank you Nicolas for running this release. -Jaikiran On 22/04/18 11:24 PM, Nicolas Lalevée wrote: The Apache Ivy project is pleased to announce its 2.5.0-rc1 release. Apache Ivy is a tool for managing (recording, tracking, resolving and reporting) project dependencies, characterized by

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Jaikiran Pai
What purpose is this change serving? -Jaikiran On 30/04/18 10:08 AM, gin...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master 0add85310 -> f3dfb7779 Inline buildfile names, make search easier Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: http://

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Jaikiran Pai
o these commits anymore and just stay away from them and stop sending this frustrated and rude sounding mails. -Jaikiran The point is that these names are used exactly once, and need not to be put in a field which is named inconsistently. Deviations from this rule of thumb indicate that tests ar

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Jaikiran Pai
rtain thing can be implemented. I hope you do realize that what we are discussing in this thread (and others) is much more broader than finding copy/paste errors due to usage of one API over other. -Jaikiran - To unsubscri

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Jaikiran Pai
that espoused TMTOWDI has moved to TIMTOWTDIBSCINABTE? Sorry, I really don't know what that means or how that relates to what we are discussing. -Jaikiran Gintas 2018-04-30 5:56 GMT+00:00 Jaikiran Pai : On 30/04/18 11:12 AM, Gintautas Grigelionis wrote: Names of buildfiles used in tests can be fo

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later tonight. -Jaikiran On 12/05/18 4:45 PM, Simon IJskes wrote: Hi, Just checking if this bug is known? I could not find it in bugzilla. https://issues.apache.org/jira/browse/NETBEANS-781 Groeten, Simon

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb [2] https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ -Jaikiran On 12/05/18 5:30 PM, Jaikiran Pai wrote: Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
should be available here[2]. [1] https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb [2] https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ it works! Glad to hear that :) -Jaikiran

Re: [GitHub] ant pull request #:

2018-05-12 Thread Jaikiran Pai
27;s going on. -Jaikiran On 12/05/18 9:19 PM, twogee wrote: Github user twogee commented on the pull request: https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469 In src/main/org/apache/tools/ant/taskdefs/optional/depend/co

Re: [GitHub] ant pull request #:

2018-05-13 Thread Jaikiran Pai
No problem. That change to WHATSNEW is fine, I don't mind. -Jaikiran On 13/05/18 1:03 PM, Gintautas Grigelionis wrote: Thanks, great work! I hope you don't mind me taking the liberty to adjust WHATSNEW. Gintas 2018-05-13 6:01 GMT+02:00 Jaikiran Pai : I did plan to addit yesterd

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-16 Thread Jaikiran Pai
I agree. Especially when it's being done on something like for archive entries which can betoo many depending on the archive that is being dealt with. -Jaikiran On 17/05/18 12:04 PM, Maarten Coene wrote: Converting an Enumeration to a List just for iterating it doesn't seem perfo

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Jaikiran Pai
nvert it into some other form (thus additional code plus additional objects allocated in the process), all this to iterate over it and run some logic on it - all of which was already possible with the enumeration that was already available. -Jaikiran On 18/05/18 12:22 AM, Gintautas Grigel

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Jaikiran Pai
/github.com/apache/ant/commit/070c3bc86f85e8f01cb624fe50ae82f0d11171b2#diff-21eb59eaf9f2b5d0b487aeb5e5022ccdL888 [5] https://github.com/apache/ant/commit/070c3bc86f85e8f01cb624fe50ae82f0d11171b2#diff-21eb59eaf9f2b5d0b487aeb5e5022ccdL1359 [6] https://github.com/apache/ant/commit/070c3bc86f85e8f01cb624fe50ae82f0d11171b2#di

Re: ClassLoaders in JUnit Launcher Task

2018-06-01 Thread Jaikiran Pai
his task for a bit, I haven't been able to come up with a solution. I'll look more into this in the upcoming days and see how we can improve this. If I misunderstood your use case, please do let us know. [1] https://ant.apache.org/ma

Re: ClassLoaders in JUnit Launcher Task

2018-06-03 Thread Jaikiran Pai
so feel free to reply with details if there's something else you are looking for. [1] https://raw.githubusercontent.com/apache/ant/master/manual/Tasks/junitlauncher.html -Jaikiran On 02/06/18 8:39 AM, Jaikiran Pai wrote: HelloLucas, On 01/06/18 10:46 PM, Lucas Bullen wrote: However

Re: ClassLoaders in JUnit Launcher Task

2018-06-03 Thread Jaikiran Pai
On 03/06/18 3:13 PM, Jaikiran Pai wrote: I have now added a section in the junitlauncher task's manual The section's titled "Using the classpath element to include test engines". -Jaikiran to include an example which shows how to setup the classpath element to include

Re: InputHandler and end-of-stream

2018-06-03 Thread Jaikiran Pai
like an empty input and maybe fall back to the default value? Given that the null return value happens when the stream, from which we are reading, has ended earlier than expected, IMO we should consider it an error case and throw a more legible exception

Re: AntUnit Bug Causing Jenkins Failures

2018-06-04 Thread Jaikiran Pai
Sounds fine to me. -Jaikiran On 04/06/18 1:08 PM, Stefan Bodewig wrote: Hi all one of the recurring issues that make Jenkins builds fail is a thread-safety bug in AntUnit's log capturing code. This is supposed to be fixed in AntUnit's master branch. I propose to build an alpha

Re: Bz 62324

2018-06-09 Thread Jaikiran Pai
Earlier, before this commit, it used to print just the stacktrace. I don't see how this change would solve what's being discussed in that bugzilla. If this isn't the proposed solution, is there some other place I can read up on

Re: Bz 62324

2018-06-09 Thread Jaikiran Pai
On 09/06/18 5:22 PM, Gintautas Grigelionis wrote: Thanks for review, Jaikiran. You're correct, that is the proposed solution, adding a separator (a newline followed by an exception name for clarity -- mind that exception is logged only in debug mode). The exception class name would alrea

Proposing Apache IvyDE release

2018-06-13 Thread Jaikiran Pai
am planning to call this release 2.3.0-rc1. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-13 Thread Jaikiran Pai
o you vote for the release of these binaries? -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-13 Thread Jaikiran Pai
Gintas, When and where do you see these messages? What activity triggers it? -Jaikiran On 14/06/18 12:36 AM, Gintautas Grigelionis wrote: I am testing on Oxygen 3.A and seeing errors like org.xml.sax.SAXParseException; systemId: http://ant.apache.org/ivy/ivyde/updatesite/p2-mirrors--xml.cgi

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-13 Thread Jaikiran Pai
Sure, i'll do that today. -Jaikiran On Thursday, June 14, 2018, Stefan Bodewig wrote: > [As usual I'll only be able to review the legal stuff but probably won't > find time to do so before tomorrow or even Saturday (am currently > traveling).] > > On 2018-06-13, Ja

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-14 Thread Jaikiran Pai
On 14/06/18 11:50 AM, Stefan Bodewig wrote: On 2018-06-13, Jaikiran Pai wrote: You can download the distribution from this URL: https://dist.apache.org/repos/dist/dev/ant/ivyde/2.3.0-rc1 Be the releas policy that is in place now SHA1 is deprecated, MD5 is frowned upon and at least SHA256 is

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-15 Thread Jaikiran Pai
dependency in a simple Java class. - Checked some Ivy plugin settings page to make sure they look and work fine. -Jaikiran On 13/06/18 9:18 PM, Jaikiran Pai wrote: I have built a release candidate 2.3.0-rc1 for Apache IvyDE. The tag is here: https://git1-us-west.apache.org/repos/asf?p=ant

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-15 Thread Jaikiran Pai
I tried reproducing this issue but haven't been able to. Either way, given the nature of this issue, I personally don't consider it a blocker for this release vote to pass. Please do file a JIRA with the relevant details if this is reproducible. -Jaikiran On 14/06/18 12:53 AM,

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
Thanks Stefan, I'll fix these issues and send out a new voting mail. -Jaikiran On Saturday, June 16, 2018, Stefan Bodewig wrote: > Hi > > please add your PGP key to dist.apache.org/release/ant/KEYS > > * checksums and signatures are good > * for the files in updatesite

[CANCEL] [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
Given some of the valid issues that Stefan has raised with this released instance, I'm cancelling this vote. This is a first release after a long time and I plan to have this as clean as possible. I will send out a new vote mail once I sort out these issues. -Jaikiran On 16/06/18 6:

[VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
orkspace * NEW: Support for storing credentials securely Do you vote for the release of these binaries? -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
I pushed a bunch of commits to address these issues and have now released newer binaries for 2.3.0-rc1 release and initiated a separate VOTE mail for it. -Jaikiran On 16/06/18 6:48 PM, Stefan Bodewig wrote: Hi please add your PGP key to dist.apache.org/release/ant/KEYS * checksums and

Re: thinking about new releases

2018-06-16 Thread Jaikiran Pai
+1. I don't have anything in a state that I can push to either of these branches, in the immediate future. -Jaikiran On 16/06/18 9:38 PM, Stefan Bodewig wrote: Hi all given https://dev.snyk.io/research/zip-slip-vulnerability lists Ant 1.9.12 as a release fixing a security problem it

Re: svn commit: r27516 - /release/ant/KEYS

2018-06-17 Thread Jaikiran Pai
Thank you Stefan, I forgot to add it to this location and added only in the git repo. -Jaikiran On 17/06/18 2:00 PM, bode...@apache.org wrote: Author: bodewig Date: Sun Jun 17 08:30:47 2018 New Revision: 27516 Log: Add Jaikiran's key Modified: release/ant/KEYS Modified: releas

Re: thinking about new releases

2018-06-18 Thread Jaikiran Pai
I am willing to test and vote on an AntUnit release. -Jaikiran On 18/06/18 12:45 PM, Stefan Bodewig wrote: OK, then I'll revert the antunit change so the source release ships with a released version of it and prepare release candidates sometime the coming days. The alternative would

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
+1. Tried the installation and used a basic Ivy based project for dependency resolution. Also checked some of the Ivy plugin screens to make sure all is fine. -Jaikiran On 17/06/18 12:15 PM, Jaikiran Pai wrote: This is a newer vote mail that I'm initiating for the 2.3.0-rc1 relea

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
Thanks for testing this Nicolas. This indeed is a big enough issue to be considered a blocker. I'll take a look at this. I'll also include the sha and rev in a newer vote and update our release instructions. -Jaikiran On Tuesday, June 19, 2018, Nicolas Lalevée wrote: > First, t

[CANCEL] [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
Given the nature of this issue, I'm cancelling this vote. A new one will be initiated this week. -Jaikiran On 19/06/18 5:05 AM, Jaikiran Pai wrote: Thanks for testing this Nicolas. This indeed is a big enough issue to be considered a blocker. I'll take a look at this. I'll a

Re: [VOTE] Release AntUnit 1.4 Based on RC1

2018-06-19 Thread Jaikiran Pai
he index.html repo link typo to be a blocker. I don't know if the copyright year issue should warrant a new vote. If it doesn't, then it's a +1 for this release from me. -Jaikiran On 19/06/18 1:27 AM, Stefan Bodewig wrote: On 2018-06-18, Stefan Bodewig wrote: Hi all there

Re: .git(modules|attributes|ignore) files in source dists?

2018-06-19 Thread Jaikiran Pai
tate anything about files like .gitignore being packaged into the archive. So I looked into the generated source tar and those are indeed present. I actually can't think of a reason why we should exclude these files. [1] https://github.com/apache/ant-ivyde/blob/master/build.xml -Jaiki

<    2   3   4   5   6   7   8   >