[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396320 --- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java --- @@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396341 --- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java --- @@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396424 --- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java --- @@ -306,7 +306,7 @@ public boolean isClosedRange() { return

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127397389 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127397658 --- Diff: src/java/org/apache/ivy/plugins/repository/ssh/SshCache.java --- @@ -263,9 +263,8 @@ public void clearSession(Session session

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127398451 --- Diff: src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java --- @@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127398802 --- Diff: src/java/org/apache/ivy/util/url/HttpClientHandler.java --- @@ -177,7 +177,7 @@ public URLInfo getURLInfo(URL url, int timeout

[GitHub] ant-ivy issue #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/52 I've reviewed this PR and apart from the review comments noted, the rest of the changes look fine. Please only include any review comments related changes to this PR, from now on. Else it&#x

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127475255 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination

[GitHub] ant-ivy issue #52: Generics in core

2017-07-17 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/52 It looks like this PR has been updated with additional unrelated changes. Except for these 2 commits in this PR: https://github.com/apache/ant-ivy/pull/52/commits

[GitHub] ant-ivy pull request #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/54 IVY-735 Support timeouts on resolvers The commit in this PR adds support for specifying connection and read timeouts for resolvers, so that users have control over how the resolvers behave when

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 >> The PR contains additional changes to HttpClientHandler, introducing HttpConnectionManagerParams, which is not available in Commons HTTP Client version 2 (over 10 years old and virtuall

[GitHub] ant pull request #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

2017-07-22 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/35 [1.9.x branch] Fix for BZ-43271 BZ-59648 The commit here fixes the issue reported in: https://bz.apache.org/bugzilla/show_bug.cgi?id=43271#c6 https://bz.apache.org/bugzilla/show_bug.cgi?id

[GitHub] ant pull request #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

2017-07-22 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant issue #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

2017-07-22 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/35 All done - applied this commit to 1.9.x branch and then merged to master branch. The pushed commit also includes updates to the WHATSNEW and contributor files. --- If your project is set up for it

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-22 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 Gintas, thanks for pointing me to that code. I now understand what you meant. So essentially, Ivy internally tries to support both 2.x and 3.x version of HTTP client library at runtime

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-23 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 >> VsftpRepository has DEFAULT_READ_TIMEOUT and DISCONNECT_COMMAND_TIMEOUT; would that require an additional timeout attribute? I had a look at this. Given that there's currentl

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-23 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 >> So it's not going to work out supporting 2.x version since we will end up using 3.x APIs at compile time. But that's a different topic altogether and something that I will

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-25 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Hi Gintas, Given the amount of commits and the changes involved in this PR, it's a bit difficult to review it. I think this PR even includes some of the changes that have already

[GitHub] ant-ivy pull request #:

2017-07-25 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286798 Sure, I'll do a find/replace in one of my upcoming doc fixes commit. --- If your project is set up for it, you can rep

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129593699 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- This file has a large

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129587968 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public LatestCompatibleConflictManager

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Commit https://github.com/apache/ant-ivy/pull/53/commits/432c42ad1ee54ab08ea8b8808086ba19d4880737 in this PR has now been merged upstream https://github.com/apache/ant-ivy/commit

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129757849 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public LatestCompatibleConflictManager

[GitHub] ant-ivy pull request #:

2017-07-27 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23334838 Do you mean for the `symlinkmass` deprecation? In this release, I just wanted it to be deprecated with a log message showing up

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-27 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Commit https://github.com/apache/ant-ivy/pull/53/commits/414651c8841a09a9d9d4b0365ee8e7227fba8429 in this PR has now been merged to upstream https://github.com/apache/ant-ivy/commit

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/57 Overall, this looks fine to me. I just need some inputs from the rest of the team on one specific change, for which I have raised a dev list thread https://www.mail-archive.com/dev@ant.apache.org

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-08-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/57 Hi Gintas, To be clear - what I meant/proposed in the dev list was: - It's fine to have all the changes related to introducing that new method with Java generics o

[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files

2017-08-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/59 Thank you for the PR and sorry it took a while to merge this. I have included the change you suggested in this PR with a minor change and merged it upstream. --- If your project is set up for it

[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files

2017-08-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/59 >> thanks @jaikiran do you have an Estimated Time for next release containing this bugfix? @apupier - the plan is to have it soon (no specific date yet). We are almost at the la

[GitHub] ant-ivy issue #53: suppressed warnings

2017-08-31 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Thanks! This is now merged to upstream. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-31 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/60#discussion_r136327295 --- Diff: build-release.xml --- @@ -179,11 +180,11 @@ - + --- End diff

[GitHub] ant pull request #37: [1.9.x branch] BZ-60644 Fix file corruption during cop...

2017-09-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/37 [1.9.x branch] BZ-60644 Fix file corruption during copy task The commit here includes a fix for the issue reported in https://bz.apache.org/bugzilla/show_bug.cgi?id=60644. As described in that issue

[GitHub] ant pull request #38: Do not merge

2017-09-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/38 Do not merge Testing Jenkins integration. Do not merge this PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant dummy Alternatively

[GitHub] ant pull request #38: Do not merge

2017-09-17 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/38 Do not merge Testing Jenkins integration. Do not merge this PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant dummy Alternatively

[GitHub] ant pull request #38: Do not merge

2017-09-17 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/38 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #38: Do not merge

2017-09-17 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/38 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #39: [1.9.x branch] BZ-58589 Preserve last modified time (i...

2017-09-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/39 [1.9.x branch] BZ-58589 Preserve last modified time (if asked for) for files uploaded by SFTP The commit here adds support for preserving the last modified time on files when uploaded via SFTP, as

[GitHub] ant issue #39: [1.9.x branch] BZ-58589 Preserve last modified time (if asked...

2017-09-17 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/39 Ignore the Jenkins job message please - I haven't yet got it configured correctly. --- - To unsubscribe, e-mail: dev-uns

[GitHub] ant issue #39: [1.9.x branch] BZ-58589 Preserve last modified time (if asked...

2017-09-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/39 Merged to both 1.9.x and master branches. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e

[GitHub] ant pull request #37: [1.9.x branch] BZ-60644 Fix file corruption during cop...

2017-09-28 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/37#discussion_r141594830 --- Diff: src/main/org/apache/tools/ant/util/ResourceUtils.java --- @@ -666,6 +666,14 @@ private static void copyWithFilterSets(final Resource source, final

[GitHub] ant issue #37: [1.9.x branch] BZ-60644 Fix file corruption during copy task

2017-09-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/37 Tests against various JDK versions against Windows and Linux went fine without any regressions. Will go ahead and merge this now

[GitHub] ant pull request #48: BZ-61718 Upgrade to 0.1.54 of Jsch library

2017-11-04 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/48 BZ-61718 Upgrade to 0.1.54 of Jsch library The commit here upgrades Jsch library dependency to `0.1.54` (which is the latest released version) as requested in https://bz.apache.org/bugzilla

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-08 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/49 [master branch] - Fix BZ-58683 The commit here fixes the issue reported at https://bz.apache.org/bugzilla/show_bug.cgi?id=58683. This commit along with fixing the issue reported in that bug

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941076 --- Diff: WHATSNEW --- @@ -27,6 +27,11 @@ Fixed bugs: copy happened to be the same source file (symlinked back to itself

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941080 --- Diff: manual/Tasks/symlink.html --- @@ -26,7 +26,7 @@ Symlink Description - Manages symbolic links on Unix based platforms. Can be used

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941095 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java --- @@ -207,26 +198,30 @@ public void recreate() throws BuildException

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941101 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java --- @@ -448,49 +432,67 @@ private void handleError(String msg

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941155 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java --- @@ -500,18 +502,12 @@ private void doLink(String res, String lnk) throws

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941213 --- Diff: src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java --- @@ -30,6 +30,8 @@ * a symbolic link based on the absent support for them in Java

[GitHub] ant issue #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/49 >> Overall I'm in favor of this change and if you want to spend the time on fixing the bugzilla issue in a Java5 friendly way for 1.9.x that would certainly be good - bit not something I&

[GitHub] ant issue #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/49 Committed to master branch https://github.com/apache/ant/commit/cefdbd398d8e310b218f9e2ca6f0b7fb13eddbb9 --- - To unsubscribe, e

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

2017-12-10 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/49 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/51 [master] Changes for BZ-19516 As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying `InputStream

[GitHub] ant pull request #38: Do not merge

2017-12-12 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/38 Do not merge Testing Jenkins integration. Do not merge this PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant dummy Alternatively

[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/51 [master] Changes for BZ-19516 As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying

[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/51 [master] Changes for BZ-19516 As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying

[GitHub] ant pull request #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #38: Do not merge

2017-12-12 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/38 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #51: [master] Changes for BZ-19516

2017-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 >> an alternative would be to only wrap the stream inside of zipFile if mark wasn't supported. @bodewig, I actually liked your idea. So I did an additional change in this commit (

[GitHub] ant issue #51: [master] Changes for BZ-19516

2017-12-13 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 Thanks for reviewing. Merged to master branch. Will backport it to 1.9.x too. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] ant pull request #52: [master] Fix BZ-58451 BZ-58833

2017-12-16 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/52 [master] Fix BZ-58451 BZ-58833 The commit here fixes the issues reported in: https://bz.apache.org/bugzilla/show_bug.cgi?id=58833 https://bz.apache.org/bugzilla/show_bug.cgi?id=58451

[GitHub] ant issue #52: [master] Fix BZ-58451 BZ-58833

2017-12-16 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/52 Have updated the PR to fix the test case so that it runs the correct command on Windows, during the tests. --- - To unsubscribe, e

[GitHub] ant issue #52: [master] Fix BZ-58451 BZ-58833

2017-12-20 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/52 @bodewig, do you think this change is OK? Any thoughts/concerns? I understand that this is one of the central classes, so don't want to push this if there's any concerns with t

[GitHub] ant issue #52: [master] Fix BZ-58451 BZ-58833

2018-01-03 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/52 Thanks Stefan (@bodewig) for the review. The tests (existing and a new one in this PR) are passing on both *nix and Windows. Given that this change does address the issues noted in the referenced

[GitHub] ant issue #52: [master] Fix BZ-58451 BZ-58833

2018-01-03 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/52 This is now commit to both master and 1.9.x branches https://github.com/apache/ant/commit/6c860e0036a8742f4cc35e3e6a8e595e42804c89

[GitHub] ant pull request #52: [master] Fix BZ-58451 BZ-58833

2018-01-03 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/52 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #55: Use valueOf method instead of constructor since valueOf has h...

2018-01-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/55 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...

2018-02-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/56 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-04 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/57 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-05 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166183611 --- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java --- @@ -102,7 +102,7 @@ private static final String DEFAULT_MIME_TYPE = "text/

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-05 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166183671 --- Diff: src/main/org/apache/tools/ant/taskdefs/Parallel.java --- @@ -377,7 +377,7 @@ public synchronized void run() { } // now

[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...

2018-02-05 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/58 Overall, IMO, this can't be a general find/replace change and instead needs to be checked for individuals places where the `StringBuffer` is used and whether the change to `StringBuilder` will i

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-05 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/57 @adamretter The test failure https://builds.apache.org/job/Ant%20Github-PR-Windows/37/testReport/junit/org.apache.tools.ant.taskdefs.optional.junit/XMLResultAggregatorTest/testFrames/ looks related to

[GitHub] ant-ivy issue #65: IVY-1485 Ensure dependency is applicable to all configura...

2018-02-06 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/65 These changes don't solve the real issue. The details of this issue are part of the discussion in ant dev mailing list, where I explained what the real issue is. I do have a completely diff

[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...

2018-02-06 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r166282397 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource

[GitHub] ant issue #59: Fix NPE in ChainedMapper.

2018-02-08 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/59 Thanks for the PR @jpountz. Can we add you to our contributors file, crediting you for this fix? If yes, what would you like your name to be mentioned as

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-08 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/57 Looks good to me. If @bodewig doesn't have any concerns with this change, I'll go ahead and merge this, this week. --- --

[GitHub] ant-ivy issue #66: IVY-1545 Detect circular dependencies in POMs

2018-02-08 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/66 @javabrett, thank you reporting as well as providing the fix for this. This is now merged. --- - To unsubscribe, e-mail: dev

[GitHub] ant-ivy issue #68: Why no new Ivy version yet?

2018-02-08 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/68 There will be one soon. There's a discussion going on, in the mailing list to work towards a release soon. --- - To unsubs

[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...

2018-02-08 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r167136873 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-09 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/57 @adamretter, this is now merged and we have added your name (Adam Retter) to our contributors list. If you want us to a use different name or not include the name at all, please do let us know

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/60 JUnit 5 support - A new junitlauncher task This is the initial working version of a new `junitlauncher` task that support using JUnit 5 framework for testing, within Ant build files. The commit in

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/60 Please ignore the Jenkins failures on this PR. I'll sort out that part in a separate discussion. --- - To unsubscribe, e-mail

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/61 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/60 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/61 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/61 Thank for you the PR. This is now merged --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e

[GitHub] ant issue #62: Use char notation to represent a character to improve perform...

2018-02-16 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/62 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #62: Use char notation to represent a character to improve perform...

2018-02-16 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/62 Hi @reudismam, Is there some reference documentation which states that this construct performs better? My brief check of the JLS just showed a note which states that some implementations _might_

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-18 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168983118 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

<    1   2   3   4   5   6   7   8   >