User implementations of custom interfaces can have access to Task instance?

2018-03-12 Thread Jaikiran Pai
I'm looking for some suggestion on whether it's a good/bad idea to expose a method to custom user defined classes which takes a "Task" object. This is in context of the JUnitLauncher task that I recently added. It allows custom report formatters/listeners to be implemented and the expectation i

Re: User implementations of custom interfaces can have access to Task instance?

2018-03-17 Thread Jaikiran Pai
lugged in something like: classname="some.custom.class.implementing.an.task.specific.interface"/> plus the fact that this custom class can reside in a classloader defined by nested elements of this task. -Jaikiran On 13/03/18 3:36 PM, Stefan Bodewig wrote: On 2018-03-13, Jaikiran P

Re: When is Ant 1.10.3 release expected?

2018-03-17 Thread Jaikiran Pai
I (finally) merged the JUnit 5 work to master. Rest of the fork related work for this task is something that I don't plan to make available in this release (the work is going to take some time). So I guess, we can make a new release. -Jaikiran On 12/03/18 4:53 PM, Stefan Bodewig wrote: On 2

Re: AW: Ant nightly Jenkins job

2018-03-17 Thread Jaikiran Pai
kiran On 01/03/18 6:54 PM, Jan Matèrne (jhm) wrote: sure Jan -Ursprüngliche Nachricht- Von: Jaikiran Pai [mailto:jai.forums2...@gmail.com] Gesendet: Donnerstag, 1. März 2018 12:50 An: Ant Developers List Betreff: Ant nightly Jenkins job Would it be OK if I redo the Ant nightly jenkins

Snapshot access to regular users of Ant

2018-03-17 Thread Jaikiran Pai
I was about to send a mail to the user mailing list about the Ant nightly job which publishes the daily snapshots, so that they can test some bug fixes and new features (JUnit 5 in particular). However, I happened to read the Apache release policy[1] which states regular users aren't even meant

Re: ant git commit: Add dependency description

2018-03-17 Thread Jaikiran Pai
The change noted in this commit isn't actually needed i.e. the junitlauncher task doesn't require the junit.jar to be available as noted in the junitlauncher task's manual. I however forgot to include the JUnit 5 platform API dependencies in this Library Dependencies table, which I'll add now.

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Jaikiran Pai
Hi Stefan, This looks like some odd merge or squashing issue when I pushed that task changes. I have fixed it. The task itself doesn't need any JUnit test engine specific dependencies like this one. I just pushed the commit upstream which should fix this. P.S: I haven't responded to some oth

Re: [VOTE] Release Ant 1.10.3 based on RC1

2018-03-23 Thread Jaikiran Pai
+1. Except for a documentation issue which I explain below, rest all looks fine. I'm not sure if for the documentation fix (which I have pushed upstream) we need to redo a new RC release. - Downloaded apache-ant-1.10.3-bin.tar.gz - set ANT_HOME to this version and built ant-ivy repo (ant clean

Re: [VOTE] Release Ant 1.9.11 based on RC1

2018-03-23 Thread Jaikiran Pai
+1 - Downloaded the apache-ant-1.9.11-bin.tar.gz - Set ANT_HOME to this version, built ant-ivy repo using this version -ALL OK - Built a couple of local projects using this version - ALL OK - A brief check of the manualshows no major issues. I committed a fix in the documentation related to

Re: ant git commit: Add dependency description

2018-03-24 Thread Jaikiran Pai
#x27;s worth a note anyway. I was wondering why junitlauncher task depended on all jars being present in Ant classpath with no possibility to set a separate classpath for the task? Gintas 2018-03-17 15:05 GMT+01:00 Jaikiran Pai : The change noted in this commit isn't actually needed i.e. the

Re: junitlauncher doc fix (was Re: [VOTE] Release Ant 1.10.3 based on RC1)

2018-03-24 Thread Jaikiran Pai
On 24/03/18 1:03 PM, Stefan Bodewig wrote: On 2018-03-24, Jaikiran Pai wrote: I'm not sure if for the documentation fix (which I have pushed upstream) we need to redo a new RC release. If I understand your change correctly then the manual as would be released with 1.10.3 is plain wron

Re: [VOTE] Release Ant 1.10.3 based on RC2

2018-03-25 Thread Jaikiran Pai
+1. Verified that the changes in the junitlauncher task documentation are present. Also ran some local projects with this new 1.10.3 tar.gz and all was fine. -Jaikiran On 24/03/18 6:18 PM, Stefan Bodewig wrote: Hi all I've created a new release candidate for 1.10.3 incorporating the doc f

Re: [ANN] Apache Ant 1.9.11 and 1.10.3 Released

2018-03-27 Thread Jaikiran Pai
Stefan, thank you for running these releases. -Jaikiran On 28/03/18 10:52 AM, Stefan Bodewig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The Apache Ant Team is pleased to announce the releases of Apache Ant 1.9.11 and 1.10.3. Apache Ant is a Java library and command-line tool that h

Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-06 Thread Jaikiran Pai
I don't mean to appear authoritative but I feel that these mass, never-ending changes to various projects under the Ant umbrella, related to formatting, coding style, whitespaces, syntax changes and such aren't really worth it. Especially when a lot of those changes are merely, IMO, personal pr

Re: Ivy release

2018-04-09 Thread Jaikiran Pai
+1. Thanks Nicolas. -Jaikiran On Monday, April 9, 2018, Nicolas Lalevée wrote: > The last thread about a release has been stuck in the discussion about which PR, patch or Jira needed to be tackled before releasing. I suggest we just move forward with the current master. I volunteer to build a 2.

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-10 Thread Jaikiran Pai
On 10/04/18 12:27 AM, Gintautas Grigelionis wrote: 2018-04-08 16:13 GMT+00:00 Stefan Bodewig : I don't believe woking well tested code rots. Code rot is something that happends when code doesn't get adapted to changing environments or requirements. This is not the case here. I wrote earlier

Re: [VOTE] Ivy 2.5.0-rc1 Release

2018-04-12 Thread Jaikiran Pai
+1. Thank you Nicolas for running this release. Tested the following: - Downloaded the .tar.gz binary - Checked some random docs, that are part of the download. Looks fine. - Built some random internal projects using this downloaded version of Ivy, using Java 8. All went well. - Verified b

Re: ant git commit: More isEmpty()

2018-04-13 Thread Jaikiran Pai
On 11/04/18 1:27 PM, Stefan Bodewig wrote: On 2018-04-06, wrote: http://git-wip-us.apache.org/repos/asf/ant/blob/c3b91f90/src/main/org/apache/tools/ant/types/ArchiveFileSet.java -- diff --git a/src/main/org/apache/tools/ant/t

JUnit 5 tests incorrectly picked up during Ant junit tests

2018-04-15 Thread Jaikiran Pai
It indeed looks like a build exclusion that I might have missed. I will take a look at this and fix it. -Jaikiran On 15/04/18 9:35 PM, Stefan Bodewig wrote: On 2018-04-15, Gintautas Grigelionis wrote: By the looks of it, JUnit 5 runner tests need an assumption check, too. Not sure why, but

Include ANT_HOME location in "ant -version" ?

2018-04-19 Thread Jaikiran Pai
In context of this[1] and many similar questions/confusion previously, I am wondering if our "ant -version" output should even include, a line in the output, the location which is used as ANT_HOME? That will probably make it clearer and easy to understand where it's being printed from. Any thou

Re: Ant JUnit tests

2018-04-19 Thread Jaikiran Pai
Like discussed in the other thread, I don't understand what's wrong with setting the expected properties in the IDE itself (like the "ant.home"). IDEs provide these configurations/settings for reasons like these. What would it achieve by virtually disabling these tests, in IDE, by adding those

Re: [Announce] Release of Apache Ivy 2.5.0-rc1

2018-04-22 Thread Jaikiran Pai
Thank you Nicolas for running this release. -Jaikiran On 22/04/18 11:24 PM, Nicolas Lalevée wrote: The Apache Ivy project is pleased to announce its 2.5.0-rc1 release. Apache Ivy is a tool for managing (recording, tracking, resolving and reporting) project dependencies, characterized by flexi

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Jaikiran Pai
What purpose is this change serving? -Jaikiran On 30/04/18 10:08 AM, gin...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master 0add85310 -> f3dfb7779 Inline buildfile names, make search easier Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: http://git-

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Jaikiran Pai
e parameterized in a manner where each test has its own buildfile. Gintas 2018-04-30 4:43 GMT+00:00 Jaikiran Pai : What purpose is this change serving? -Jaikiran On 30/04/18 10:08 AM, gin...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master 0add85310 -> f3dfb7779

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Jaikiran Pai
On 30/04/18 3:52 PM, Gintautas Grigelionis wrote: 2018-04-30 9:55 GMT+00:00 Stefan Bodewig : On 2018-04-30, Gintautas Grigelionis wrote: My apologies for offending anyone; just one last silly question: why uniformity is not a requirement? Who's uniformity do you pick? There are so many choi

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Jaikiran Pai
that espoused TMTOWDI has moved to TIMTOWTDIBSCINABTE? Sorry, I really don't know what that means or how that relates to what we are discussing. -Jaikiran Gintas 2018-04-30 5:56 GMT+00:00 Jaikiran Pai : On 30/04/18 11:12 AM, Gintautas Grigelionis wrote: Names of buildfiles used in tests can be fo

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later tonight. -Jaikiran On 12/05/18 4:45 PM, Simon IJskes wrote: Hi, Just checking if this bug is known? I could not find it in bugzilla. https://issues.apache.org/jira/browse/NETBEANS-781 Groeten, Simon --

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb [2] https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ -Jaikiran On 12/05/18 5:30 PM, Jaikiran Pai wrote: Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
On 12/05/18 8:29 PM, Simon IJskes wrote: I went ahead and pushed a commit[1] to fix this. We have our nightly Jenkins job which generates a nightly build. So if you would like to test it, you can pick up a distribution which contains this commit, whenever the next job runs. The artifact should

Re: [GitHub] ant pull request #:

2018-05-12 Thread Jaikiran Pai
I did plan to addit yesterday, but my local tests did not trigger the package-info constant pool entry for some reason. So I decided to not rush it in and spend some time to get the test right, to make sure it works fine. I'll add it in either tonight or tomorrow once I get to see what's going

Re: [GitHub] ant pull request #:

2018-05-13 Thread Jaikiran Pai
No problem. That change to WHATSNEW is fine, I don't mind. -Jaikiran On 13/05/18 1:03 PM, Gintautas Grigelionis wrote: Thanks, great work! I hope you don't mind me taking the liberty to adjust WHATSNEW. Gintas 2018-05-13 6:01 GMT+02:00 Jaikiran Pai : I did plan to addit yesterd

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-16 Thread Jaikiran Pai
I agree. Especially when it's being done on something like for archive entries which can betoo many depending on the archive that is being dealt with. -Jaikiran On 17/05/18 12:04 PM, Maarten Coene wrote: Converting an Enumeration to a List just for iterating it doesn't seem performance and

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Jaikiran Pai
ionis wrote: Thanks for reviewing, I hope Spliterators will do a better job. Gintas 2018-05-17 8:37 GMT+02:00 Jaikiran Pai : I agree. Especially when it's being done on something like for archive entries which can betoo many depending on the archive that is being dealt with. -Jaikiran O

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Jaikiran Pai
ff-b98a3d2097d6a9b5d7e0fc2eac033f24L348 -Jaikiran On 18/05/18 11:15 AM, Gintautas Grigelionis wrote: I'm not quite sure that what you say was true "in most of the cases". Gintas 2018-05-18 6:52 GMT+02:00 Jaikiran Pai : To be honest, I don't

Re: ClassLoaders in JUnit Launcher Task

2018-06-01 Thread Jaikiran Pai
HelloLucas, On 01/06/18 10:46 PM, Lucas Bullen wrote: However, when attempting to do this I run into an issue with ClassLoaders. JUnitLauncherTask.execute() [2] sets the thread's ClassLoader to its own or to an AntClassLoader, both of which do not contain the junit TestEngine's Which test en

Re: ClassLoaders in JUnit Launcher Task

2018-06-03 Thread Jaikiran Pai
so feel free to reply with details if there's something else you are looking for. [1] https://raw.githubusercontent.com/apache/ant/master/manual/Tasks/junitlauncher.html -Jaikiran On 02/06/18 8:39 AM, Jaikiran Pai wrote: HelloLucas, On 01/06/18 10:46 PM, Lucas Bullen wrote: However

Re: ClassLoaders in JUnit Launcher Task

2018-06-03 Thread Jaikiran Pai
On 03/06/18 3:13 PM, Jaikiran Pai wrote: I have now added a section in the junitlauncher task's manual The section's titled "Using the classpath element to include test engines". -Jaikiran to include an example which shows how to setup the classpath element to include

Re: InputHandler and end-of-stream

2018-06-03 Thread Jaikiran Pai
I missed this mail previously. Comments inline. >> Hi >> while reviewing some changes I realized DefaultInputHandler and >> SecureInputHandler may create unexpected outcomes if System.in or >> System.console() signal an end-of-stream and thus readLine/readPassword >> return null. >> The former

Re: AntUnit Bug Causing Jenkins Failures

2018-06-04 Thread Jaikiran Pai
Sounds fine to me. -Jaikiran On 04/06/18 1:08 PM, Stefan Bodewig wrote: Hi all one of the recurring issues that make Jenkins builds fail is a thread-safety bug in AntUnit's log capturing code. This is supposed to be fixed in AntUnit's master branch. I propose to build an alpha version of Ant

Re: Bz 62324

2018-06-09 Thread Jaikiran Pai
For easy reference, the bug in discussion is this one https://bz.apache.org/bugzilla/show_bug.cgi?id=62324 On 09/06/18 12:38 AM, Gintautas Grigelionis wrote: Namely, a stack trace of the exception is logged (in debug mode only) without any separator from the preceding message. While it seems t

Re: Bz 62324

2018-06-09 Thread Jaikiran Pai
On 09/06/18 5:22 PM, Gintautas Grigelionis wrote: Thanks for review, Jaikiran. You're correct, that is the proposed solution, adding a separator (a newline followed by an exception name for clarity -- mind that exception is logged only in debug mode). The exception class name would already be

Proposing Apache IvyDE release

2018-06-13 Thread Jaikiran Pai
I'm in the process of releasing Apache IvyDE Eclipse plugin. As I go along in the release process, I'm updating the (outdated) build/release process. Once the binaries are built, I'll send out a mail for voting on the release. Following the recent convention of Ivy release, I am planning to ca

[VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-13 Thread Jaikiran Pai
I have built a release candidate 2.3.0-rc1 for Apache IvyDE. The tag is here: https://git1-us-west.apache.org/repos/asf?p=ant-ivyde.git;a=commit;h=refs/tags/2.3.0-rc1 You can download the distribution from this URL: https://dist.apache.org/repos/dist/dev/ant/ivyde/2.3.0-rc1 The Eclipse p2 r

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-13 Thread Jaikiran Pai
?path=ivyde-2.3.0.rc1-201806132023-RELEASE&countryCode=se&timeZone=1&format=xml; lineNumber: 39; columnNumber: 3; Element type "link" lack matching end tag "". Gintas Den ons 13 juni 2018 kl 17:48 skrev Jaikiran Pai : I have built a release candidate 2.3.0-rc1 fo

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-13 Thread Jaikiran Pai
Sure, i'll do that today. -Jaikiran On Thursday, June 14, 2018, Stefan Bodewig wrote: > [As usual I'll only be able to review the legal stuff but probably won't > find time to do so before tomorrow or even Saturday (am currently > traveling).] > > On 2018-06-13, Ja

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-14 Thread Jaikiran Pai
On 14/06/18 11:50 AM, Stefan Bodewig wrote: On 2018-06-13, Jaikiran Pai wrote: You can download the distribution from this URL: https://dist.apache.org/repos/dist/dev/ant/ivyde/2.3.0-rc1 Be the releas policy that is in place now SHA1 is deprecated, MD5 is frowned upon and at least SHA256 is

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-15 Thread Jaikiran Pai
dependency in a simple Java class. - Checked some Ivy plugin settings page to make sure they look and work fine. -Jaikiran On 13/06/18 9:18 PM, Jaikiran Pai wrote: I have built a release candidate 2.3.0-rc1 for Apache IvyDE. The tag is here: https://git1-us-west.apache.org/repos/asf?p=ant

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-15 Thread Jaikiran Pai
k" lack matching end tag "". Gintas Den ons 13 juni 2018 kl 17:48 skrev Jaikiran Pai : I have built a release candidate 2.3.0-rc1 for Apache IvyDE. The tag is here: https://git1-us-west.apache.org/repos/asf?p=ant-ivyde.git;a=commit;h=refs/tags/2.3.0-rc1 You can download the di

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
Thanks Stefan, I'll fix these issues and send out a new voting mail. -Jaikiran On Saturday, June 16, 2018, Stefan Bodewig wrote: > Hi > > please add your PGP key to dist.apache.org/release/ant/KEYS > > * checksums and signatures are good > * for the files in updatesite it still contains .md5 and

[CANCEL] [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
Given some of the valid issues that Stefan has raised with this released instance, I'm cancelling this vote. This is a first release after a long time and I plan to have this as clean as possible. I will send out a new vote mail once I sort out these issues. -Jaikiran On 16/06/18 6:48 PM, St

[VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
This is a newer vote mail that I'm initiating for the 2.3.0-rc1 release of IvyDE. The newly updated tag is here https://git1-us-west.apache.org/repos/asf?p=ant-ivyde.git;a=commit;h=refs/tags/2.3.0-rc1 You can download the distribution from this URL: https://dist.apache.org/repos/dist/dev/ant

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
I pushed a bunch of commits to address these issues and have now released newer binaries for 2.3.0-rc1 release and initiated a separate VOTE mail for it. -Jaikiran On 16/06/18 6:48 PM, Stefan Bodewig wrote: Hi please add your PGP key to dist.apache.org/release/ant/KEYS * checksums and sign

Re: thinking about new releases

2018-06-16 Thread Jaikiran Pai
+1. I don't have anything in a state that I can push to either of these branches, in the immediate future. -Jaikiran On 16/06/18 9:38 PM, Stefan Bodewig wrote: Hi all given https://dev.snyk.io/research/zip-slip-vulnerability lists Ant 1.9.12 as a release fixing a security problem it might be

Re: svn commit: r27516 - /release/ant/KEYS

2018-06-17 Thread Jaikiran Pai
Thank you Stefan, I forgot to add it to this location and added only in the git repo. -Jaikiran On 17/06/18 2:00 PM, bode...@apache.org wrote: Author: bodewig Date: Sun Jun 17 08:30:47 2018 New Revision: 27516 Log: Add Jaikiran's key Modified: release/ant/KEYS Modified: release/ant/KE

Re: thinking about new releases

2018-06-18 Thread Jaikiran Pai
I am willing to test and vote on an AntUnit release. -Jaikiran On 18/06/18 12:45 PM, Stefan Bodewig wrote: OK, then I'll revert the antunit change so the source release ships with a released version of it and prepare release candidates sometime the coming days. The alternative would be to cut

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
+1. Tried the installation and used a basic Ivy based project for dependency resolution. Also checked some of the Ivy plugin screens to make sure all is fine. -Jaikiran On 17/06/18 12:15 PM, Jaikiran Pai wrote: This is a newer vote mail that I'm initiating for the 2.3.0-rc1 relea

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
a-vote-to-approve-the-release < https://github.com/apache/ant-ivy/blob/master/asciidoc/dev/makerelease.adoc#11-call-for-a-vote-to-approve-the-release > > > Nicolas > >> Le 17 juin 2018 à 08:45, Jaikiran Pai a écrit : >> >> This is a newer vote mail that I'm

[CANCEL] [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
Given the nature of this issue, I'm cancelling this vote. A new one will be initiated this week. -Jaikiran On 19/06/18 5:05 AM, Jaikiran Pai wrote: Thanks for testing this Nicolas. This indeed is a big enough issue to be considered a blocker. I'll take a look at this. I'll a

Re: [VOTE] Release AntUnit 1.4 Based on RC1

2018-06-19 Thread Jaikiran Pai
- Downloaded the tarballs (both source and binaries). Installed locally. - Verified the checksum file. All fine. - Ran a few antunit tests via simple Ant build files. All fine. This all looked fine. There are some minor issues though: 1. The NOTICE file copyright year is 2005-2014 2. The docs

Re: .git(modules|attributes|ignore) files in source dists?

2018-06-19 Thread Jaikiran Pai
I don't have a preference on whether or not to include the SCM related files, but at least in the recent IvyDE release process, I setup the build to use "git archive" command to generate these source tar/zip packages[1]. The documentation of git archive doesn't explicitly state anything about f

Re: [VOTE] Release Ant 1.9.12 based on RC1

2018-06-19 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz binary - Installed locally, checked the NOTICE and some tasks' manuals. Look fine. - Built some random existing Ant based projects using this new version. All went fine. -Jaikiran On 19/06/18 12:38 PM, Stefan Bodewig wrote: Hi all I've created a new release c

Re: [CANCELLED] Release AntUnit 1.4 Based on RC2

2018-06-21 Thread Jaikiran Pai
I think moving to Ant 1.8.x would be a better option, given the relatively low chances of it causing any issues. -Jaikiran On 21/06/18 2:47 PM, Stefan Bodewig wrote: On 2018-06-21, Gintautas Grigelionis wrote: POM template has inconsistent Ant versions, 1.7.1 in compile scope and 1.8.1 in p

Re: [VOTE] Release Ant 1.10.4 based on RC1

2018-06-21 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz binary - Checked some docs in the manual - Used this new version to run builds against existing internal Ant projects. All went fine. -Jaikiran On 19/06/18 12:38 PM, Stefan Bodewig wrote: Hi all I've created a new release candidate for 1.10.4 with a bunch of

Re: [ANN] Apache Ant 1.9.12 and 1.10.4 Released

2018-06-24 Thread Jaikiran Pai
Thank you for running this release, Stefan. -Jaikiran On 22/06/18 9:09 PM, Stefan Bodewig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The Apache Ant Team is pleased to announce the releases of Apache Ant 1.9.12 and 1.10.4. Apache Ant is a Java library and command-line tool that help

Re: [VOTE] Release AntUnit 1.4 based on RC3

2018-06-24 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz binary - Checked some of the docs/manual - Ran a simple project using this released version - Checked the NOTICE file All looks fine. -Jaikiran On 22/06/18 11:02 AM, Stefan Bodewig wrote: Hi all this is the third RC for AntUnit 1.4 with the problems Gintas id

[VOTE] Release 2.3.0-rc1 of Apache IvyDE

2018-06-24 Thread Jaikiran Pai
I'm initiating a newer vote mail for 2.3.0-rc1 release of Apache IvyDE project. This addresses the blocker issue that Nicolas identified, the last time a vote was initiated for this version. The newly updated tag is here https://git-wip-us.apache.org/repos/asf?p=ant-ivyde.git;a=tag;h=refs/tags

Re: [Bug 33169] KIndly update the date feature

2018-06-27 Thread Jaikiran Pai
Just curious about our bugzilla infrastructure - do random users get to change the content of these bugs, even if they aren't the ones who reported the issue? -Jaikiran On 28/06/18 9:05 AM, bugzi...@apache.org wrote: https://bz.apache.org/bugzilla/show_bug.cgi?id=33169 Ranjeet Mane changed

Re: [VOTE] Release 2.3.0-rc1 of Apache IvyDE

2018-06-27 Thread Jaikiran Pai
On 27/06/18 10:12 PM, Nicolas Lalevée wrote: Since there is a work around (hitting refresh after resolve) and it is an RC, we could ship it like that and fix it later. But due to the automatic update via the update site, I bet most users will update even if it is an RC. So I am not sure what

[CANCELLED]Re: [VOTE] Release 2.3.0-rc1 of Apache IvyDE

2018-06-27 Thread Jaikiran Pai
This vote is now officially cancelledfor the reasons noted below. -Jaikiran On 28/06/18 12:11 PM, Jaikiran Pai wrote: On 27/06/18 10:12 PM, Nicolas Lalevée wrote: Since there is a work around (hitting refresh after resolve) and it is an RC, we could ship it like that and fix it later. But

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-06-28 Thread Jaikiran Pai
I don't have enough background on the expectations of the normalize method, so can't really say how it should behave. Plus, it gets used in relatively larger number of places as compared to isLeadingPath, so not too sure how it might impact other places if we do change its existing semantics.

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-06-28 Thread Jaikiran Pai
On 28/06/18 8:37 PM, Stefan Bodewig wrote: On 2018-06-28, Jaikiran Pai wrote: However, looking at the FileUtils#isLeadingPath(...) implementation, I wonder why it even uses normalize. Given that the goal of that API (as stated in the javadoc) is to figure out if one path leads the other, to

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-07-02 Thread Jaikiran Pai
1/07/18 2:57 PM, Stefan Bodewig wrote: On 2018-06-28, Stefan Bodewig wrote: On 2018-06-28, Jaikiran Pai wrote: Which then makes me wonder - in the context of this specific untar/expand/unzip issue, should we probably be using a different custom very specific logic (which relies on canonical file

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-07-03 Thread Jaikiran Pai
nless someone else sees any issues, I think we can go ahead and do the release that you had planned for. -Jaikiran On 03/07/18 1:16 PM, Stefan Bodewig wrote: On 2018-07-02, Stefan Bodewig wrote: On 2018-07-02, Jaikiran Pai wrote: I just checked the commits related to this and it looks mostly co

Re: Testing IvyDE

2018-07-04 Thread Jaikiran Pai
On 01/07/18 6:35 PM, Nicolas Lalevée wrote: Le 28 juin 2018 à 08:41, Jaikiran Pai a écrit : On 27/06/18 10:12 PM, Nicolas Lalevée wrote: Since there is a work around (hitting refresh after resolve) and it is an RC, we could ship it like that and fix it later. But due to the automatic

Re: ant git commit: Unbreak tests

2018-07-04 Thread Jaikiran Pai
On 05/07/18 12:57 AM, Stefan Bodewig wrote: Gintas, - passfile="testpassfile.tmp"%/> + passfile="testpassfile.tmp"/> the commit that introduced the issue was labeled "Trailing whitespace" and I trusted to contain exactly that and didn't bother reviewing it. Obviously it did not. A s

Re: ant git commit: Enhance the Java task to allow single file source program execution, a feature, introduced in Java 11

2018-07-05 Thread Jaikiran Pai
On 05/07/18 1:02 AM, Stefan Bodewig wrote: On 2018-07-04, wrote: Enhance the Java task to allow single file source program execution, a feature, introduced in Java 11 +1 Could you please add javadocs to the new getter/setter in CommmandLineJava? Ah yes, missed that one. Added now. -Jaikira

Re: ant git commit: Unbreak tests

2018-07-05 Thread Jaikiran Pai
On 05/07/18 2:42 PM, Stefan Bodewig wrote: On 2018-07-05, Jaikiran Pai wrote: I personally believe that reviewing these meaningless changes is a waste of time and energy. I'm in favour of rolling back the entire commit set if that's what it takes. +1 although reverting the commi

Re: ant git commit: Unbreak tests

2018-07-07 Thread Jaikiran Pai
regular development and other planned activities. -Jaikiran On 06/07/18 2:32 PM, Stefan Bodewig wrote: On 2018-07-06, Jaikiran Pai wrote: On 05/07/18 2:42 PM, Stefan Bodewig wrote: On 2018-07-05, Jaikiran Pai wrote: I personally believe that reviewing these meaningless changes is a waste o

Re: ant git commit: Unbreak tests

2018-07-07 Thread Jaikiran Pai
Hello Martijn, Thank you for spending time on this and for that checker. I did look into yourmail and considered itbefore deciding on what to do with the state of upstream branches.I decided to go with a complete revert approach (which I explain in a separate reply in this thread), because I

Re: [VOTE] Release Ant 1.9.13 based on RC1

2018-07-10 Thread Jaikiran Pai
+1 - Downloaded .tar.gz from https://dist.apache.org/repos/dist/dev/ant/binaries/ - Extracted locally, checked WHATSNEW, NOTICE files. - Browsed some random manual pages. Looks fine. - Built some internal Ant based projects. All went fine. - Tested that the following build script works with

Re: [VOTE] Release Ant 1.10.5 based on RC1

2018-07-11 Thread Jaikiran Pai
+1 - Downloaded the .tar.gz from https://dist.apache.org/repos/dist/dev/ant/ - Extracted locally - Checked the NOTICE and WHATSNEW files. Looks fine. - Checked some random manuals. Looks fine. - Checked the javac task manual. Looks fine. - Tested the following build script to verify that it

[ANNOUNCE] Apache Ant 1.9.13 and 1.10.5 Released

2018-07-15 Thread Jaikiran Pai
to submit bug reports, patches, or suggestions for improvement, see the Apache Ant website https://ant.apache.org/ -Jaikiran Pai, on behalf of the Apache Ant community signature.asc Description: OpenPGP digital signature

Re: Jenkins-Builds failing

2018-07-20 Thread Jaikiran Pai
Haven't checked the job, but why is this system property required to be set? -Jaikiran On 20/07/18 12:51 AM, Gintautas Grigelionis wrote: > I'd like to add a Java option to Ivy builds -Dhttps.protocols=TLSv1.2 but I > get > This job's current authorization strategy does not permit gintas to modi

Re: Jenkins-Builds failing

2018-07-20 Thread Jaikiran Pai
es from Maven Central > because earlier versions are disabled [1] (and TLS 1.0 is the default in > Java 7). > > Gintas > > 1. > https://blog.pcisecuritystandards.org/are-you-ready-for-30-june-2018-sayin-goodbye-to-ssl-early-tls > > On Fri, 20 Jul 2018 at 09:31, Jaikiran Pai w

Re: Jenkins-Builds failing

2018-07-24 Thread Jaikiran Pai
rsprüngliche Nachricht- >>>>> Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com] >>>>> Gesendet: Sonntag, 22. Juli 2018 10:48 >>>>> An: Ant Developers List >>>>> Betreff: Re: Jenkins-Builds failing >>>>> >>>>> Sho

Re: Jenkins-Builds failing

2018-07-24 Thread Jaikiran Pai
There are a few more jobs that need to be reconfigured a bit to get them working. I'm working with infra team to have that sorted out. Please ignore the failure mails from those jobs for now. -Jaikiran On 25/07/18 10:30 AM, Jaikiran Pai wrote: > I've committed a change[1] to handl

Re: Jenkins-Builds failing

2018-07-25 Thread Jaikiran Pai
On 25/07/18 11:07 AM, Jaikiran Pai wrote: > There are a few more jobs that need to be reconfigured a bit to get them > working. I'm working with infra team to have that sorted out. Please > ignore the failure mails from those jobs for now. > > -Jaikiran > > On 25/07/18 10:

Re: Jenkins-Builds failing

2018-07-27 Thread Jaikiran Pai
On 25/07/18 6:45 PM, Jaikiran Pai wrote: > Almost all jobs that I know of have been taken care of now. There's a > "Ivy-tests-Windows" job which is pending, but for that I need some help > from infra team. I am discussing it with them separately and I expect it > to

Re: Jenkins-Builds failing

2018-07-29 Thread Jaikiran Pai
be willing to restart the release process > for IvyDE now? Gintas On Fri, 27 Jul 2018 at 15:43, Jaikiran Pai > wrote: >> On 25/07/18 6:45 PM, Jaikiran Pai wrote: >>> Almost all jobs that I know of have been taken care of now. There's >>> a "Ivy-tests-Windows

Re: Jenkins-Builds failing

2018-08-05 Thread Jaikiran Pai
t; Could you please check it, Jaikiran? > > Thanks, Gintas > > On Sun, 29 Jul 2018 at 15:13, Jaikiran Pai wrote: > >> I would like to test/import a few more projects (that Nicolas mentioned >> in one the mails) locally into the latest upstream version of the IDE, >> be

Re: Jenkins-Builds failing

2018-08-13 Thread Jaikiran Pai
ss denied >> This job's current authorization strategy does not permit jhm to modify >> the job configuration >> >> Asked in https://issues.apache.org/jira/browse/INFRA-16799 for >> checking+fixing all of our jobs. >> >> >> Jan >> &g

Re: mail task

2018-08-13 Thread Jaikiran Pai
Which vendor and version of Java is this? -Jaikiran On 13/08/18 6:39 PM, Simon IJskes - QCG wrote: > I still have problems installing ant binary distribution (1.10.5) and > using the email task. > > I've tried to complete the binary directories by running either: > > ant -f fetch.xml -Ddest=syst

Re: mail task

2018-08-13 Thread Jaikiran Pai
Yes, it looks like one of our changes broke this. We seem to just fetch the mail API jar(s) and no longer fetch the jars which includethe provider implementation(s). Can you please file a bug for this, in the Ant bugzilla? -Jaikiran On 13/08/18 7:13 PM, Simon IJskes - QCG wrote: > It looks like

Re: mail task

2018-08-13 Thread Jaikiran Pai
17 PM, Jaikiran Pai wrote: > Yes, it looks like one of our changes broke this. We seem to just fetch > the mail API jar(s) and no longer fetch the jars which includethe > provider implementation(s). Can you please file a bug for this, in the > Ant bugzilla? > > -Jaikiran > > > O

Re: mail task

2018-08-13 Thread Jaikiran Pai
On 13/08/18 9:32 PM, Simon IJskes - QCG wrote: > Thanks, > > Shall i still file a bug? I want to give netbeans a heads up when this > is in a release. > > Gr. Simon > > On 08/13/2018 04:48 PM, Jaikiran Pai wrote: >> I pushed a commit to both our 1.9.x and master bran

Re: mail task

2018-08-13 Thread Jaikiran Pai
Thank you for reporting the issue and testing the fix, Simon. -Jaikiran On 14/08/18 1:39 AM, Simon IJskes - QCG wrote: > fix works. Thanks! > > On 08/13/2018 09:55 PM, Simon IJskes - QCG wrote: >> https://bz.apache.org/bugzilla/show_bug.cgi?id=62621 >> >> On 08/13/

Re: ant git commit: Use try-with-resources and ExpectedException

2018-08-14 Thread Jaikiran Pai
Gintas, On 14/08/18 10:14 PM, gin...@apache.org wrote: > http://git-wip-us.apache.org/repos/asf/ant/blob/e648224f/src/tests/junit/org/apache/tools/ant/taskdefs/email/EmailTaskTest.java > -- > diff --git > a/src/tests/junit/org/a

Re: ant git commit: Use try-with-resources and ExpectedException

2018-08-15 Thread Jaikiran Pai
e been > helpful in eventual migration to JUnit 5, too. JUnit 5 migration isn't related to the commit I am talking about. -Jaikiran > > Gintas > > On Wed, 15 Aug 2018 at 03:14, Jaikiran Pai wrote: > >> Gintas, >> >> >> On 14/08/18 10:14 PM, gin...@apa

Re: ant git commit: Use try-with-resources and ExpectedException

2018-08-15 Thread Jaikiran Pai
in eventual migration to JUnit 5, too. >> >> Gintas >> >> On Wed, 15 Aug 2018 at 03:14, Jaikiran Pai wrote: >> >>> Gintas, >>> >>> >>> On 14/08/18 10:14 PM, gin...@apa

junitlauncher task - support for system properties in a non-forked execution

2018-08-16 Thread Jaikiran Pai
While working on the documentation of the junitlauncher task, for fork support, I realized that when we first released this task, due to an oversight, I did not add support for setting system properties or environment variables through this task. The fork element now supports that[1] in the upcomin

<    1   2   3   4   5   6   >