Proposed changes for IVY-735 - Ability to specify timeouts

2017-07-14 Thread Jaikiran Pai
https://issues.apache.org/jira/browse/IVY-735 is a feature request where the users have asked for relevant timeouts while dealing with downloads. A few weeks back we had a very brief discussion in an unrelated mail where it was proposed that we allow configuring these timeout all the way from iv

Proposed changes for IVY-735 - Ability to specify timeouts

2017-07-14 Thread jaikiran . pai
https://issues.apache.org/jira/browse/IVY-735 is a feature request where the users have asked for relevant timeouts while dealing with downloads. A few weeks back we had a very brief discussion in an unrelated mail where it was proposed that we allow configuring these timeout all the way from i

Re: Coding style: import of nested classes

2017-07-20 Thread Jaikiran Pai
I have no personal preference for this specific kind of usages. Although I almost always use Map.Entry in the statements, I don't mind seeing code which uses just plain Entry. Having said that, for this specific kind of cases, I personally would just let the developer decide which form of it to

Re: Proposed changes for IVY-735 - Ability to specify timeouts

2017-07-21 Thread Jaikiran Pai
The support for this feature is now available. Given that this is kind of a core and relatively big change, I decided to open a PR[1] so that some of us can take a look to make sure the changes make sense. The description in the PR plus the documentation in the commit explains how this works, f

Re: Next Ivy release?

2017-07-22 Thread Jaikiran Pai
In short, yes - there's a plan to have a Ivy release soon. A more detailed explanation is available in this recent Ivy users mailing list thread https://www.mail-archive.com/ivy-user@ant.apache.org/msg06244.html -Jaikiran On 22/07/17 8:12 AM, Nick C. wrote: Will there be a new Ivy release so

Re: Broken link at https://ant.apache.org/mail.html

2017-07-23 Thread Jaikiran Pai
On 23/07/17 3:50 PM, Stefan Bodewig wrote: On 2017-07-22, George Bateman wrote: On subscribing to this list, I noticed that the link at the end of In your first email you will get some information about working with the list manager EZMLM. goes to http://www.ezmlm.org/, which is actually, i

Ivy - No more support for commons-httpclient 2.x in runtime classpath?

2017-07-23 Thread Jaikiran Pai
Ivy currently uses commons-httpclient for dealing with HTTP repositories. This is an internal implementation detail of Ivy. The way it's implemented, it allows the user to use a version of their choice, of this library, by placing them in the runtime classpath (similar to some other libraries w

Re: AW: Ivy - No more support for commons-httpclient 2.x in runtime classpath?

2017-07-23 Thread Jaikiran Pai
omeone else). Jan -Ursprüngliche Nachricht- Von: Jaikiran Pai [mailto:jai.forums2...@gmail.com] Gesendet: Montag, 24. Juli 2017 07:25 An: dev@ant.apache.org Betreff: Ivy - No more support for commons-httpclient 2.x in runtime classpath? Ivy currently uses commons-httpclient for dealing with

Re: Ivy - No more support for commons-httpclient 2.x in runtime classpath?

2017-07-23 Thread Jaikiran Pai
That's a a big enough reason to move to HttpComponents Client 4.x version! I'll have that done in this release of Ivy then. -Jaikiran On 24/07/17 11:43 AM, Stefan Bodewig wrote: On 2017-07-24, Jaikiran Pai wrote: Ivy currently uses commons-httpclient for dealing with HTTP re

Re: Ivy - No more support for commons-httpclient 2.x in runtime classpath?

2017-07-25 Thread Jaikiran Pai
ist to give the latest snapshot a try to see if there are any unforeseen regressions. -Jaikiran On 25/07/17 12:37 AM, Nicolas Lalevée wrote: Le 24 juil. 2017 à 08:19, Jaikiran Pai a écrit : That's a a big enough reason to move to HttpComponents Client 4.x version! I'll have that do

Ivy Jenkins jobs have been failing - infra issues

2017-07-26 Thread Jaikiran Pai
More of a FYI than anything else - the past couple of days or so, we haven't had regular successful runs of our various Ivy Jenkins jobs. Each run failing with different errors, all pointing back to infrastructure issues at this moment. In fact, I see some other Apache project builds running in

Ivy - Move to symlink creation standard Java API?

2017-07-26 Thread Jaikiran Pai
I was looking into a JIRA related to symlinking in Ivy and realized that (for reasons noted in the docs and the implementation) ourimplementation of symlinking relies on launching a process from within the JVM to invoke a shell command to create the symlinks. "retrieve" task is the only one tha

Re: Build failed in Jenkins: Ivy #627

2017-07-26 Thread Jaikiran Pai
To avoid more such mails, I'm going to disable this job for a few hours till we get the infra issues sorted out. -Jaikiran On 26/07/17 10:44 PM, Apache Jenkins Server wrote: See -- Started by an

Re: Ivy Jenkins jobs have been failing - infra issues

2017-07-26 Thread Jaikiran Pai
https://issues.apache.org/jira/browse/INFRA-14712 -Jaikiran On 26/07/17 6:36 PM, Jaikiran Pai wrote: More of a FYI than anything else - the past couple of days or so, we haven't had regular successful runs of our various Ivy Jenkins jobs. Each run failing with different errors, all poi

Re: Ivy - Move to symlink creation standard Java API?

2017-07-27 Thread Jaikiran Pai
treff: Re: Ivy - Move to symlink creation standard Java API? Le 26 juil. 2017 à 15:25, Jaikiran Pai a écrit : I was looking into a JIRA related to symlinking in Ivy and realized that (for reasons noted in the docs and the implementation) ourimplementation of symlinking relies on launching a pr

Re: AW: Ivy - Move to symlink creation standard Java API?

2017-07-27 Thread Jaikiran Pai
On 27/07/17 2:14 PM, Jan Matèrne (jhm) wrote: Getting rid of that means being more standard compliant and having less to maintain. ;) Agreed. Plus the fact that our previous implementation of this feature relied on the presence of the "ln" command on the systems, which effectively ruled out t

Is CacheResolver relevant?

2017-07-27 Thread Jaikiran Pai
There's this JIRA issue https://issues.apache.org/jira/browse/IVY-804 where the user reports a genuine bug in our typedef.properties file where we list the "cache" property twice with different values. Once to consider the element as a resolver and the other to consider the element as the cac

Re: Is CacheResolver relevant?

2017-07-27 Thread Jaikiran Pai
On 27/07/17 9:34 PM, Jaikiran Pai wrote: There's a JIRA[2] asking for the docs to be updated to explain this resolver. ... [2] https://issues.apache.org/jira/browse/IVY-804 I meant this JIRA which asks for it to be documented https://issues.apache.org/jira/browse/IVY-612 -Jai

Ivy - PR-57 need inputs

2017-07-28 Thread Jaikiran Pai
This PR - https://github.com/apache/ant-ivy/pull/57 does changes related to generics usage. I reviewed it a while back and it looks fine overall except for one change, for which I need inputs from the rest of the team. Ivy has a DependencyResolver interface which is the central piece of contra

Ivy - PR-57 need inputs

2017-07-28 Thread Jaikiran Pai
This PR - https://github.com/apache/ant-ivy/pull/57 does changes related to generics usage. I reviewed it a while back and it looks fine overall except for one change, for which I need inputs from the rest of the team. Ivy has a DependencyResolver interface which is the central piece of contra

Re: IVY-1485

2017-08-07 Thread Jaikiran Pai
I'm looking into that JIRA. I'll assigned it to my name now. -Jaikiran On 06/08/17 12:52 PM, Gintautas Grigelionis wrote: I went through JIRA issues and noticed https://issues.apache.org/jira/browse/IVY-1485 was discussed relatively recently ;-) Anybody looking into it? Gintas P.S. JIRA list

Re: Documentation-related issues in Jira

2017-08-22 Thread Jaikiran Pai
Some of those issues are still relevant. I haven't been able to look at that complete list, so if you can add a comment in those JIRAs which are no longer valid, then I can take a look at those specific ones and review and close them. I'll be able to look at the complete list this weekend. -J

Re: Ant-Ivy: Publish don't pull declared dependencies

2017-08-28 Thread Jaikiran Pai
As far as I know, the publish task itself doesn't fetch any dependencies. The dependencies itself are downloaded by a (previous) resolve task that is invoked separately and explicitly. -Jaikiran On 31/07/17 11:32 PM, maikel van den Hurk wrote: Hi all, I am wondering if there is already a p

Re: Broken tutorial

2017-08-28 Thread Jaikiran Pai
It's not actually broken. The tutorial intentionally uses (and documents) it to explain how the repository is built and what happens when certainartifacts aren't available and also for cases like where there are version conflicts for the same module. The tutorial page[1] notes: As you can see

Ivy - Latest snapshots will now be regularly available in Apache Maven Snapshot repository

2017-08-31 Thread Jaikiran Pai
Starting today, we now have an Ivy Jenkins job[1] which will publish our Ivy snapshot artifactto Apache Maven Snapshots repository[2]. This job has been configured to run after a successfulcompletion of our Ivy tests job (which runs on *nix). What this effectively means is that we now have reg

Re: Broken tutorial

2017-08-31 Thread Jaikiran Pai
On 29/08/17 12:35 PM, Gintautas Grigelionis wrote: I noticed another problem with asciidoc: 1.5.4 fails on my box with the latest Java 8u144, I had to downgrade it to 1.5.3 -- did anyone else see that? 1.5.4 works fine for me with Java 8. -Jaikiran --

Re: [1/6] ant-ivy git commit: Documentation review (partly inspired by IVY-1089) [Forced Update!]

2017-09-05 Thread Jaikiran Pai
IMO, we should avoid force updates to upstream repos, since it rewrites history of the repo. Typically a force update is a sign that the local state of a repo is not in sync with whatever is latest upstream and that should be solved locally by rebasing the local changes (and locally resolving m

Ivy upcoming release - where we stand

2017-09-11 Thread Jaikiran Pai
It's been a while since we have decided to revive the Ivy project and work towards a usable release. Since then, we have fixed a good number of bugs, added some enhancements and updated the documentation (we also switched to asciidoc based docs internally). When we started this, the goal was to

Re: Error while testing 2.5.0-SNAPSHOT

2017-09-14 Thread Jaikiran Pai
at org.apache.ivy.util.url.HttpClientHandler.openStream( HttpClientHandler.java:141) at org.apache.ivy.plugins.parser.m2.PomReader.(PomReader.java:122) It looks like whatever part of code is invoking Ivy from their code, is setting the "default" URL handler as the HttpClientHandler instead of th

Re: Ivy upcoming release - where we stand

2017-09-24 Thread Jaikiran Pai
abstract class is sufficient for the use cases found in the wild. Gintas [1] https://docs.oracle.com/javase/tutorial/java/generics/ restrictions.html 2017-09-11 17:05 GMT+02:00 Jaikiran Pai : It's been a while since we have decided to revive the Ivy project and work towards a usable rel

Re: Error while testing 2.5.0-SNAPSHOT

2017-09-25 Thread Jaikiran Pai
Is there a source repo and steps that I can follow to build and reproduce this issue? My attempts so far haven't been able to reproduce this. -Jaikiran On 14/09/17 1:57 PM, Aurélien Pupier wrote: Hello, I'm trying to test https://issues.apache.org/jira/browse/IVY-1568 using latest 2.5.0-SNA

Re: ant-ivy git commit: IVY-1420 document current implementation [Forced Update!]

2017-10-21 Thread Jaikiran Pai
Let's not force update the upstream repo please, especially the real branches like the master branch. -Jaikiran On 21/10/17 10:22 PM, gin...@apache.org wrote: Repository: ant-ivy Updated Branches: refs/heads/master 744c31824 -> 2074889ec (forced update) IVY-1420 document current implemen

Re: [2/2] ant-ivy git commit: No need to synchronise a concurrent map

2017-11-01 Thread Jaikiran Pai
Based on my cursory look at this code and this change, I think this change isn't right. From what I see in the code, the synchronized block is necessary, since what it's trying to achieve there is a mutual exclusivity over a bunch of operations within that block. With this synchronized block re

Re: new JDK version scheme

2017-11-28 Thread Jaikiran Pai
In their JEP[1] (based on which this got implemented), it does recommend relying on this "java.specification.version" whose value is expected to be an integer (for Java releases starting Java 9). There's a table in that [1] which has the values for this system property for hypothetical release

Re: ant-ivy git commit: tidy up the code

2017-12-08 Thread Jaikiran Pai
On 08/12/17 2:23 PM, Dominique Devienne wrote: On Fri, Dec 8, 2017 at 7:53 AM, wrote: Repository: ant-ivy Updated Branches: refs/heads/master 1b84f2ee7 -> 12aeeec70 tidy up the code -if ((currentTask.getTaskName() != null) +if (currentTask.getTaskName() != null

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-10 Thread Jaikiran Pai
I'll investigate why this is failing (local tests pass for me) and fix it. -Jaikiran On 10/12/17 2:29 PM, Apache Jenkins Server wrote: See -

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-10 Thread Jaikiran Pai
You are right, that indeed was the issue (for one of that failing test). I have pushed a commit with this change to fix that one. -Jaikiran On 10/12/17 3:13 PM, Stefan Bodewig wrote: On 2017-12-10, Stefan Bodewig wrote: testCreateDoubleHanging is related to https://bz.apache.org/bugzilla/sh

Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

2017-12-10 Thread Jaikiran Pai
On 10/12/17 3:09 PM, Stefan Bodewig wrote: On 2017-12-10, Jaikiran Pai wrote: I'll investigate why this is failing (local tests pass for me) and fix it. Target testCreateOverFile in the antunit test explicitly tries to replace a file with a link, doing exactly what the bugzilla report

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

2017-12-11 Thread Jaikiran Pai
you in as you've been the one who brought in the change that gets contested by https://bz.apache.org/bugzilla/show_bug.cgi?id=58683 and maybe you recall the details better than we do.] On 2017-12-10, Jaikiran Pai wrote: On 10/12/17 3:09 PM, Stefan Bodewig wrote: On 2017-12-10, Jaikiran P

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

2017-12-11 Thread Jaikiran Pai
So I have now pushed a fix[1] on top of my previous changes, which should accommodate both these use cases (and continue to use Java 7 APIs for symlinking). This is very useful, many thanks. We may want to modify the manual so it becomes clear that overwrite will replace regular files as well.

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-12 Thread Jaikiran Pai
So the one final test that's still failing is this one[1]. It's failing consistently only on Jenkins, that too with only Java 8 (jdk1.8.0_131). I have tried reproducing that one locally with that exact Java version and even the latest Java 8 and haven't been able to reproduce it. Before I try a

Please ignore the github emails for the next hour or so

2017-12-12 Thread Jaikiran Pai
Sorry about the continuous mails from github/ant repo. I'm (yet again) trying to get the Jenkins job integrated with Ant github repo. I don't have a way to disable these mails while I experiment with it to get it right. Hopefully, it should be sorted out in the next hour or so. -Jaikiran ---

Github ant repo now integrated with Jenkins for pull request testing

2017-12-12 Thread Jaikiran Pai
We now have integrated our Jenkins build environment hosted by apache.org with our Ant github repo[1], such that whenever a pull request is submitted, it now triggers a build and runs tests against the submitted pull request and then comments/adds a status to the PR on how the build went. This

Re: Please ignore the github emails for the next hour or so

2017-12-12 Thread Jaikiran Pai
05 PM, Jaikiran Pai wrote: Sorry about the continuous mails from github/ant repo. I'm (yet again) trying to get the Jenkins job integrated with Ant github repo. I don't have a way to disable these mails while I experiment with it to get it right. Hopefully, it should be sorted out in the

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-12 Thread Jaikiran Pai
Do let me know if there's anything I can do to help investigate this. I'm curious myself to see what's causing this. -Jaikiran On 13/12/17 2:56 AM, Stefan Bodewig wrote: On 2017-12-12, Stefan Bodewig wrote: On 2017-12-12, Jaikiran Pai wrote: So the one final test that

Re: Build failed in Jenkins: Ant-Build-Matrix-1.9.x-Linux » JDK 1.6 (latest) #134

2017-12-13 Thread Jaikiran Pai
So we have now had 2 runs of this job failing with a JVM crash: Run 133 [exec] [au:antunit] Build File: [exec] [au:antunit] Tests run: 4, Failures: 0, Errors:

Re: Github ant repo now integrated with Jenkins for pull request testing

2017-12-13 Thread Jaikiran Pai
On 12/12/17 8:05 PM, Jaikiran Pai wrote: The next few days, I'll probably try and see if I can get a Linux based job to run alongside this Windows job for PRs. We now have a Linux one too for the PRs https://builds.apache.org/job/Ant%20Github-PR-Linux/. It has the same characteristi

Re: Build failed in Jenkins: Ant-Build-Matrix-1.9.x-Linux » JDK 1.6 (latest) #134

2017-12-13 Thread Jaikiran Pai
It's back to normal [1], so the crash seems to be specific to certain nodes on Jenkins, for Java 6. I don't plan to look more into this. [1] https://builds.apache.org/job/Ant-Build-Matrix-1.9.x-Linux/jdk=JDK%201.6%20(latest)/135/ -Jaikiran On 13/12/17 8:40 PM, Jaikiran Pai wrot

Ant support for users who use JUnit5

2017-12-14 Thread Jaikiran Pai
I've started some experiments in adding support for the recently released JUnit5 [1] in Ant. I don't mean using JUnit5 for test cases written within our Ant project, instead I am talking about allowing users to use a Ant task to be able to run JUnit5 based test cases as requested here [2]. Be

Re: Ant support for users who use JUnit5

2017-12-14 Thread Jaikiran Pai
by changing the internal implementation detail of this task (and maybe removing support for certain attributes). Either way, I would still like to hear others thoughts on this. -Jaikiran On 14/12/17 3:39 PM, Jaikiran Pai wrote: I've started some experiments in adding support for the rec

Re: Ant support for users who use JUnit5

2017-12-15 Thread Jaikiran Pai
Thank you. I'm moving ahead with the new proposed task. Hopefully I should be able to have something functional in a few days. -Jaikiran On 14/12/17 5:14 PM, Stefan Bodewig wrote: On 2017-12-14, Jaikiran Pai wrote: With that context, I would like to explain what I have attempted so fa

Re: ant git commit: logs say "link has been created", is it a timing issue?

2017-12-19 Thread Jaikiran Pai
The interesting bit from the logs that you enabled for investigating this appears to be the contents in the "recorded.links" properties file that gets created in the "test-record" target: #listing properties#Tue Dec 19 09:28:22 UTC 2017 dirlink=/home/jenkins/jenkins-slave/workspace/Ant-Build-Ma

Re: ant git commit: disable a bunch of caches, just so we've tried that as well

2017-12-19 Thread Jaikiran Pai
That was it! :) The same old canonical path cache. Looking at the JDK code, I still am not sure which exact code path triggers this stale/invalid cache in this specific case, but apparently it does. [exec] [junit] Testsuite: org.apache.tools.ant.taskdefs.optional.unix.SymlinkTest [ex

Re: ant git commit: disable a bunch of caches, just so we've tried that as well

2017-12-19 Thread Jaikiran Pai
On 19/12/17 5:13 PM, Jaikiran Pai wrote: Looking at the JDK code, I still am not sure which exact code path triggers this stale/invalid cache in this specific case, but apparently it does. Now that we know the canonical path cache is playing a role, I think the only way this issue makes

Re: [GitHub] ant pull request #:

2017-12-20 Thread Jaikiran Pai
No specific reason, just that I'm more used to using the javadoc variant of @deprecated since it allows explaining what's deprecated and why. I have now added the @Deprecated annotation too and pushed a commit. -Jaikiran On 20/12/17 11:08 PM, twogee wrote: Github user twogee commented on the

delete task with a wildcard "file"

2017-12-20 Thread Jaikiran Pai
Branch: refs/heads/master Commit: ca91b859f190598729613db4536a24f708eeb20b Parents: 1a2c33f Author: Jaikiran Pai Authored: Thu Dec 21 10:20:59 2017 +0530 Committer: Jaikiran Pai Committed: Thu Dec 21 10:20:59 2017 +0530 -- build.xml | 6

Re: delete task with a wildcard "file"

2017-12-20 Thread Jaikiran Pai
On 21/12/17 10:42 AM, Stefan Bodewig wrote: On 2017-12-21, Jaikiran Pai wrote: I committed this change below, to use a resource collection to allow the build to pass, which had started failing on Windows, after I did a recent change to the delete task to use Java 7 java.nio.file.Files API

Re: Ivy-2.5.0

2018-01-08 Thread Jaikiran Pai
Hi Jan, My efforts to resolve IVY-1485 have taken longer than I expected, mainly due to not finding enough time to sort it out. A few weekends I tried to focus on this, with my local WIP changes, I ran into merge issues with the latest upstream changes. I resolved them then and continued with

Re: Ivy-2.5.0

2018-01-09 Thread Jaikiran Pai
Thanks Maarten, I'll look this. -Jaikiran On 09/01/18 5:53 PM, Maarten Coene wrote: The change to the URLHandler class (TimoutConstraint) is also backwards incompatible.The IvyIdea plugin (IntelliJ) breaks on this which contains an extension of AbstractURLHandler. I didn't look into it yet,

Re: Ant Release Process

2018-01-19 Thread Jaikiran Pai
A bit late to the discussion. I just finished going through the release instructions. It's a lengthy process (understandably). Having been involved in releases of some internal projects, I do not see anything out the ordinary in these steps. Coming to the artifact signing step, which is what t

Re: Java 9 test failures

2018-01-23 Thread Jaikiran Pai
A brief look suggests that there's some underlying exception originating from JAI library. For some reason, this test isn't included in the tests that get run as part of our regular Jenkins builds. I'm not sure if that's intentional, but I haven't looked at the build file in detail to be sure.

Re: [PATCH]

2018-01-24 Thread Jaikiran Pai
Hi Adam, The mailing list strips off the attachments, so your patch didn't come through. In general, can you instead please create a bugzilla issue here https://bz.apache.org/bugzilla/enter_bug.cgi?product=Ant and explain the issue you were running into (including the version of Ant you are us

Re: Cutting new releases?

2018-01-26 Thread Jaikiran Pai
On 26/01/18 11:15 PM, Stefan Bodewig wrote: Does anybody feel either of the two branches isn't stable enough or is anybody currently working on/looking into soemthing that should delay releases? I have been working on support for JUnit5 and incidentally was about to create a initial PR for re

Re: Ant support for users who use JUnit5

2018-01-26 Thread Jaikiran Pai
sk. (Few other minor enhancements here and there and any user feedback reports) For those of you curious to see what the task usage is going to look like, here's an example[2] build file which shows its many usages. That file will be cleaned up a bit, before I send a PR for review/merge.

Re: Ant support for users who use JUnit5

2018-01-26 Thread Jaikiran Pai
One minor but important detail - this feature/task will only be available in the 1.10.x releases (whichever release we decide to include this in) and won't be available in 1.9.x releases of Ant. -Jaikiran On 27/01/18 8:40 AM, Jaikiran Pai wrote: Here's an update on where this

Re: Cutting new releases?

2018-01-26 Thread Jaikiran Pai
I just remembered - we probably have to investigate that image task test failure on Java 9 and see if its some setup issue or whether that task is genuinely broken against that runtime. I haven't yet found the time to dig deeper on that one. -Jaikiran On Friday, January 26, 2018, Stefan Bodewig

Re: ant-ivy git commit: IVY-1569 Avoid reflection warnings (or worse) in Java 9+

2018-02-04 Thread Jaikiran Pai
On 02/02/18 11:49 PM, gin...@apache.org wrote: Repository: ant-ivy Updated Branches: refs/heads/master 1d3567f30 -> 7ebc8107a IVY-1569 Avoid reflection warnings (or worse) in Java 9+ +private static int getJavaVersion() { +// See https://docs.oracle.com/javase/8/docs/technot

Re: [VOTE] Release Ant 1.9.10 based on RC1

2018-02-04 Thread Jaikiran Pai
+1. - Downloaded the binary .tar.gz. Installed it and checked the directories/files - Setup the ANT_HOME to point to this and ran existing projects using this version. All went fine. - Basic checks on the manuals, WHATSNEW and other files. All look good. - Downloaded the source .tar.gz. Ch

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz and installed locally. Setup ANT_HOME to this new version. - Ran some existing projects against this new version - Checked some documentation in the manual. Tested the projects using this version of Ant against both Java 8 and Java 9. -Jaikiran On 03/02/18

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-05 Thread Jaikiran Pai
I agree. -1. On a related note, I don't think we should be doing any of these commits especially when there's a RC out which we plan to release. IMO, only blocker issues need to be addressed when the RC is out. -Jaikiran On 06/02/18 1:41 AM, Stefan Bodewig wrote: Generate manifest files an

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-06 Thread Jaikiran Pai
Just to be clear, my -1 was meant for both this commit as well as a subsequent commit where some specific jars have been tagged as JPMS modules. I think adding this automatic module names just for the sake of it isn't a good thing. -Jaikiran On 06/02/18 9:38 AM, Jaikiran Pai wrote: I

Re: github PR builds

2018-02-06 Thread Jaikiran Pai
The PR build on Jenkins is backed by the github PR integration plugin[1]. One of the features of that plugin is to prevent some malicious/rogue PR (imagine someone creating a PR with code which does some odd things with the host on which it runs) being auto-triggered against the Jenkins hosts.

Re: github PR builds

2018-02-06 Thread Jaikiran Pai
, Jaikiran Pai wrote: The PR build on Jenkins is backed by the github PR integration plugin[1]. One of the features of that plugin is to prevent some malicious/rogue PR (imagine someone creating a PR with code which does some odd things with the host on which it runs) being auto-triggered against the

Re: Release Notes for 1.10.2 and 1.9.10

2018-02-06 Thread Jaikiran Pai
Maybe the new task is worth highlighting. But other than that I don't have anything specific. -Jaikiran On 06/02/18 11:18 PM, Stefan Bodewig wrote: Hi all as you can witness in https://svn.apache.org/viewvc/ant/site/ant/sources/antnews.xml?r1=1823368&r2=1823367&pathrev=1823368 I don't reall

Re: Ivy-2.5.0

2018-02-07 Thread Jaikiran Pai
Maarten, I just pushed a change to Ivy upstream to not force existing implementations of this URLHandler to understand timeout constraints and yet have the feature available for other implementations. When you get a chance, can you please try the IvyIdea plugin build/test with the latest Ivy an

Re: Ivy-2.5.0

2018-02-08 Thread Jaikiran Pai
release. We have a good amount of bug fixes that have been done since 2.4.0 and I think we should start looking at what it takes to do the release formalities. -Jaikiran On 09/01/18 12:29 PM, Jaikiran Pai wrote: Hi Jan, My efforts to resolve IVY-1485 have taken longer than I expected, mainly

Re: github PR builds

2018-02-08 Thread Jaikiran Pai
On 06/02/18 10:10 PM, Stefan Bodewig wrote: On 2018-02-06, Jaikiran Pai wrote: The PR build on Jenkins is backed by the github PR integration plugin[1]. One of the features of that plugin is to prevent some malicious/rogue PR (imagine someone creating a PR with code which does some odd things

Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
Recently a couple of bugs have been reported around mapped resources where we end up in NullPointerExceptions in various places[1][2]. As noted in [1], it needs a fix at a central place and I think I was able to fix the root cause as part of this commit[3] that I did an hour or so back. However

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
On 09/02/18 2:47 PM, Dominique Devienne wrote: On Fri, Feb 9, 2018 at 10:06 AM, Jaikiran Pai wrote: I need some inputs on how we should go about this specific change/test? Should this test continue to expect a exception or is it fine to expect that target to complete cleanly (without copying

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
Sure Stefan. -Jaikiran On 09/02/18 11:00 PM, Stefan Bodewig wrote: Jaikiran, just to avoid duplicate work, I'm currently running tests on the 1.9.x branch where I fix a bunch a FileNameMapper implementations that wouldn't handle null sourceFileNames (which could happen for resources that retu

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
Thanks everyone for the inputs. Based on those, I have now updated the test to not expect a build failure exception and also have updated our release notes to mention this change in behaviour. -Jaikiran On 09/02/18 11:00 PM, Stefan Bodewig wrote: Jaikiran, just to avoid duplicate work, I'm

Include user mailing list for RC release?

2018-02-09 Thread Jaikiran Pai
Our recent release of Ant showed up a major issue[1] which impact Ant users. The issue was found almost as soon as Ant was released, thanks to the user upgrading to this newer version. I think this is an issue which could have been caught before the release, in the RC, if more people tested the

Re: Need a Second Pair of Eyes

2018-02-13 Thread Jaikiran Pai
Hi Stefan, You are right. The change introduces a different behaviour than what was there before. Just to be extra sure that we indeed are reading it right, I added a (dummy) test case in my personal repo, which compares the previous logic and the new logic and it does shows that the change i

Re: Need a Second Pair of Eyes

2018-02-13 Thread Jaikiran Pai
I forgot to add that, as you note, as a result of the change, the new created path will retain all elements from destPath that aren't in dependClassPath, which is unlike the behaviour before the change. -Jaikiran On 14/02/18 9:59 AM, Jaikiran Pai wrote: Hi Stefan, You are right. The c

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
builds.apache.org/job/Ant-Build-Jaikiran/ws/manual/Tasks/junitlauncher.html [3] https://github.com/apache/ant/pull/60/files#diff-f985f89ce4779eff2cdcf164d09d5396R308 -Jaikiran On 27/01/18 8:40 AM, Jaikiran Pai wrote: Here's an update on where this effort now stands. As of yesterday,

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
regressions that we have found in our latest releases. -Jaikiran On 15/02/18 7:21 PM, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found h

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
I just realized that the manual that I linked in my mail isn't accessible to everyone. So here's an alternative link to the same https://home.apache.org/~jaikiran/temp_workspace/manual/Tasks/junitlauncher.html -Jaikiran On 15/02/18 7:21 PM, Jaikiran Pai wrote: I'm now done w

Re: Ant support for users who use JUnit5

2018-02-17 Thread Jaikiran Pai
On 17/02/18 12:51 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would suggest rea

Re: New Release(s)?

2018-02-18 Thread Jaikiran Pai
I am in favour of both a 1.10.3 and 1.9.11 release. -Jaikiran On 18/02/18 3:07 PM, Stefan Bodewig wrote: Hi all https://bz.apache.org/bugzilla/show_bug.cgi?id=62086 is a serious regression in 1.10.2 and it has been fixed in master by now. The 1.9.x branch has never been affected. By now I ha

Ivy release this month?

2018-02-18 Thread Jaikiran Pai
Hello everyone, Is there anything I can help with to start off and complete the Ivy release, hopefully this month? As I noted in the dev list mail, I don't plan to include the fix for https://issues.apache.org/jira/browse/IVY-1485 in this release and instead try and tackle it after that. There ar

Re: Ant support for users who use JUnit5

2018-02-18 Thread Jaikiran Pai
On 19/02/18 1:37 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would suggest rea

Re: Ant support for users who use JUnit5

2018-02-23 Thread Jaikiran Pai
On 19/02/18 9:23 AM, Jaikiran Pai wrote: On 19/02/18 1:37 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: We have 3 pre-defined formatters all of which are capable of receiving this streamed sysout/syserr data. Each of these do _not_ hold on to this sysout/syserr data in-memory

Ivy release instructions

2018-02-27 Thread Jaikiran Pai
In order to move towards a release soon, I decided to come up with an initial set of instructions that we might have to follow to generate the release. Most of the instructions have been borrowed from Ant's release process. Furthermore, the instructions are based on my checking out the release

Re: Ivy release this month?

2018-02-27 Thread Jaikiran Pai
- https://github.com/apache/ant-ivy/pull/67 (a one-liner; anybody sees some side effects?) I don't understand the issue. Is this a documented way of using Ivy or why would anybody expect it to be possible to invoke Ant via the Ivy jar? Somebody was interested enough to open a JIRA issu

Re: ant-ivy git commit: initial WIP version of release instructions to follow for releasing Ivy

2018-02-27 Thread Jaikiran Pai
http://git-wip-us.apache.org/repos/asf/ant-ivy/commit/1a19f2f8 > > Tree: http://git-wip-us.apache.org/repos/asf/ant-ivy/tree/1a19f2f8 > > Diff: http://git-wip-us.apache.org/repos/asf/ant-ivy/diff/1a19f2f8 > > > > Branch: refs/heads/master > > Commit: 1a19f2f836

Re: Ant 1.9.10 and Ivy

2018-02-27 Thread Jaikiran Pai
I'll grep through the sources and revert all changes to clone signatures unless anybody else beats me to it. Done https://github.com/apache/ant/commit/2e788849136bfd75e88ce0d959810f1191d43a33 -Jaikiran - To unsubscribe, e-m

Re: ant-ivy git commit: initial WIP version of release instructions to follow for releasing Ivy

2018-02-28 Thread Jaikiran Pai
I read through it and (obviously) it covers the necessary details. So my new doc that I committed isn't needed. As for automating/changing things in that doc, I think it's something one of us can do once we try out that doc for this release. -Jaikiran On 27/02/18 8:12 PM, Ja

Re: Ant test failures on Java 9

2018-02-28 Thread Jaikiran Pai
I just tried locally both with Java 8 and 9: java version "9.0.1" Java(TM) SE Runtime Environment (build 9.0.1+11) Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode) They pass for me: [au:antunit] Tests run: 26, Failures: 0, Errors: 0, Time elapsed: 9.175 sec [au:antunit] Target: t

Ant nightly Jenkins job

2018-03-01 Thread Jaikiran Pai
Would it be OK if I redo the Ant nightly jenkins job[1] to be a bit more useful and publish an actual nightly binary, for users to try out if they wish to? [1] https://builds.apache.org/job/Ant_Nightly/ -Jaikiran - To unsubs

Ivy old docs removed - documentation now resides under asciidoc

2018-03-07 Thread Jaikiran Pai
A while back we moved Ivy's documentation to Asciidoc. That automated migration, thanks mainly to Nicolas, went off fine and we fixed whatever issues we discovered in the migrated docs over a period of time. At this point, the previous HTML and xooki based documentation is no longer needed. So

<    1   2   3   4   5   6   >