[GitHub] [ant] keithc-ca commented on pull request #194: Names end before the first NULL (not the last)

2022-11-28 Thread GitBox
keithc-ca commented on PR #194: URL: https://github.com/apache/ant/pull/194#issuecomment-1329179830 That's an interesting idea, but it has the potential to misidentify the end of a multi-byte encoding. For example, `"Ā!"` = `"\u0100!"` is encoded by UTF16 as { 1, 0, 0, 33 }. The null se

[GitHub] [ant] bodewig commented on pull request #194: Names end before the first NULL (not the last)

2022-11-28 Thread GitBox
bodewig commented on PR #194: URL: https://github.com/apache/ant/pull/194#issuecomment-1330216852 Good catch, thank you. I could try to turn the byte array into a string, catch the exception and then keep searching for encoded NULs later. But even then it might just fail for so