[GitHub] [ant] kleini commented on pull request #186: Fix integer overflow when parsing SOURCE_DATE_EPOCH

2022-05-20 Thread GitBox
kleini commented on PR #186: URL: https://github.com/apache/ant/pull/186#issuecomment-1132665670 We're having an issue, with this, too. [tstamp] Honouring environment variable SOURCE_DATE_EPOCH which has been set to 1651903417 Date of 12/12/1969 07:10 PM results in negative

[GitHub] [ant] jaikiran commented on pull request #186: Fix integer overflow when parsing SOURCE_DATE_EPOCH

2022-05-20 Thread GitBox
jaikiran commented on PR #186: URL: https://github.com/apache/ant/pull/186#issuecomment-1132923161 > I've added a test case that demonstrates the issue. Test case is more complex than the actual fix. Does it mean I have to sign Apache CLA? I have not signed it yet. Hello @mizdebs

[GitHub] [ant] jaikiran closed pull request #186: Fix integer overflow when parsing SOURCE_DATE_EPOCH

2022-05-20 Thread GitBox
jaikiran closed pull request #186: Fix integer overflow when parsing SOURCE_DATE_EPOCH URL: https://github.com/apache/ant/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [ant] jaikiran commented on pull request #186: Fix integer overflow when parsing SOURCE_DATE_EPOCH

2022-05-20 Thread GitBox
jaikiran commented on PR #186: URL: https://github.com/apache/ant/pull/186#issuecomment-1133509843 I've received confirmation that CLA is not a must. I've also tested your changes in this PR and they look good and I've now merged it. Thank you for this fix and the test case and apologies fo