+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
On 2021-09-30, Jaikiran Pai wrote:
> This release is mainly a bug fix release and the exact changes are
> noted in
> https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. Of
> particular interest is the relatively minor bug fix in the javadoc
> task which is necessary for it to wo
bodewig commented on a change in pull request #164:
URL: https://github.com/apache/ant/pull/164#discussion_r720811236
##
File path: src/main/org/apache/tools/ant/taskdefs/Javac.java
##
@@ -910,7 +910,7 @@ public boolean getNowarn() {
*/
public ImplementationSpecificA
bodewig commented on pull request #164:
URL: https://github.com/apache/ant/pull/164#issuecomment-932924639
Thank you @arturobernalg but I'm afraid this is a change that is not
backwards compatible at all so we cannot accept it.
--
This is an automated message from the Apache Git Service.
bodewig commented on a change in pull request #162:
URL: https://github.com/apache/ant/pull/162#discussion_r720811564
##
File path: src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java
##
@@ -294,7 +294,7 @@ public void send() {
? new InternetAddress(ad
bodewig commented on a change in pull request #163:
URL: https://github.com/apache/ant/pull/163#discussion_r720811997
##
File path: src/main/org/apache/tools/ant/taskdefs/AbstractJarSignerTask.java
##
@@ -381,7 +381,7 @@ protected void setCommonOptions(final ExecTask cmd) {
bodewig commented on pull request #163:
URL: https://github.com/apache/ant/pull/163#issuecomment-932930381
This is a huge change when it comes to the number of lines touched. When
faced with such a big change I always fear I may overlook something subtle.
Personally I don't believe m
bodewig commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-932931398
There might be a way to reduce the code duplication between the two mailer
classes, but that can be done as a refactoring later. Also we'll need a new POM
and a new artifact to publis
arturobernalg commented on pull request #163:
URL: https://github.com/apache/ant/pull/163#issuecomment-932933258
> This is a huge change when it comes to the number of lines touched. When
faced with such a big change I always fear I may overlook something subtle.
>
> Personally I don
arturobernalg closed pull request #163:
URL: https://github.com/apache/ant/pull/163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
arturobernalg commented on a change in pull request #162:
URL: https://github.com/apache/ant/pull/162#discussion_r720815321
##
File path: src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java
##
@@ -294,7 +294,7 @@ public void send() {
? new InternetAddr
arturobernalg closed pull request #164:
URL: https://github.com/apache/ant/pull/164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
arturobernalg commented on pull request #164:
URL: https://github.com/apache/ant/pull/164#issuecomment-932934366
> Thank you @arturobernalg but I'm afraid this is a change that is not
backwards compatible at all so we cannot accept it.
HI @bodewig
Ok, close the PR. maybe for a ne
bodewig commented on pull request #163:
URL: https://github.com/apache/ant/pull/163#issuecomment-932934721
@arturobernalg I'm by far not the only Ant committer, so please don't feel
forced to close a PR just because I comment in an unfavorable way.
--
This is an automated message from th
bodewig commented on pull request #162:
URL: https://github.com/apache/ant/pull/162#issuecomment-932934965
thank you @arturobernalg Currently there is a release vote underway and I
don't want to disturb things by changing `master` before it is done.
--
This is an automated message from t
bodewig commented on pull request #164:
URL: https://github.com/apache/ant/pull/164#issuecomment-932935464
for historical reasons Ant is not following semantic versioning, so the next
"major release" would be 1.11.0. Having said that I'm not aware of anybody
planning to create such a thing
arturobernalg commented on pull request #162:
URL: https://github.com/apache/ant/pull/162#issuecomment-932936163
> thank you @arturobernalg Currently there is a release vote underway and I
don't want to disturb things by changing `master` before it is done.
Completely agree. This is
twogee commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-933173752
Thanks @bodewig, I missed the POM part. There's no need for a separate POM:
I propose bumping the version in the current POM and adding a profile that
overrides the dependencies in cas
bodewig commented on pull request #161:
URL: https://github.com/apache/ant/pull/161#issuecomment-933179077
Personally I'd prefer two separate jars and two separate POMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
19 matches
Mail list logo
