[GitHub] [ant] bodewig commented on pull request #138: Update the optional dependencies

2021-10-02 Thread GitBox
bodewig commented on pull request #138: URL: https://github.com/apache/ant/pull/138#issuecomment-932727849 Thank you @twogee - do you think you could split the Jakarta Mailer support changes from the other changes? The changes to `ClasspathUtils` seem to be completely unrelated to ei

[GitHub] [ant] twogee commented on pull request #138: Update the optional dependencies

2021-10-02 Thread GitBox
twogee commented on pull request #138: URL: https://github.com/apache/ant/pull/138#issuecomment-932738776 Thanks, @bodewig, and sorry about missing the extraneous changes. I will open a new PR for changes re Jakarta Mail specifically. The change to `ClasspathUtils` is related to an att

[GitHub] [ant] twogee opened a new pull request #161: Use Jakarta EE

2021-10-02 Thread GitBox
twogee opened a new pull request #161: URL: https://github.com/apache/ant/pull/161 Java Mail became Jakarta Mail, and Ant should prepare for EOL of the former. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [VOTE] Release Apache Ant 1.10.12 based on RC1

2021-10-02 Thread Jaikiran Pai
+1 - Downloaded the .tar.gz binary - Checked the NOTICE file and some random manuals - Built internal projects using Java 8 and this version of Ant - Built some sample projects with Java 17 and this version Ant All looks fine. -Jaikiran On 30/09/21 8:28 am, Jaikiran Pai wrote: I've created

Re: [VOTE] Release Apache Ant 1.10.12 based on RC1

2021-10-02 Thread Gavin McDonald
Hi. On Sat, Oct 2, 2021 at 2:28 PM Jaikiran Pai wrote: > +1 > > - Downloaded the .tar.gz binary > Please not that the ASF nor its projects release Binaries. (They are provided to users as a convenience) We also do not vote on releases based on Binaries. The vote should be based on whether or n

[GitHub] [ant] arturobernalg opened a new pull request #162: Use Bulk operation instead of iteration.

2021-10-02 Thread GitBox
arturobernalg opened a new pull request #162: URL: https://github.com/apache/ant/pull/162 Some operations inside loops that could be replaced with a bulk method. Bulk methods are shorter -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [ant] arturobernalg opened a new pull request #164: Use inner class as static.

2021-10-02 Thread GitBox
arturobernalg opened a new pull request #164: URL: https://github.com/apache/ant/pull/164 Its not require access to an enclosing instance's non-public fields and methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u