jglick commented on pull request #151:
URL: https://github.com/apache/ant/pull/151#issuecomment-886865749
I barely recall 8fdf272627418e1e55adcfe8a52feb9125515be0 and do not have any
special knowledge of the surrounding code here. Sounds OK offhand. Is it
reasonable to add test coverage fo
basil commented on pull request #151:
URL: https://github.com/apache/ant/pull/151#issuecomment-886878900
Probably, but I lack the time and interest to add a test. As I wrote above,
I tested this in Jenkins and have convinced myself the fix is correct.
--
This is an automated message from
jaikiran commented on pull request #151:
URL: https://github.com/apache/ant/pull/151#issuecomment-887177009
Hello @basil, thank you for your detailed analysis and explanation of your
changes. This looks good to me, plus since Jesse too has had a look at this
gives me additional confidence
jaikiran merged pull request #151:
URL: https://github.com/apache/ant/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant
