Bug report for Ant [2021/07/25]

2021-07-25 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

[GitHub] [ant] basil commented on pull request #152: Call correct method to get parent from getRootLoader()

2021-07-25 Thread GitBox
basil commented on pull request #152: URL: https://github.com/apache/ant/pull/152#issuecomment-886236175 Closing this PR, as I don't think it makes sense anymore. The `getRootLoader()` method is only invoked when this class is running in "isolated" mode, which is documented as follows:

[GitHub] [ant] basil closed pull request #152: Call correct method to get parent from getRootLoader()

2021-07-25 Thread GitBox
basil closed pull request #152: URL: https://github.com/apache/ant/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.ap

[GitHub] [ant] basil closed pull request #149: Ant doesn't call the superclass constructor and pass in the specified parent classloader

2021-07-25 Thread GitBox
basil closed pull request #149: URL: https://github.com/apache/ant/pull/149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.ap

[GitHub] [ant] basil commented on pull request #149: Ant doesn't call the superclass constructor and pass in the specified parent classloader

2021-07-25 Thread GitBox
basil commented on pull request #149: URL: https://github.com/apache/ant/pull/149#issuecomment-886236220 Closing in favor of #151. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [ant] basil commented on pull request #151: findResources(String, boolean) can unnecessarily search the parent

2021-07-25 Thread GitBox
basil commented on pull request #151: URL: https://github.com/apache/ant/pull/151#issuecomment-886238534 To summarize, the root cause of this problem is the `|| parent != getParent()` logic and this associated comment: > Note: could cause overlaps in case ClassLoader.this.parent has