[GitHub] [ant] jaikiran commented on pull request #149: Ant doesn't call the superclass constructor and pass in the specified parent classloader

jaikiran commented on pull request #149: URL: https://github.com/apache/ant/pull/149#issuecomment-883968931 Hello @basil, although this change looks straightforward and seems to have been in-use in Jenkins for 7 odd years, I will need some inputs from others before merging this change.

[GitHub] [ant] jaikiran commented on a change in pull request #149: Ant doesn't call the superclass constructor and pass in the specified parent classloader

jaikiran commented on a change in pull request #149: URL: https://github.com/apache/ant/pull/149#discussion_r673741534 ## File path: src/main/org/apache/tools/ant/AntClassLoader.java ## @@ -297,6 +298,7 @@ public AntClassLoader() { *elements are set up to

[GitHub] [ant] basil commented on pull request #149: Ant doesn't call the superclass constructor and pass in the specified parent classloader

basil commented on pull request #149: URL: https://github.com/apache/ant/pull/149#issuecomment-884318912 Thanks for the quick reply @jaikiran! The bug you linked to is very helpful. I am pleased to report that the original script given by Kohsuke in [this comment](https://issues.jenkins.io

[GitHub] [ant] basil opened a new pull request #151: Use the correct parent in findResources(String, boolean)

basil opened a new pull request #151: URL: https://github.com/apache/ant/pull/151 See [#149 (comment)](https://github.com/apache/ant/pull/149#issuecomment-884318912). Amends `findResources(String, boolean)` to invoke the correct method to get the parent. The `getParent()` method returns t

[GitHub] [ant] basil opened a new pull request #152: Call correct method to get parent from getRootLoader()

basil opened a new pull request #152: URL: https://github.com/apache/ant/pull/152 See [#149 (comment)](https://github.com/apache/ant/pull/149#issuecomment-884318912). Similar to what #151 did for `findResources(String, boolean)`, this PR amends `getRootLoader()` to invoke the correct meth

[GitHub] [ant] basil commented on a change in pull request #151: Use the correct parent in findResources(String, boolean)

basil commented on a change in pull request #151: URL: https://github.com/apache/ant/pull/151#discussion_r674341363 ## File path: src/main/org/apache/tools/ant/AntClassLoader.java ## @@ -982,26 +979,21 @@ protected URL findResource(final String name) { * * @param na

[GitHub] [ant] basil commented on a change in pull request #151: findResources(String, boolean) can unnecessarily search the parent

basil commented on a change in pull request #151: URL: https://github.com/apache/ant/pull/151#discussion_r674341363 ## File path: src/main/org/apache/tools/ant/AntClassLoader.java ## @@ -982,26 +979,21 @@ protected URL findResource(final String name) { * * @param na