bodewig commented on pull request #141:
URL: https://github.com/apache/ant/pull/141#issuecomment-739484127
I like the approach of moving the logic for fixing the lat lines to a
separate filter. Kudos for adding tests ;-)
A different approach could be to allow an alternative set of fi
TheConstructor commented on pull request #141:
URL: https://github.com/apache/ant/pull/141#issuecomment-739532616
I briefly thought about that, but thought it would at another layer of
complexity. In the end you could wrap a into
another without `filterbeforeconcat`, if you want to filte
TheConstructor edited a comment on pull request #141:
URL: https://github.com/apache/ant/pull/141#issuecomment-739532616
I briefly thought about that, but thought it would add another layer of
complexity. In the end you could wrap a ``
into another `` without `filterbeforeconcat`, if you w
bodewig commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-739559178
You removed the `volatile` attribute `cached´ from `ResourceList`. Th way
code is structured now there is a race-condition where one thread my be using a
cache that hasn't been initia
bodewig commented on pull request #141:
URL: https://github.com/apache/ant/pull/141#issuecomment-739559350
Yes, you are right.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TheConstructor commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-739563468
I checked that `cachedResources` is only ever accessed through `cache()`,
which is `synchronized`. Is this really a problem? Would declaring
`cachedResources` `volatile` and/or
bodewig commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-739723211
I completely overlooked `cache` was synchronized. Since all read an write
operations on `cachedResources` are synchronized, I don't think a problem
exists there. Sorry.
bodewig merged pull request #140:
URL: https://github.com/apache/ant/pull/140
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
bodewig merged pull request #141:
URL: https://github.com/apache/ant/pull/141
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
TheConstructor commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-739739737
@bodewig Thank you again for looking into this and my other PR!
This is an automated message from the Apache Gi
10 matches
Mail list logo
