[GitHub] [ant] don-vip commented on pull request #121: use displayName instead of legacyReportingName in xml reports

2020-11-29 Thread GitBox
don-vip commented on pull request #121: URL: https://github.com/apache/ant/pull/121#issuecomment-735396718 @jaikiran I tried https://ci-builds.apache.org/job/Ant/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/binaries/apache-ant-1.10.10alpha-bin.zip and got a different error:

[GitHub] [ant] don-vip edited a comment on pull request #121: use displayName instead of legacyReportingName in xml reports

2020-11-29 Thread GitBox
don-vip edited a comment on pull request #121: URL: https://github.com/apache/ant/pull/121#issuecomment-735396718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [ant] don-vip edited a comment on pull request #121: use displayName instead of legacyReportingName in xml reports

2020-11-29 Thread GitBox
don-vip edited a comment on pull request #121: URL: https://github.com/apache/ant/pull/121#issuecomment-735396718 @jaikiran I tried https://ci-builds.apache.org/job/Ant/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/binaries/apache-ant-1.10.10alpha-bin.zip and got a different er

[GitHub] [ant] don-vip commented on pull request #121: use displayName instead of legacyReportingName in xml reports

2020-11-29 Thread GitBox
don-vip commented on pull request #121: URL: https://github.com/apache/ant/pull/121#issuecomment-735423321 @jaikiran I was speaking a bit too fast, there's a minor problem, the test method is missing. For this example test: ```java class TaggingPresetPreferenceTestIT extends Abstract

[GitHub] [ant] bodewig commented on pull request #141: #64855 Add filterbeforeconcat option to Concat

2020-11-29 Thread GitBox
bodewig commented on pull request #141: URL: https://github.com/apache/ant/pull/141#issuecomment-735616994 @TheConstructor no, you've done all there is to do, many thanks. The silence is totally out fault, we just seem all to be busy right now. I'll find some time looking into this and #14

[GitHub] [ant] bodewig edited a comment on pull request #141: #64855 Add filterbeforeconcat option to Concat

2020-11-29 Thread GitBox
bodewig edited a comment on pull request #141: URL: https://github.com/apache/ant/pull/141#issuecomment-735616994 @TheConstructor no, you've done all there is to do, many thanks. The silence is totally our fault, we just seem all to be busy right now. I'll find some time looking into this