[GitHub] [ant] bodewig commented on a change in pull request #115: Remove duplicated code

2020-07-27 Thread GitBox
bodewig commented on a change in pull request #115: URL: https://github.com/apache/ant/pull/115#discussion_r460786692 ## File path: src/main/org/apache/tools/ant/listener/Log4jListener.java ## @@ -142,21 +142,17 @@ public void messageLogged(final BuildEvent event) { fi

[GitHub] [ant] bodewig commented on a change in pull request #115: Remove duplicated code

2020-07-27 Thread GitBox
bodewig commented on a change in pull request #115: URL: https://github.com/apache/ant/pull/115#discussion_r460787528 ## File path: src/main/org/apache/tools/ant/taskdefs/MacroInstance.java ## @@ -221,8 +221,6 @@ private String macroSubs(String s, Map macroMapping) {

[GitHub] [ant] bodewig commented on a change in pull request #115: Remove duplicated code

2020-07-27 Thread GitBox
bodewig commented on a change in pull request #115: URL: https://github.com/apache/ant/pull/115#discussion_r460788175 ## File path: src/main/org/apache/tools/ant/taskdefs/optional/jlink/ClassNameReader.java ## @@ -56,43 +56,40 @@ byte type = data.readByte();

[GitHub] [ant] bodewig commented on a change in pull request #115: Remove duplicated code

2020-07-27 Thread GitBox
bodewig commented on a change in pull request #115: URL: https://github.com/apache/ant/pull/115#discussion_r460788455 ## File path: src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java ## @@ -2671,27 +2664,24 @@ public void execute() throws BuildException { */

[GitHub] [ant] bodewig commented on a change in pull request #115: Remove duplicated code

2020-07-27 Thread GitBox
bodewig commented on a change in pull request #115: URL: https://github.com/apache/ant/pull/115#discussion_r460791697 ## File path: src/main/org/apache/tools/bzip2/BlockSort.java ## @@ -894,8 +893,8 @@ private void mainQSort3(final CBZip2OutputStream.Data dataShadow,

[GitHub] [ant] twogee commented on a change in pull request #115: Remove duplicated code

2020-07-27 Thread GitBox
twogee commented on a change in pull request #115: URL: https://github.com/apache/ant/pull/115#discussion_r460807226 ## File path: src/main/org/apache/tools/ant/listener/Log4jListener.java ## @@ -142,21 +142,17 @@ public void messageLogged(final BuildEvent event) { fin

[GitHub] [ant] twogee opened a new pull request #130: Correct javadoc

2020-07-27 Thread GitBox
twogee opened a new pull request #130: URL: https://github.com/apache/ant/pull/130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t