[GitHub] ant issue #79: Make DataType and Reference generic

2018-11-18 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/79 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/96/ ---

[GitHub] ant issue #79: Make DataType and Reference generic

2018-11-18 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/79 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/90/ --- --

[GitHub] ant issue #79: Make DataType and Reference generic

2018-11-18 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/79 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/97/ ---

[GitHub] ant issue #79: Make DataType and Reference generic

2018-11-18 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/79 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/91/ --- --

Re: Command line argument files

2018-11-18 Thread Stefan Bodewig
Hi Remko On 2018-11-15, Remko Popma wrote: > Would there be any interest in using picocli ( > https://github.com/remkop/picocli) as the command line parser in > `org.apache.tools.ant.Main`? Ant's core has zero dependencies and we value this property. > Picocli has support for @-files (https://p

Re: [3/3] ant git commit: Use try-with-resources

2018-11-18 Thread Stefan Bodewig
On 2018-11-17, wrote: in EchoXml > -} catch (BuildException e) { > -throw e; > -} catch (Exception e) { > +} catch (IOException e) { > throw new BuildException(e); before your change we'd wrap arbitrary RuntimeExceptions into BuildExceptions, aft

Re: [3/3] ant git commit: Use try-with-resources

2018-11-18 Thread Stefan Bodewig
On 2018-11-18, Stefan Bodewig wrote: > In Manifest >> /** Encoding to be used for JAR files. */ >> -public static final String JAR_ENCODING = "UTF-8"; >>>public static final Charset JAR_ENCODING = StandardCharsets.UTF_8; > chnages the type of a public constant which is not backwards

Re: Command line argument files

2018-11-18 Thread Matt Sicker
FWIW, picocli is small enough to simply shade into your project. We do it in Log4j with some CLI tooling that’s included. On Sun, Nov 18, 2018 at 09:19, Stefan Bodewig wrote: > Hi Remko > > On 2018-11-15, Remko Popma wrote: > > > Would there be any interest in using picocli ( > > https://github.