Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232665835
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/extension/ExtensionSet.java ---
@@ -34,8 +34,7 @@
*
* @ant.datatype name="extension-set"
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232666118
--- Diff: src/main/org/apache/tools/ant/types/AbstractFileSet.java ---
@@ -915,7 +920,7 @@ public String toString() {
@Override
public synchroni
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232667773
--- Diff: src/main/org/apache/tools/ant/types/DataType.java ---
@@ -196,24 +196,44 @@ public static void
pushAndInvokeCircularReferenceCheck(DataType dt,
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232667496
--- Diff: src/main/org/apache/tools/ant/types/ArchiveFileSet.java ---
@@ -574,11 +570,8 @@ public int getDirMode() {
* fileset if the project has been s
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232668570
--- Diff: src/main/org/apache/tools/ant/types/FileList.java ---
@@ -137,13 +144,10 @@ public void setFiles(String filenames) {
}
/**
-
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232668389
--- Diff: src/main/org/apache/tools/ant/types/FileList.java ---
@@ -98,6 +98,13 @@ public File getDir(Project p) {
return dir;
}
+
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232669102
--- Diff: src/main/org/apache/tools/ant/types/FilterSet.java ---
@@ -235,8 +235,8 @@ protected FilterSet(FilterSet filterset) {
*
* @return th
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232669259
--- Diff: src/main/org/apache/tools/ant/types/Path.java ---
@@ -721,7 +721,7 @@ public synchronized boolean isFilesystemOnly() {
* @return the passed in
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232669396
--- Diff: src/main/org/apache/tools/ant/types/PropertySet.java ---
@@ -424,8 +424,8 @@ private void addPropertyNames(Set names,
Map props) {
* referenc
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232669831
--- Diff: src/main/org/apache/tools/ant/types/TarFileSet.java ---
@@ -263,9 +273,7 @@ public Object clone() {
private void checkTarFileSetAttributesAllow
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/79
Apart from my comments this looks good to me, thanks!
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional comm
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/78#discussion_r232673446
--- Diff: src/tests/junit/org/apache/tools/ant/types/CharSetTest.java ---
@@ -0,0 +1,20 @@
+package org.apache.tools.ant.types;
+
+import org.apache.t
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/78
Both files need license headers. Other than that, looks good to me.
You envision this type to be used as argument type in `setEncoding`
overloads?
---
On 2018-11-08, wrote:
> +private static final Map fileSystemCaseSensitivity
> = new HashMap<>();
I understand it may be expensive to determine whether a filesystem is
case-sensitive, but I'm a bit hesitant about the cache as it never gets
cleared if things run for a long time.
Stefan
On 2018-11-11, wrote:
>+ * Construct a ReaderInputStream
>+ * for the specified Reader,
>+ * with the specified encoding.
>+ *
>+ * @param reader non-null Reader.
>+ * @param charsetnon-null Charset charset.
>+ */
>+public ReaderInputStream(Reader reader, C
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant/pull/78#discussion_r232795363
--- Diff: src/tests/junit/org/apache/tools/ant/types/CharSetTest.java ---
@@ -0,0 +1,20 @@
+package org.apache.tools.ant.types;
+
+import org.apache.to
Github user twogee commented on the issue:
https://github.com/apache/ant/pull/78
License headers added. Yes, it should be used with `setEncoding` (or in
some tasks `setCharset`). Now that I think about it image/imageio tasks have an
"encoding" attribute which is a misnomer. I'd like t
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/78
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/95/
---
Hi Stefan,
On 12/11/18 11:26 PM, Stefan Bodewig wrote:
> On 2018-11-08, wrote:
>
>> +private static final Map fileSystemCaseSensitivity
>> = new HashMap<>();
> I understand it may be expensive to determine whether a filesystem is
> case-sensitive, but I'm a bit hesitant about the cache as it
19 matches
Mail list logo
