On 2018-10-23, wrote:
> http://git-wip-us.apache.org/repos/asf/ant/blob/679a9422/src/main/org/apache/tools/ant/MagicNames.java
>+/**
>+ * Magic property that makes unit tests based on BuildFileTest
>+ * or BuildFileRule ignore externally set basedir
>+ * (typically by Surefire/Fa
On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote:
> On 2018-10-23, wrote:
>
> >
> http://git-wip-us.apache.org/repos/asf/ant/blob/679a9422/src/main/org/apache/tools/ant/MagicNames.java
>
> >+/**
> >+ * Magic property that makes unit tests based on BuildFileTest
> >+ * or BuildFileR
On Thu, 25 Oct 2018 at 09:05, Gintautas Grigelionis
wrote:
> On Wed, 24 Oct 2018 at 00:29, Gintautas Grigelionis <
> g.grigelio...@gmail.com> wrote:
>
>> On Tue, 23 Oct 2018 at 12:25, Stefan Bodewig wrote:
>>
>>> On 2018-10-20, Gintautas Grigelionis wrote:
>>>
>>> > I believe that in order to ex
Gintas, please allow me again to ask you to not commit code changes and
whitespace changes at the same time.
This diff consists of 920 lines, more than 800 of them are whitespace
changes that are completely unrelated to the commit message.
Stefan
-
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote:
>> I wonder whether it wouldn't be a good idea to create a separate class
>> for constants used during testing that lives in ant-testutil rather than
>> poluting the "magic names" of Ant.
> The pro
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/69
I haven't analyzed the changes in detail but things look good in general.
We agree the moved class is unlikely to cause a real problem but WHATSNEW
should talk about the changes in detail.
---
---
On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
> > On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote:
>
> >> I wonder whether it wouldn't be a good idea to create a separate class
> >> for constants used during testing that lives in ant-testuti
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
>> On 2018-10-28, Gintautas Grigelionis wrote:
>>> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote:
I wonder whether it wouldn't be a good idea to create a separate class
for constant
On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
> > On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
> >> On 2018-10-28, Gintautas Grigelionis wrote:
> >>> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig
> wrote:
>
> I wonder whether it wou
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote:
>> On 2018-10-28, Gintautas Grigelionis wrote:
>>> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 17:59, Stefan Bo
On 2018-10-28, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
>> On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote:
>>> On 2018-10-28, Gintautas Grigelionis wrote:
On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
>
On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
> > On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote:
> >> On 2018-10-28, Gintautas Grigelionis wrote:
> >>> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig
> wrote:
> On 2018-10-28, Gintautas
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote:
>> I guess I need to create a branch to either convince you it is possible
>> or convince me that it is not :-)
> No branch is necessary, just activate launcher tests; the effect will be
> the sam
On Sun, 28 Oct 2018 at 21:02, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
> > On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote:
>
> >> I guess I need to create a branch to either convince you it is possible
> >> or convince me that it is not :-)
>
> > No branch is neces
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 21:02, Stefan Bodewig wrote:
>> On 2018-10-28, Gintautas Grigelionis wrote:
>>> On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote:
I guess I need to create a branch to either convince you it is possible
or convince
> The tests for core fail for me (CommandlineJava) anyway. I think I've
> already said that running Ant's unit tests in Maven is a non-goal for me
> :-)
>
I'll have a closer look at it tomorrow, if you don't mind. Could you please
provide some details of your setup?
Even if running unit tests with
On 2018-10-28, Gintautas Grigelionis wrote:
>> The tests for core fail for me (CommandlineJava) anyway. I think I've
>> already said that running Ant's unit tests in Maven is a non-goal for me
>> :-)
> I'll have a closer look at it tomorrow, if you don't mind. Could you please
> provide some deta
> Thanks, I'll merge it to master, then.
>
I've notice in Nightly that Ant treats MagicTestNames as a test, too.
Would it make sense to add a test method, checking for documented
properties?
Gintas
18 matches
Mail list logo
