Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Gintautas Grigelionis
Thanks for reviewing, I hope Spliterators will do a better job. Gintas 2018-05-17 8:37 GMT+02:00 Jaikiran Pai : > I agree. Especially when it's being done on something like for archive > entries which can betoo many depending on the archive that is being dealt > with. > > -Jaikiran > > > > On 17

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Jaikiran Pai
To be honest, I don't think this deprecation/conversion change is good(including this recent commit whichintroduces a StreamUtils.enumerationAsStream(...)) To give you an example, the code that was previously present would (in most of the cases) get hold of an enumeration and would iterate ove

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Gintautas Grigelionis
I'm not quite sure that what you say was true "in most of the cases". Gintas 2018-05-18 6:52 GMT+02:00 Jaikiran Pai : > To be honest, I don't think this deprecation/conversion change is > good(including this recent commit whichintroduces a > StreamUtils.enumerationAsStream(...)) > > To give you

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Jaikiran Pai
If your objection is that I claimed that these qualify as "most of the cases" - I really don't know what else to say then. The original commit which did this change is this[1]. I haven't reviewed it fully, but the very first few changes that are done are these [2] [3] [4] [5][6]. Of course, th