Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28521960
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java o
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28522026
In
src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java:
In
src/main/org/apache/tools/ant/taskdefs/optiona
Hi
while reviewing some changes I realized DefaultInputHandler and
SecureInputHandler may create unexpected outcomes if System.in or
System.console() signal an end-of-stream and thus readLine/readPassword
return null.
The former will create an InputRequest with a null getInput() result
which may
On 2018-04-06, wrote:
> http://git-wip-us.apache.org/repos/asf/ant/blob/c3b91f90/src/main/org/apache/tools/ant/types/ArchiveFileSet.java
> --
> diff --git a/src/main/org/apache/tools/ant/types/ArchiveFileSet.java
> b/src/main/or
On 2018-04-09, Gintautas Grigelionis wrote:
> I was particularly unhappy about the root-property hack for an ancient
> deficiency in Surefire.
Could you please expand on this a bit?
> I consider my previous commits a sort of a groundwork for
> refactorisation of JUnit tests. Would you bear with
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28525288
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java on
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28525323
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java on
On Sun, Apr 8, 2018, 11:03 AM Stefan Bodewig wrote:
> On 2018-04-07, Jaikiran Pai wrote:
>
> > I don't mean to appear authoritative but I feel that these mass,
> > never-ending changes to various projects under the Ant umbrella,
> > related to formatting, coding style, whitespaces, syntax changes
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28526626
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java o
On 2018-04-11, Matt Benson wrote:
> On Sun, Apr 8, 2018, 11:03 AM Stefan Bodewig wrote:
>> We did have one big "cleanup" commit which has been the one that brought
>> us the regressions in 1.10.2 and I deeply regret not taking the time
>> reviewing the change back then.
> I'm pretty sure I was
On Wed, Apr 11, 2018, 8:25 AM Stefan Bodewig wrote:
> On 2018-04-11, Matt Benson wrote:
>
> > On Sun, Apr 8, 2018, 11:03 AM Stefan Bodewig wrote:
>
> >> We did have one big "cleanup" commit which has been the one that brought
> >> us the regressions in 1.10.2 and I deeply regret not taking the t
2018-04-11 6:25 GMT+00:00 Jaikiran Pai :´
> On 10/04/18 12:27 AM, Gintautas Grigelionis wrote:
>
>> I wrote earlier that I was about to review the unit tests.
>> I was particularly unhappy about the root-property hack for an ancient
>> deficiency in Surefire.
>>
> I checked some of the mail discus
The Junit task is printing a warning if it finds multiple versions of Ant in
the classpath of the unit tests. It seems it doesn’t do correctly the job if
the ant runtime is explicitly removed from the classpath.
Here the function which checks the classpath:
https://github.com/apache/ant/blob/mas
13 matches
Mail list logo
