Re: ant git commit: Use isEmpty() in tasks

2018-04-09 Thread Stefan Bodewig
On 2018-04-06, wrote: > http://git-wip-us.apache.org/repos/asf/ant/blob/73bda1fb/src/main/org/apache/tools/ant/taskdefs/BindTargets.java > -- > diff --git a/src/main/org/apache/tools/ant/taskdefs/BindTargets.java > b/src/main/or

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487214 In src/main/org/apache/tools/ant/Project.java: In src/main/org/apache/tools/ant/Project.java on line 1831: this changes the ou

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487270 In src/main/org/apache/tools/ant/XmlLogger.java: In src/main/org/apache/tools/ant/XmlLogger.java on line 210: the debugging co

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487413 In src/main/org/apache/tools/ant/taskdefs/Concat.java: In src/main/org/apache/tools/ant/taskdefs/Concat.java on line 597: Even

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487485 In src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java: In src/main/org/apache/tools/ant/taskdefs/compi

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487664 In src/main/org/apache/tools/ant/util/LazyHashtable.java: In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32:

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-09 Thread Nicolas Lalevée
Le 7 avr. 2018 à 14:13, Gintautas Grigelionis a écrit : > > I sense a personal attack using broad, generalised accusations :-) > Could we please stop the inflammatory comments and be more to the point? Please don’t. Nothing is personal here. Jaikiran used « we ». Even if you are the author of

Ivy release

2018-04-09 Thread Nicolas Lalevée
The last thread about a release has been stuck in the discussion about which PR, patch or Jira needed to be tackled before releasing. I suggest we just move forward with the current master. I volunteer to build a 2.5.0-rc1. Nicolas --

Re: Ivy release

2018-04-09 Thread Gintautas Grigelionis
2018-04-09 17:20 GMT+00:00 Nicolas Lalevée : > The last thread about a release has been stuck in the discussion about > which PR, patch or Jira needed to be tackled before releasing. I suggest we > just move forward with the current master. I volunteer to build a 2.5.0-rc1. > > Nicolas > +1; mayb

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-09 Thread Gintautas Grigelionis
2018-04-09 16:48 GMT+00:00 Nicolas Lalevée : > I have not been reading ant-dev lately, so I cannot comment much about the > last patches. For a while now I have not been involved much, but probably > the last reviews of patches bored me enough so I lost track of the dev > community entirely. > > N

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-09 Thread Gintautas Grigelionis
2018-04-08 16:13 GMT+00:00 Stefan Bodewig : > On 2018-04-07, Gintautas Grigelionis wrote: > > > Java is a language with the syntax that changes and tries to accomodate > new > > patterns that make programming more efficient. > > Some of the patterns you've been changign don't fall into this catego

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-09 Thread Nicolas Lalevée
> Le 9 avr. 2018 à 20:46, Gintautas Grigelionis a > écrit : > > 2018-04-09 16:48 GMT+00:00 Nicolas Lalevée : > >> I have not been reading ant-dev lately, so I cannot comment much about the >> last patches. For a while now I have not been involved much, but probably >> the last reviews of patc

Re: Ivy release

2018-04-09 Thread Jaikiran Pai
+1. Thanks Nicolas. -Jaikiran On Monday, April 9, 2018, Nicolas Lalevée wrote: > The last thread about a release has been stuck in the discussion about which PR, patch or Jira needed to be tackled before releasing. I suggest we just move forward with the current master. I volunteer to build a 2.

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28500962 In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java: In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line 9