[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172043778 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,295 @@ +package org.apache.tools.an

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172043835 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,295 @@ +package org.apache.tools.an

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172043964 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package org.apache.tools.ant.taskdefs.

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/60 Nice work! I don't see any reason not to merge this PR. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For addi

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172044509 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,295 @@ +package org.apache.tools.a

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172044665 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,295 @@ +package org.apache.tools.a

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172044717 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,295 @@ +package org.apache.tools.a

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/60 Thank you Stefan for the thorough review. I'll clean up the commits to squash them into one and do these minor final changes before merging. --- --

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172044906 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package org.apache.tools.ant.taskdefs