Recently a couple of bugs have been reported around mapped resources
where we end up in NullPointerExceptions in various places[1][2]. As
noted in [1], it needs a fix at a central place and I think I was able
to fix the root cause as part of this commit[3] that I did an hour or so
back. However
On Fri, Feb 9, 2018 at 10:06 AM, Jaikiran Pai
wrote:
> I need some inputs on how we should go about this specific change/test?
> Should this test continue to expect a exception or is it fine to expect
> that target to complete cleanly (without copying anything)?
>
What's the source of the NPE?
I
On 09/02/18 2:47 PM, Dominique Devienne wrote:
On Fri, Feb 9, 2018 at 10:06 AM, Jaikiran Pai
wrote:
I need some inputs on how we should go about this specific change/test?
Should this test continue to expect a exception or is it fine to expect
that target to complete cleanly (without copying
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/57
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
On Fri, Feb 9, 2018 at 11:05 AM, Jaikiran Pai
wrote:
>
> On 09/02/18 2:47 PM, Dominique Devienne wrote:
>
>> On Fri, Feb 9, 2018 at 10:06 AM, Jaikiran Pai
>> wrote:
>>
>> I need some inputs on how we should go about this specific change/test?
>>> Should this test continue to expect a exception o
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/57
@adamretter, this is now merged and we have added your name (Adam Retter)
to our contributors list. If you want us to a use different name or not include
the name at all, please do let us know.
---
How many times have we seen [] implementation throw StackOverflow?
this is because you are inserting elements into an already overloaded stack
what happens if your stack cannot accomodate the extra element..StackOverflow
refactoring to an implementation of Collection:
ArrayList list=null;
//now
On 2018-02-09, Jaikiran Pai wrote:
> That test was introduced long back as part of [5] to test another
> similar NPE. I think with the change I now have, it no longer reaches
> this place in the code where the Copy task would end up getting a null
> from a mapper, because various other utility cla
Jaikiran,
just to avoid duplicate work, I'm currently running tests on the 1.9.x
branch where I fix a bunch a FileNameMapper implementations that
wouldn't handle null sourceFileNames (which could happen for resources
that retun null for getName) as well as several other places that didn't
check th
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/68
We have a PR where we lack a consensus for (#57) because it adds a new
method to an important interface. To break the logjam, it could be postponed to
the next release if that targets Java 8 which all
> What this specific test failure shows, though, is that we now no longer
> are able to distinguish between a resource that we could copy but can't
> because it doesn't provide a name and the case of "all resources have
> been stripped out by mappers as "I don't know how to handle it".
* @ret
+1
Gintas
2018-02-09 21:16 GMT+01:00 Jan Matèrne (jhm) :
> > What this specific test failure shows, though, is that we now no longer
> > are able to distinguish between a resource that we could copy but can't
> > because it doesn't provide a name and the case of "all resources have
> > been stri
Sure Stefan.
-Jaikiran
On 09/02/18 11:00 PM, Stefan Bodewig wrote:
Jaikiran,
just to avoid duplicate work, I'm currently running tests on the 1.9.x
branch where I fix a bunch a FileNameMapper implementations that
wouldn't handle null sourceFileNames (which could happen for resources
that retu
Thanks everyone for the inputs. Based on those, I have now updated the
test to not expect a build failure exception and also have updated our
release notes to mention this change in behaviour.
-Jaikiran
On 09/02/18 11:00 PM, Stefan Bodewig wrote:
Jaikiran,
just to avoid duplicate work, I'm
Our recent release of Ant showed up a major issue[1] which impact Ant
users. The issue was found almost as soon as Ant was released, thanks to
the user upgrading to this newer version. I think this is an issue which
could have been caught before the release, in the RC, if more people
tested the
15 matches
Mail list logo
