Github user nlalevee commented on the pull request:
https://github.com/apache/ant-ivy/commit/6f22f4b49c2a3a59840d28e6cbe0c37a56ab1f90#commitcomment-23071422
Probably. And rather than asking for it, it is often better to suggest a
patch.
---
If your project is set up for it, you can
It's typically recommended not to include such merge commits (since they
usually pollute the commit history) and instead use the "git rebase"
approach. However, no harm is done with the merge commit. It essentially
is one additional commit with "pointers" to other commits. In this
specific case
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127395633
--- Diff: src/java/org/apache/ivy/osgi/p2/XMLInputParser.java ---
@@ -19,12 +19,11 @@
import java.io.IOException;
import java.io.InputStream;
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127395788
--- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java
---
@@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root) {
r
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127395825
--- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java
---
@@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root) {
r
