AW: [VOTE] Release Compress Antlib 1.5 based on RC3

2017-06-13 Thread jhm
> Should we include the PGP [e.g. 1] signature in the future? Answer myself: should be only on ASF server, so people could trust that ;) Maybe place a note (next time) how to check that (do we have a build snippet for that?) Jan --

[RESULT] Release Compress Antlib 1.5 based on RC3

2017-06-13 Thread Stefan Bodewig
Hi all with +1s by Nicolas, Jan and myself and no other votes this vote has passed. I'll publish the artifacts and give the mirrors time to catch up before sending out the announcement. Thanks to all who took the time to look into any of the several RCs. Stefan

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/43 Java7 supports the diamond operator and Ivy's baseline is now Java7. So you could use that (e.g. CCFilter.java). HMFilter: one advantage of foreach is having a meaningful iterator name. So

[GitHub] ant-ivy pull request #44: IVY-1561 - Enhancement to take into account enviro...

2017-06-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] ant-ivy issue #44: IVY-1561 - Enhancement to take into account environment a...

2017-06-13 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/44 merged, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

2017-06-13 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/38 requireCommonBaseDir: - could we replace firstPath by base==null? - line 115: additional comment: 'fail fast: ...' - line 117: 'finally we got ...' getBaseDir: - Rena

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

2017-06-13 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/38 >> requireCommonBaseDir: >>could we replace firstPath by base==null? >> line 115: additional comment: >>'fail fast: ...' >>line 117: 'finally we got ...' Done an

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 Thank you for comments, I'll split the PR and correct according to your suggestions. Should I remove common-colections altogether and use collections with generics from Java runtime? --- If your pro

[GitHub] ant-ivy pull request #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] ant-ivy pull request #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread twogee
GitHub user twogee reopened a pull request: https://github.com/apache/ant-ivy/pull/43 Generics and other fixes in tests and tutorials foreach loops are more terse than iterators, and they go well together with generic -- here's the first stab 😃 You can merge this pull request i

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

2017-06-13 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/38 All fine with me. Maybe we could extract the method into FileUtil later. I'll merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[ANN] Apache Compress Antlib 1.5 Released

2017-06-13 Thread Stefan Bodewig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The Apache Compress Antlib offers tasks and types for archive and compression formats. It supports gzip, xz, pack200, lzma, snappy, Unix .Z, DEFLATE, LZ4, Brotli and bzip2 compression and ar, arj, cpio, tar, Unix dump, 7z and zip archives. Version 1.5

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

2017-06-13 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/38 >> Maybe we could extract the method into FileUtil later. I went ahead and moved it to `FileUtil` since it does make sense for it to be there. --- If your project is set up for it, you can

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/43 I wont split this PR. Adress these in this PR: - diamond operator - renaming - ModuleIdTest The other things should be done in a new PR (PRs shouldnt be too big ;) I wouldnt

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 Here comes a bunch of new changes: I had to go for Commons Collections 4 to use generics, and threw in Commons CLI 1.4 for a good measure. I left HTTP Client 2.0 for the future lest this PR grows furt

[GitHub] ant-ivy pull request #38: IVY-1475 Throw an explicit BuildException if cache...

2017-06-13 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

2017-06-13 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/38 Closing this PR, because looking at the commits in master branch, it looks like Jan already pulled in this commit. Thanks @janmaterne --- If your project is set up for it, you can reply to this em

Re: IVYDE-382 proposed patch

2017-06-13 Thread J Pai
Hi Alexander, I actually just realized that your initial mail actually had a patch file attached. I didn’t notice that before and only today noticed it while looking at the mail list archive. So assuming this applies cleanly on latest master branch of IvyDE, I think this should be fine too, ins

IvyDE JIRA issues and changes for proposed release?

2017-06-13 Thread J Pai
There’s been some good progress on reviving the Ivy project (thanks Nicolas and Jan for helping out with the reviews and merging PRs) and we seem to be moving towards a state where the release is a possibility. The other project IvyDE (the Eclipse plugin) however needs a bit more push I think.

Re: IvyDE JIRA issues and changes for proposed release?

2017-06-13 Thread Gintautas Grigelionis
I stepped forward to help with IvyDE (well, my first idea was to make builds independent of a particular Eclipse distribution available on a particular mirror), but I realised that Ivy must improve first :-) I am an Eclipse user -- which explains my interest in IvyDE -- and I would be happy to keep

[GitHub] ant-ivy issue #43: Generics and related fixes in tests and tutorials

2017-06-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 Sorry for getting carried away with diamonds 😃... I put back `assertFalse(moduleId.equals(null));` but that assertion is equivalent to `assertFalse(null instanceOf ModuleId)` which is