Contributions (was: Re: Suggestion - JUnit4 tests for Ant)

2013-03-08 Thread Jesse Glick
First, BuildFileRule sounds like a great idea; do not see a patch so cannot comment further. Second, should Michael just be nominated as a committer? The @Ignore change was complex and valuable, and refactoring unit tests demonstrates serious intent. Third, why are we still using Subversion wh

Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-08 Thread Jesse Glick
“Changes that could break older environments” fails to list the Java 5 requirement! Typo in WHATSNEW: “NullPointerExcpetion” Otherwise, +1. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-m

Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-08 Thread Bruce Atherton
Good catch, Jesse. I have to admit I find the lack of a mention of requiring Java 5 troubling. That is definitely a difference people are going to care about. Is it possible to sneak that edit in to the WHATSNEW file (in both the bin and src packages) without a whole new revote? On 13-03-08

Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-08 Thread Antoine Levy Lambert
Hello Bruce, the WHATSNEW is included in the bin and the src package so to change it a new vote would be required. In fact a new build would be required. You can veto the release if it matters that much to you and I would then have to drop and recreate the 1.9.0 label and do a new build. Other

Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-08 Thread Bruce Atherton
Yes, that is what I thought. I think your answer is a good compromise. +1 on the vote. On 08/03/2013 2:10 PM, Antoine Levy Lambert wrote: Hello Bruce, the WHATSNEW is included in the bin and the src package so to change it a new vote would be required. In fact a new build would be required.

Re: Contributions (was: Re: Suggestion - JUnit4 tests for Ant)

2013-03-08 Thread Michael Clarke
I'm not sure why my patch didn't make it onto the list so I've cloned the Ant Github repository to my account [1] and applied my example changes [2]. I'll leave the discussion around Git versus Subversion for others to debate (Git would get my vote for what it's worth). I'm happy to either contrib