I did not find the time to make a new build last night, it will be for my NYC
evening.
Regards,
Antoine
On Mar 4, 2013, at 11:43 PM, Antoine Levy Lambert wrote:
> In fact I found out that I need to add ham crest on the class path, this was
> probably meant by the patch but I did not notice tha
It looks like my patch to fix JUnit Ignore notifications has broken
compilation on Java 1.5 machines. I've fixed this in the attached patch by
replacing !String#isEmpty() calls with String#length() !=0 and removing
@Override annotations on implementations of interface methods.
Sorry for breaking t
No problemo Michael
Its a good thing you caught this bug before we put it on any of the Apache
distros
Martin Gainty
__
Build and test locally ...deploy ONLY when you have passed all
testcases..Personal Quote
Date: Tue, 5 Mar 2013 18:24:06 +000
On 03/05/2013 05:29 AM, anto...@apache.org wrote:
adding hamcrest to the lib/optional because it is required at runtime for some
tests, also bumping junit dependency in pom file
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/etc/testcases/taskdefs/optional/junit.xml?rev=1452722&r1=145272
On 03/05/2013 08:29 PM, jgl...@apache.org wrote:
-if (annotation != null && annotation.value() != null &&
!annotation.value().isEmpty()) {
+if (annotation != null && annotation.value().length() > 0) {
(And yes removing the null check was intentional—annotation values ar
On 03/04/2013 11:25 PM, Antoine Levy Lambert wrote:
in fact the patch is failing one test :
testTestMethods in junit-test.xml
Now fixed? Reports:
skipping tests since it fails when using JUnit 4
But there is one genuine failure I know about, which predates @Ignore support:
https://builds.ap
On 03/05/2013 08:45 PM, Jesse Glick wrote:
Reproducible locally when running on Java 7. Not yet sure what it means but it
looks bad.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54641
-
To unsubscribe, e-mail: dev-unsu
Hello Jesse,
yes, this line was intentional, I wanted to avoid leaving ugly ${tmp.dir}
directories on the hard disk.
Regards,
Antoine
On Mar 5, 2013, at 7:07 PM, Jesse Glick wrote:
> On 03/05/2013 05:29 AM, anto...@apache.org wrote:
>> adding hamcrest to the lib/optional because it is required
Hi,
yes, I also noticed the failure of this XMLResultAggregatorTest and came to the
conclusion that the junitreport stylesheet needed to be changed.
Regards,
Antoine
On Mar 5, 2013, at 9:16 PM, Jesse Glick wrote:
> On 03/05/2013 08:45 PM, Jesse Glick wrote:
>> Reproducible locally when running
Hi,
I have uploaded candidate artifacts a second time for an ant 1.9.0 release to :
http://people.apache.org/~antoine/dist/ after having incorporated the patches
of Michael Clarke concerning JUnit.
Let's vote on releasing Ant 1.9.0 a second time.
Let' start with my own +1
Regards,
Antoine
Hello Jesse,
can this problem with the junit-frames.xsl wait for ant 1.9.1 ?
I feel like making another release in one month to 6 weeks from now.
Regards,
Antoine
On Mar 5, 2013, at 9:20 PM, bugzi...@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=54641
>
> Jesse Glick
11 matches
Mail list logo
