Re: AW: how to call a predefined target or macroin build.xml from Custom Ant task

2009-09-03 Thread Raja Nagendra Kumar
Thank You Jon, this rocks.. instead of createTask() every time, is there a way to reuse the already existing one (either may be created by xml files or with in other script file..) Not sure how memory and cpu intesive is createTask() specially when it is for loop (in our case this macro is run m

AW: AW: how to call a predefined target or macroin build.xml from Custom Ant task

2009-09-03 Thread Jan.Materne
macro = ...createTask(...); for(...) { macro.setDynamic(...) macro.execute(); } This should work. My example reused that too (1st with default value, 2nd run with custom value). You have to ensure that no required values are "deleted" in further runs. But if all runs require the setting o

Re: AW: Peformance Task usage from custom task

2009-09-03 Thread Raja Nagendra Kumar
Nope Jan.. On making such correction it giving error in line 188 i.e the line StopWatch sw = ( StopWatch ) targetStats.get( be.getTarget() ); of targetFinished().. It appears to me that AntPerformanceListener or the interface BuildListener is not custom tag friendly.. Some of the

Re: Publishing metalinks on the download page

2009-09-03 Thread Stefan Bodewig
Hi Bram, On 2009-09-01, Bram Neijt wrote: > Of course I'm happy to answer any and all question in this thread also. > Feel free to just mail 'no' if you are not interested in making changes > to your project's download homepage. Our download pages are created by CGI scripts that already selects

AW: AW: Peformance Task usage from custom task

2009-09-03 Thread Jan.Materne
You could also subclass that listener and overwrite the [task|target][Starts|Finished] by calling the build[Starts|Finished] method. Would that help? Or use the StopWatchTask? http://ant-contrib.svn.sourceforge.net/viewvc/ant-contrib/ant-contrib/trunk/src/main/java/net/sf/antcontrib/perf/StopWat

Re: Publishing metalinks on the download page

2009-09-03 Thread Bram Neijt
Hi Stefan, You are correct that you won't benefit from publishing metalinks, but your users might. One of the failures a redirect/GeoIP based approach can't solve for the user is possible firewall problems. The user may be behind a firewall which restricts to HTTP connetions, not knowing that for

Re: Publishing metalinks on the download page

2009-09-03 Thread Stefan Bodewig
On 2009-09-03, Bram Neijt wrote: > You are correct that you won't benefit from publishing metalinks, but > your users might. Which would benefit Ant ... But I'm not convinced 8-) > One of the failures a redirect/GeoIP based approach can't solve for > the user is possible firewall problems. The

Re: Publishing metalinks on the download page

2009-09-03 Thread Bram Neijt
Hi Stefan, On Thu, 2009-09-03 at 16:54 +0200, Stefan Bodewig wrote: > > Another benefit is that the download client can also verify the > > download afterwards, > > This depends on my level of paranoia. Do I want to trust md5 or sha1 > hashes at all? Does the client speak OpenPGP for a stronger

Re: AW: Peformance Task usage from custom task

2009-09-03 Thread Gilles Scokart
Note that if your intention is to profile your own task, you can also use any profiler you want. An ant build is a java application like an other. Gilles Scokart 2009/9/3 > You could also subclass that listener and overwrite the > [task|target][Starts|Finished] by calling the build[Starts|Fi

Re: svn commit: r810793 - /ant/core/trunk/src/main/org/apache/tools/ant/filters/util/ChainReaderHelper.java

2009-09-03 Thread Gilles Scokart
What is the benefits of having the parameters final ? Gilles Scokart 2009/9/3 > Author: bodewig > Date: Thu Sep 3 07:26:20 2009 > New Revision: 810793 > > URL: http://svn.apache.org/viewvc?rev=810793&view=rev > Log: > whitespace and make method paarameters final > > Modified: > > > ant/cor

Re: svn commit: r810793 - /ant/core/trunk/src/main/org/apache/tools/ant/filters/util/ChainReaderHelper.java

2009-09-03 Thread Jeffrey E Care
Gilles Scokart wrote on 09/03/2009 02:51:46 PM: > Re: svn commit: r810793 - /ant/core/trunk/src/main/org/apache/tools/ > ant/filters/util/ChainReaderHelper.java > > What is the benefits of having the parameters final ? It prevents you from inadvertently changing which object the parameter name

Re: svn commit: r810793 - /ant/core/trunk/src/main/org/apache/tools/ant/filters/util/ChainReaderHelper.java

2009-09-03 Thread Stefan Bodewig
On 2009-09-03, Gilles Scokart wrote: > What is the benefits of having the parameters final ? Apart from what Jeffrey said, the local variables that became parameters when I extracted the method have been final in the first place - and I wanted to stay true to the original code. Stefan

Re: Publishing metalinks on the download page

2009-09-03 Thread Stefan Bodewig
On 2009-09-03, Bram Neijt wrote: > On Thu, 2009-09-03 at 16:54 +0200, Stefan Bodewig wrote: >> Do I tust the download client? ;-; > I trust my download client, just as much as I trust my md5sums > binary ;). Agreed. >> If my understanding is correct it would also allow me to create a trojan >>