svn commit: r568495 - in /ant/core/trunk: ./ docs/manual/CoreTypes/ src/main/org/apache/tools/ant/ src/main/org/apache/tools/ant/types/ src/tests/antunit/types/

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 01:16:49 2007 New Revision: 568495 URL: http://svn.apache.org/viewvc?rev=568495&view=rev Log: Bugzilla 11270: add errorOnMissingDir attribute to fileset Modified: ant/core/trunk/CONTRIBUTORS ant/core/trunk/WHATSNEW ant/core/trunk/contributors.xml

svn commit: r568496 - in /ant/core/branches/ANT_17_BRANCH: ./ docs/manual/CoreTypes/ src/main/org/apache/tools/ant/ src/main/org/apache/tools/ant/types/ src/tests/antunit/types/

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 01:17:25 2007 New Revision: 568496 URL: http://svn.apache.org/viewvc?rev=568496&view=rev Log: sync Bugzilla 11270: add errorOnMissingDir attribute to fileset Modified: ant/core/branches/ANT_17_BRANCH/CONTRIBUTORS ant/core/branches/ANT_17_BRANCH/WHATSNE

svn commit: r568503 - in /ant/core/trunk: WHATSNEW docs/manual/CoreTasks/javac.html src/main/org/apache/tools/ant/taskdefs/Javac.java

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 01:25:58 2007 New Revision: 568503 URL: http://svn.apache.org/viewvc?rev=568503&view=rev Log: Bugzilla 43114: package-info.java repeatedly compiled Modified: ant/core/trunk/WHATSNEW ant/core/trunk/docs/manual/CoreTasks/javac.html ant/core/trunk/sr

svn commit: r568504 - in /ant/core/branches/ANT_17_BRANCH: WHATSNEW docs/manual/CoreTasks/javac.html src/main/org/apache/tools/ant/taskdefs/Javac.java

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 01:26:15 2007 New Revision: 568504 URL: http://svn.apache.org/viewvc?rev=568504&view=rev Log: sync Bugzilla 43114: package-info.java repeatedly compiled Modified: ant/core/branches/ANT_17_BRANCH/WHATSNEW ant/core/branches/ANT_17_BRANCH/docs/manual/Cor

DO NOT REPLY [Bug 43114] - package-info.java repeatedly compiled

2007-08-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 11270] - FileSet and DirSet break if the directory does not exist

2007-08-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

AW: svn commit: r568495 - in /ant/core/trunk: ./ docs/manual/CoreTypes/ src/main/org/apache/tools/ant/ src/main/org/apache/tools/ant/types/ src/tests/antunit/types/

2007-08-22 Thread Jan.Materne
>Bugzilla 11270: add errorOnMissingDir attribute to fileset > >--- ant/core/trunk/docs/manual/CoreTypes/fileset.html (original) >+++ ant/core/trunk/docs/manual/CoreTypes/fileset.html Wed Aug >22 01:16:49 2007 >@@ -98,6 +98,15 @@ > true. See the note below. > No > >+ >+erroronmis

svn commit: r568510 - in /ant/core/trunk/src/main/org/apache/tools/ant/property: ./ NullReturn.java package.html

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 01:40:54 2007 New Revision: 568510 URL: http://svn.apache.org/viewvc?rev=568510&view=rev Log: adding null return Added: ant/core/trunk/src/main/org/apache/tools/ant/property/ ant/core/trunk/src/main/org/apache/tools/ant/property/NullReturn.java (wit

svn commit: r568511 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 01:42:11 2007 New Revision: 568511 URL: http://svn.apache.org/viewvc?rev=568511&view=rev Log: allow a propertyevalulator to signal that it 'owns' the property, but the property is not set Modified: ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelp

svn commit: r568513 - in /ant/core/trunk: bootstrap.bat bootstrap.sh

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 01:43:46 2007 New Revision: 568513 URL: http://svn.apache.org/viewvc?rev=568513&view=rev Log: add o.a.t.a.property to bootstrap compilation Modified: ant/core/trunk/bootstrap.bat ant/core/trunk/bootstrap.sh Modified: ant/core/trunk/bootstrap.bat URL:

svn commit: r568518 - /ant/core/trunk/docs/manual/CoreTypes/fileset.html

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 01:55:18 2007 New Revision: 568518 URL: http://svn.apache.org/viewvc?rev=568518&view=rev Log: fix manual entry for erroronmissingdir Modified: ant/core/trunk/docs/manual/CoreTypes/fileset.html Modified: ant/core/trunk/docs/manual/CoreTypes/fileset.html UR

svn commit: r568519 - /ant/core/branches/ANT_17_BRANCH/docs/manual/CoreTypes/fileset.html

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 01:55:51 2007 New Revision: 568519 URL: http://svn.apache.org/viewvc?rev=568519&view=rev Log: sync: fix manual entry for erroronmissingdir Modified: ant/core/branches/ANT_17_BRANCH/docs/manual/CoreTypes/fileset.html Modified: ant/core/branches/ANT_17_BRAN

Re: svn commit: r568495 - in /ant/core/trunk: ./ docs/manual/CoreTypes/ src/main/org/apache/tools/ant/ src/main/org/apache/tools/ant/types/ src/tests/antunit/types/

2007-08-22 Thread Peter Reilly
Done, ta. Peter On 8/22/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > >Bugzilla 11270: add errorOnMissingDir attribute to fileset > > > >--- ant/core/trunk/docs/manual/CoreTypes/fileset.html (original) > >+++ ant/core/trunk/docs/manual/CoreTypes/fileset.html Wed Aug > >22 01:16:49 2007 > >@@

svn commit: r568520 - /ant/core/trunk/src/main/org/apache/tools/ant/property/package.html

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 01:58:52 2007 New Revision: 568520 URL: http://svn.apache.org/viewvc?rev=568520&view=rev Log: eol-style Modified: ant/core/trunk/src/main/org/apache/tools/ant/property/package.html (props changed) Propchange: ant/core/trunk/src/main/org/apache/tools/an

DO NOT REPLY [Bug 23942] - Addition of a local property

2007-08-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Local Properties

2007-08-22 Thread Peter Reilly
Hi all, I have updated the local properties patch to make use of the new PropertyHelper delegate infrastructure. (see: http://issues.apache.org/bugzilla/show_bug.cgi?id=23942) The idea behind local properties is to provide isolation of properties within element blocks - like macrodefs and sequenti

svn commit: r568592 - in /ant/core/trunk/src/main/org/apache/tools/ant: DirectoryScanner.java taskdefs/Javac.java types/AbstractFileSet.java

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 05:43:51 2007 New Revision: 568592 URL: http://svn.apache.org/viewvc?rev=568592&view=rev Log: trailing spaces Modified: ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Javac.java

svn commit: r568598 - in /ant/core/branches/ANT_17_BRANCH/src/main/org/apache/tools/ant: DirectoryScanner.java taskdefs/Javac.java types/AbstractFileSet.java

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 05:49:44 2007 New Revision: 568598 URL: http://svn.apache.org/viewvc?rev=568598&view=rev Log: sync Modified: ant/core/branches/ANT_17_BRANCH/src/main/org/apache/tools/ant/DirectoryScanner.java ant/core/branches/ANT_17_BRANCH/src/main/org/apache/tools

svn commit: r568633 - /ant/core/trunk/docs/manual/CoreTypes/fileset.html

2007-08-22 Thread mbenson
Author: mbenson Date: Wed Aug 22 07:52:22 2007 New Revision: 568633 URL: http://svn.apache.org/viewvc?rev=568633&view=rev Log: sp; elaboration Modified: ant/core/trunk/docs/manual/CoreTypes/fileset.html Modified: ant/core/trunk/docs/manual/CoreTypes/fileset.html URL: http://svn.apache.org/v

svn commit: r568634 - /ant/core/branches/ANT_17_BRANCH/docs/manual/CoreTypes/fileset.html

2007-08-22 Thread mbenson
Author: mbenson Date: Wed Aug 22 07:53:20 2007 New Revision: 568634 URL: http://svn.apache.org/viewvc?rev=568634&view=rev Log: merge Modified: ant/core/branches/ANT_17_BRANCH/docs/manual/CoreTypes/fileset.html Modified: ant/core/branches/ANT_17_BRANCH/docs/manual/CoreTypes/fileset.html URL:

svn commit: r568635 - /ant/core/trunk/src/tests/antunit/types/fileset-test.xml

2007-08-22 Thread mbenson
Author: mbenson Date: Wed Aug 22 07:54:34 2007 New Revision: 568635 URL: http://svn.apache.org/viewvc?rev=568635&view=rev Log: demonstrate missingdir fileset exists but is empty Modified: ant/core/trunk/src/tests/antunit/types/fileset-test.xml Modified: ant/core/trunk/src/tests/antunit/types

svn commit: r568638 - /ant/core/branches/ANT_17_BRANCH/src/tests/antunit/types/fileset-test.xml

2007-08-22 Thread mbenson
Author: mbenson Date: Wed Aug 22 07:55:47 2007 New Revision: 568638 URL: http://svn.apache.org/viewvc?rev=568638&view=rev Log: merge extra missingdir fileset test Modified: ant/core/branches/ANT_17_BRANCH/src/tests/antunit/types/fileset-test.xml Modified: ant/core/branches/ANT_17_BRANCH/src

Re: svn commit: r568511 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java

2007-08-22 Thread Matt Benson
I had looked into something like this, but what about the case when a delegate needs to re-call PH? The delegate in question would need the NullReturn object (should we refactor this to be just a PSF Object on PropertyHelper?). Maybe we can have a PropertyHelper store a proxy to itself, that does

Re: svn commit: r568511 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java

2007-08-22 Thread Peter Reilly
Things do get complicated when delegates need to re-call PH. The nullobject I put in is needed for the local property delegate - it has seen a property name in its stack of properties, but the property has not yet been set, the property name should not pass down to the the other property resolvers

Re: svn commit: r568511 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java

2007-08-22 Thread Dominique Devienne
On 8/22/07, Peter Reilly <[EMAIL PROTECTED]> wrote: Note that I'm lost in this discussion... > "${el:project.targets.get('not-present')}" should resolve to > "null" rather than "${el:project.targets.get('not-present')}". > - the string "null" cannot be used, it actually needs to be > an null obj

DO NOT REPLY [Bug 43186] New: - tar task does not add entries for folders

2007-08-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 43083] - [SUBMIT] sshsession task

2007-08-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 43187] New: - untar does not create symlinks

2007-08-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: svn commit: r568511 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java

2007-08-22 Thread Matt Benson
--- Dominique Devienne <[EMAIL PROTECTED]> wrote: > On 8/22/07, Peter Reilly > <[EMAIL PROTECTED]> wrote: > Note that I'm lost in this discussion... > > > "${el:project.targets.get('not-present')}" should > resolve to > > "null" rather than > "${el:project.targets.get('not-present')}". > > - t

Re: Local Properties

2007-08-22 Thread Matt Benson
Apologies for the top post but yours was rather long. ;) I like the approach patch; I have applied it but don't have time to exercise it ATM. The only issue I see is that I am apparently too stupid to understand how copying the current stack for new threads works. What I see: kicks off a give

Re: svn commit: r568511 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java

2007-08-22 Thread Peter Reilly
On 8/22/07, Matt Benson <[EMAIL PROTECTED]> wrote: > > --- Dominique Devienne <[EMAIL PROTECTED]> wrote: > > > On 8/22/07, Peter Reilly > > <[EMAIL PROTECTED]> wrote: > > Note that I'm lost in this discussion... > > > > > "${el:project.targets.get('not-present')}" should > > resolve to > > > "nul

Re: svn commit: r568511 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java

2007-08-22 Thread Matt Benson
--- Peter Reilly <[EMAIL PROTECTED]> wrote: > On 8/22/07, Matt Benson <[EMAIL PROTECTED]> > wrote: [SNIP] > > though I'd still like an opinion on the proxy > > mechanism I suggested for delegate recursion... > :) > > I did not reply because I did not understand the > proposal :-) > [SNIP] Ok

Re: Local Properties

2007-08-22 Thread Peter Reilly
On 8/22/07, Matt Benson <[EMAIL PROTECTED]> wrote: > Apologies for the top post but yours was rather long. > ;) I like the approach patch; I have applied it but > don't have time to exercise it ATM. The only issue I > see is that I am apparently too stupid to understand > how copying the current

Re: svn commit: r568511 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java

2007-08-22 Thread Peter Reilly
On 8/22/07, Matt Benson <[EMAIL PROTECTED]> wrote: > > --- Peter Reilly <[EMAIL PROTECTED]> wrote: > > > On 8/22/07, Matt Benson <[EMAIL PROTECTED]> > > wrote: > > [SNIP] > > > though I'd still like an opinion on the proxy > > > mechanism I suggested for delegate recursion... > > :) > > > > I did n

svn commit: r568703 - /ant/antlibs/antunit/trunk/src/main/org/apache/ant/antunit/AntUnit.java

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 10:07:58 2007 New Revision: 568703 URL: http://svn.apache.org/viewvc?rev=568703&view=rev Log: Change firing of starttest event. Original code assumed that a targetstart event would always happen. However, this is not the case if the target depends on a SetUp ta

svn commit: r568704 - in /ant/core/trunk/src/main/org/apache/tools: ant/types/selectors/SizeSelector.java ant/util/regexp/RegexpFactory.java ant/util/regexp/RegexpMatcherFactory.java zip/ZipOutputStre

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 10:09:55 2007 New Revision: 568704 URL: http://svn.apache.org/viewvc?rev=568704&view=rev Log: remove some magic numbers Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/selectors/SizeSelector.java ant/core/trunk/src/main/org/apache/tools/a

svn commit: r568705 - in /ant/core/branches/ANT_17_BRANCH/src/main/org/apache/tools: ant/types/selectors/SizeSelector.java ant/util/regexp/RegexpFactory.java ant/util/regexp/RegexpMatcherFactory.java

2007-08-22 Thread peterreilly
Author: peterreilly Date: Wed Aug 22 10:10:50 2007 New Revision: 568705 URL: http://svn.apache.org/viewvc?rev=568705&view=rev Log: sync Modified: ant/core/branches/ANT_17_BRANCH/src/main/org/apache/tools/ant/types/selectors/SizeSelector.java ant/core/branches/ANT_17_BRANCH/src/main/org/

Re: svn commit: r568511 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java

2007-08-22 Thread Matt Benson
--- Peter Reilly <[EMAIL PROTECTED]> wrote: > On 8/22/07, Matt Benson <[EMAIL PROTECTED]> > wrote: > > > > --- Peter Reilly <[EMAIL PROTECTED]> > wrote: > > > > > On 8/22/07, Matt Benson <[EMAIL PROTECTED]> > > > wrote: > > > > [SNIP] > > > > though I'd still like an opinion on the proxy > > > >

Re: svn commit: r568511 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java

2007-08-22 Thread Dominique Devienne
On 8/22/07, Peter Reilly <[EMAIL PROTECTED]> wrote: > Matt had added something to IH to allow Object to be returned > from property evaluation, I linked this to tasks/types that > say they understand Object by having a setX(Object) signature. > > With local properties and setX(Object) in place one

DO NOT REPLY [Bug 31506] - error installing ant on j: drive partition

2007-08-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu