DO NOT REPLY [Bug 42718] New: - Parsing perperties passed to ant in command line

2007-06-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42718] - Parsing perperties passed to ant in command line

2007-06-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: svn commit: r549684 - /ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java

2007-06-22 Thread Peter Reilly
On 6/22/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: mbenson Date: Thu Jun 21 20:10:20 2007 New Revision: 549684 URL: http://svn.apache.org/viewvc?view=rev&rev=549684 Log: detect cs Modified: ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java Modified: ant/core/tr

DO NOT REPLY [Bug 42713] - CBZip2OutputStream#finish method like in java.util.zip.GZIPOutputStream

2007-06-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42713] - CBZip2OutputStream#finish method like in java.util.zip.GZIPOutputStream

2007-06-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: PropertyHelper thoughts

2007-06-22 Thread Conor MacNeill
There is a bug in the JUnit task where it puts properties into a Properties collection which then blows up if they are not Strings. I will fix this weekend, hopefully. Conor Stefan Bodewig wrote: > On Sat, 16 Jun 2007, Matt Benson <[EMAIL PROTECTED]> wrote: > >> Meanwhile I'll try restricting p

Re: svn commit: r549684 - /ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java

2007-06-22 Thread Steve Loughran
Peter Reilly wrote: On 6/22/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: mbenson Date: Thu Jun 21 20:10:20 2007 New Revision: 549684 URL: http://svn.apache.org/viewvc?view=rev&rev=549684 Log: detect cs Modified: ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java

Re: PropertyHelper thoughts

2007-06-22 Thread Stefan Bodewig
On Thu, 21 Jun 2007, Matt Benson <[EMAIL PROTECTED]> wrote: > --- Stefan Bodewig <[EMAIL PROTECTED]> wrote: > >> On Sat, 16 Jun 2007, Matt Benson >> <[EMAIL PROTECTED]> wrote: >> >> > Meanwhile I'll try restricting properties to >> strings and see if we >> > break anything internal. >> >> We hav

Re: PropertyHelper thoughts

2007-06-22 Thread Dominique Devienne
On 6/22/07, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > Funnily enough I did restrict Properties to Strings > and all the tests passed. :) You mean I didn't write a unit test when I fixed Bugzilla Issue 904? OK, what can I say? hmm, trying to come up with a cheap excuse, March 2001, ah yes, Ant

Re: PropertyHelper thoughts

2007-06-22 Thread Peter Reilly
On 6/22/07, Dominique Devienne <[EMAIL PROTECTED]> wrote: On 6/22/07, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > > Funnily enough I did restrict Properties to Strings > > and all the tests passed. :) > > You mean I didn't write a unit test when I fixed Bugzilla Issue 904? > OK, what can I say?

Re: PropertyHelper thoughts

2007-06-22 Thread Matt Benson
--- Peter Reilly <[EMAIL PROTECTED]> wrote: > On 6/22/07, Dominique Devienne <[EMAIL PROTECTED]> > wrote: > > On 6/22/07, Stefan Bodewig <[EMAIL PROTECTED]> > wrote: > > > > Funnily enough I did restrict Properties to > Strings > > > > and all the tests passed. :) > > > > > > You mean I didn't w

Re: PropertyHelper thoughts

2007-06-22 Thread Dominique Devienne
On 6/22/07, Matt Benson <[EMAIL PROTECTED]> wrote: Can we keep this discussion afloat? I've done a lot of thinking on this issue over the past week and a few days ago I had the epiphany that an Object-enabled PropertyHelper is legitimate if we think of the "Property" part of the name as having a

Re: PropertyHelper thoughts

2007-06-22 Thread Peter Reilly
On 6/22/07, Dominique Devienne <[EMAIL PROTECTED]> wrote: On 6/22/07, Matt Benson <[EMAIL PROTECTED]> wrote: > Can we keep this discussion afloat? I've done a lot > of thinking on this issue over the past week and a few > days ago I had the epiphany that an Object-enabled > PropertyHelper is leg

Re: PropertyHelper thoughts

2007-06-22 Thread Matt Benson
--- Dominique Devienne <[EMAIL PROTECTED]> wrote: > On 6/22/07, Matt Benson <[EMAIL PROTECTED]> > wrote: > > Can we keep this discussion afloat? I've done a > lot > > of thinking on this issue over the past week and a > few > > days ago I had the epiphany that an Object-enabled > > PropertyHelpe

Re: svn commit: r549684 - /ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java

2007-06-22 Thread Matt Benson
--- Steve Loughran <[EMAIL PROTECTED]> wrote: > Peter Reilly wrote: > > On 6/22/07, [EMAIL PROTECTED] > <[EMAIL PROTECTED]> wrote: > >> Author: mbenson > >> Date: Thu Jun 21 20:10:20 2007 > >> New Revision: 549684 > >> > >> URL: > http://svn.apache.org/viewvc?view=rev&rev=549684 > >> Log: > >> de

Re: PropertyHelper thoughts

2007-06-22 Thread Dominique Devienne
On 6/22/07, Matt Benson <[EMAIL PROTECTED]> wrote: Let me divert the topic for a moment--the other of the two most important property handling extension points can be expressed with a PropertyEvaluator interface. A perfect example is Ant's built-in toString:refid property "syntax". Basically tha

Re: PropertyHelper thoughts

2007-06-22 Thread Matt Benson
--- Dominique Devienne <[EMAIL PROTECTED]> wrote: > On 6/22/07, Matt Benson <[EMAIL PROTECTED]> > wrote: > > Let me divert the topic for a moment--the other of > the > > two most important property handling extension > points > > can be expressed with a PropertyEvaluator > interface. > > A perfec