DO NOT REPLY [Bug 30094] - Performance enhancements using java.nio & lazy calls

2006-04-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: AW: Adding a methof to StringUtils

2006-04-20 Thread Kev Jackson
Antoine Levy-Lambert wrote: Matt Benson wrote: Kev: I've asked some stuff about FileUtils before... historically it was thought it might be pluggable, hence all the instance methods. But that never happened so the static methods crept in. I think it was Martijn who really pushed in the Fil

svn commit: r395534 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/compilers/CompilerAdapterFactory.java

2006-04-20 Thread peterreilly
Author: peterreilly Date: Thu Apr 20 01:42:25 2006 New Revision: 395534 URL: http://svn.apache.org/viewcvs?rev=395534&view=rev Log: remove spurious system.out change date to 2006 Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/compilers/CompilerAdapterFactory.java Modified:

svn commit: r395539 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/ManifestClassPath.java

2006-04-20 Thread peterreilly
Author: peterreilly Date: Thu Apr 20 01:53:50 2006 New Revision: 395539 URL: http://svn.apache.org/viewcvs?rev=395539&view=rev Log: 2006 Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/ManifestClassPath.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Man

Re: AW: Adding a methof to StringUtils

2006-04-20 Thread Steve Loughran
Kev Jackson wrote: If it came to it I'd -1 it too! I don't like any of the solutions I could come up with yesterday, the one I showed was the 'least worst' that I could think of, with a semi-upgrade path to Java5 style varargs (use an object array). I was mainly throwing the idea out to se

AW: AW: Adding a methof to StringUtils

2006-04-20 Thread Jan.Materne
>One thing I've always been curious about is how much speedup >we'd get by turning off all logging. That is, if I modified >log() to discard its contents, how much faster would >everything be? We couldnt use the test suite as a benchmark, >because too many tests depend on the log, and it proba

[patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Kev Jackson
Hi, As promised, here's the code that I hacked together today at Antoine's suggestion regarding a patch in bugzilla [1]. Feel free to tear it to pieces and point out obvious problems. I've patched my version of copy to use this code instead of FileUtils directly and so far there have been n

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Antoine Levy-Lambert
Hello Kevin, NioFileUtils should go into another package org.apache.tools.ant.util.java14 otherwise we are going to have build problems under java 1.2 This should be entered in the build.xml (selector needs.jdk14+) Therefore NioFileUtils would be packaged in ant-nodeps.jar We need also a FileUtil

Re: AW: AW: Adding a methof to StringUtils

2006-04-20 Thread Steve Loughran
[EMAIL PROTECTED] wrote: One thing I've always been curious about is how much speedup we'd get by turning off all logging. That is, if I modified log() to discard its contents, how much faster would everything be? We couldnt use the test suite as a benchmark, because too many tests depend on

AW: AW: AW: Adding a methof to StringUtils

2006-04-20 Thread Jan.Materne
>> We could use the buildfiles from the testcases. Just run as simple >> builds and ignore their results. Just for having a bunch of >buildfiles >> ;-) >> Realistic? . > >still not that accurate as it doesnt represent real builds. >Better to turn off logging for a day and see how much faste

DO NOT REPLY [Bug 32738] - Delete task won't be quiet

2006-04-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Matt Benson
--- Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote: > Hello Kevin, > > NioFileUtils should go into another package > org.apache.tools.ant.util.java14 otherwise we are > going to have build > problems under java 1.2 > This should be entered in the build.xml (selector > needs.jdk14+) > Therefore Ni

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Kevin Jackson
> I found it in Kev's (long :) mail: > Sorry it was rather long, but there were a few files packed in there! > Since the other impls will be conditionally compiled, > we should use Class.forInstance()... > ok, so we use dynamic class-loading to get the correct fileutils? Is there an example in t

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Antoine Levy-Lambert
Kevin Jackson wrote: I found it in Kev's (long :) mail: Sorry it was rather long, but there were a few files packed in there! No problem, I should have washed my glasses this morning, ... Since the other impls will be conditionally compiled, we should use Class.forInstance()...

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Matt Benson
--- Kevin Jackson <[EMAIL PROTECTED]> wrote: > > I found it in Kev's (long :) mail: > > > > Sorry it was rather long, but there were a few files > packed in there! parenthetical smiley above. > > Since the other impls will be conditionally > compiled, > > we should use Class.forInstance()... >

svn commit: r395614 - /ant/core/trunk/src/main/org/apache/tools/ant/util/regexp/RegexpMatcherFactory.java

2006-04-20 Thread mbenson
Author: mbenson Date: Thu Apr 20 08:09:41 2006 New Revision: 395614 URL: http://svn.apache.org/viewcvs?rev=395614&view=rev Log: remove extra space Modified: ant/core/trunk/src/main/org/apache/tools/ant/util/regexp/RegexpMatcherFactory.java Modified: ant/core/trunk/src/main/org/apache/tools

svn commit: r395615 - /ant/core/trunk/src/main/org/apache/tools/ant/util/ClasspathUtils.java

2006-04-20 Thread mbenson
Author: mbenson Date: Thu Apr 20 08:13:51 2006 New Revision: 395615 URL: http://svn.apache.org/viewcvs?rev=395615&view=rev Log: remove extraneous javadoc block... Martijn! :) Modified: ant/core/trunk/src/main/org/apache/tools/ant/util/ClasspathUtils.java Modified: ant/core/trunk/src/main/or

DO NOT REPLY [Bug 30094] - Performance enhancements using java.nio & lazy calls

2006-04-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Matt Benson
Another thought about the factory--it should cache an instance of each FileUtils type to minimize object creation. We can either just have it be known that FileUtilsAdapter impls should be stateless or have a StatelessFileUtilsAdapter interface--if implemented, cache, else don't. thoughts? -Matt

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Antoine Levy-Lambert
Matt Benson wrote: Another thought about the factory--it should cache an instance of each FileUtils type to minimize object creation. We can either just have it be known that FileUtilsAdapter impls should be stateless or have a StatelessFileUtilsAdapter interface--if implemented, cache, else don

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Martijn Kruithof
I actually had a similar problem in my dtd work recently. We had a class that applied one single strategy to determine something important for telecommunication systems, had some static methods, some nonstatic methods, was used by different components of which some could not be updated. Backwa

DO NOT REPLY [Bug 30094] - Performance enhancements using java.nio & lazy calls

2006-04-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Martijn Kruithof
O by the way I am / was looking if FileUtils could be split into os dependend version this way, so I actually did some work on this as well. Martijn Kruithof schreef: I actually had a similar problem in my dtd work recently. We had a class that applied one single strategy to determine somethi

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Martijn Kruithof
Matt Benson schreef: Another thought about the factory--it should cache an instance of each FileUtils type to minimize object creation. We can either just have it be known that FileUtilsAdapter impls should be stateless or have a StatelessFileUtilsAdapter interface--if implemented, cache, else

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Matt Benson
--- Martijn Kruithof <[EMAIL PROTECTED]> wrote: > Matt Benson schreef: > > >Another thought about the factory--it should cache > an > >instance of each FileUtils type to minimize object > >creation. We can either just have it be known that > >FileUtilsAdapter impls should be stateless or have >

svn commit: r395688 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/CompressedResource.java

2006-04-20 Thread stevel
Author: stevel Date: Thu Apr 20 13:01:34 2006 New Revision: 395688 URL: http://svn.apache.org/viewcvs?rev=395688&view=rev Log: Resource implements ResourceCollection, so this was a a needless entry unless it was a Remotable interface and we want rmic to generate proxies. Assuming we don't, I'm d

Additional SourceSafe (VSS) Tasks - Any Comments?

2006-04-20 Thread Paul Cager
Standard Ant contains a number of VSS tasks and I'm writing a couple more for my own use (tasks relating to file / project properties, such as shared versions). My questions are: should I submit these tasks for possible inclusion in the standard Ant distribution? And if so, do you have any advice

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Martijn Kruithof
Matt Benson schreef: viewcvs(svn) shows I did it 6.5 months ago... apparently so. Speaking of which, Kev (I think) mentioned these are static in ResourceUtils, but as they are unreleased we could change them to instance methods. The behavior there is fairly straightforward, though, so I'm not

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Matt Benson
--- Martijn Kruithof <[EMAIL PROTECTED]> wrote: > Matt Benson schreef: > > >viewcvs(svn) shows I did it 6.5 months ago... > >apparently so. Speaking of which, Kev (I think) > >mentioned these are static in ResourceUtils, but as > >they are unreleased we could change them to > instance > >methods

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Antoine Levy-Lambert
> I'm afraid I've never studied nio in much detail... do > its performance enhancements extend to non-file-based > IO? > > -Matt Hello Matt, I never studied nio in detail either. What I found out empirically in a Windows environment is that copying files to a share goes about 4 times faster whe

[VOTE-RESULT] removal of dependency to xslp

2006-04-20 Thread Antoine Levy-Lambert
Hello, there have been only +1s for the removal of xslp. (9). So I am going ahead. Regards, Antoine - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r395705 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java

2006-04-20 Thread antoine
Author: antoine Date: Thu Apr 20 14:39:32 2006 New Revision: 395705 URL: http://svn.apache.org/viewcvs?rev=395705&view=rev Log: Fix javadoc, remove a call to deprecated FileUtils.newUtils() Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java Modified:

svn commit: r395716 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java

2006-04-20 Thread antoine
Author: antoine Date: Thu Apr 20 15:35:31 2006 New Revision: 395716 URL: http://svn.apache.org/viewcvs?rev=395716&view=rev Log: 2006 Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/opt

svn commit: r395723 - in /ant/core/trunk: ./ docs/manual/ docs/manual/CoreTasks/ src/main/org/apache/tools/ant/taskdefs/ src/main/org/apache/tools/ant/taskdefs/optional/ src/testcases/org/apache/tools

2006-04-20 Thread antoine
Author: antoine Date: Thu Apr 20 16:00:46 2006 New Revision: 395723 URL: http://svn.apache.org/viewcvs?rev=395723&view=rev Log: Remove xslp usage from ant. Bugzilla 23455. Removed: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/XslpLiaison.java ant/core/trunk/src/testca

DO NOT REPLY [Bug 23455] - [PATCH] mark xlsp liaison as deprecated

2006-04-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [patch] NioFileUtils, FileUtilsAdapter + factory (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Kevin Jackson
> You do not gain by using nio when copying files to a local drive. As far as I know, you do gain a little, in the flexibility offered (memory mapped files, channels etc). The code is also (usually) much easier to maintain compared to standard IO. > > I do not know what in the implementation of

svn commit: r395742 - /ant/core/trunk/docs/manual/CoreTasks/style.html

2006-04-20 Thread antoine
Author: antoine Date: Thu Apr 20 17:28:35 2006 New Revision: 395742 URL: http://svn.apache.org/viewcvs?rev=395742&view=rev Log: 2006 and try to adapt indentation to level of nesting of the elements described Modified: ant/core/trunk/docs/manual/CoreTasks/style.html Modified: ant/core/trunk/d

Re: svn commit: r395742 - /ant/core/trunk/docs/manual/CoreTasks/style.html

2006-04-20 Thread Antoine Levy-Lambert
Hi, I did a few indentation changes, because I realized that it was not at all clear that the attributes described below "Factory" are nested elements of the factory, which itself is a nested element of the xslt task. The xslt task describes actually several types : factory, attribute, outputprop

DO NOT REPLY [Bug 39373] New: - scp task does not work for some sshd, which does not scp1 protocol.

2006-04-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 39373] - scp task does not work for some sshd, which does not scp1 protocol.

2006-04-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

[patch] NioFileUtils, Java6FileUtils, FileUtilsAdapter + factory, build.xml (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Kev Jackson
Ok, this is what I've managed to bash together this morning: - NioFileUtils (uses Java1.4 NIO libraries, altered the TRANSFER_SIZE as suggested to 32000, currently no way to override that (yet)) - Java6FileUtils (currently has no implementation, but could be used in future for implementing Java

DO NOT REPLY [Bug 34659] - ANT_HOME containing Japanese (non-ascii) characters prevents ant from starting

2006-04-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [patch] NioFileUtils, Java6FileUtils, FileUtilsAdapter + factory, build.xml (was Re: AW: Adding a methof to StringUtils)

2006-04-20 Thread Martijn Kruithof
Hi, Adding setting the property using -D to ANT_OPTS should do. 5 things: 1) I saw you removed public members (constants) from FileUtils (Non backward compatible change, keeping everything BC also frustrates me sometimes, but still I think it is best not to break parts we do not know of.)