DO NOT REPLY [Bug 38732] - rmic task doesn't work with -Xnew and JDK 6.0

2006-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 39345] New: - rpm tasks destroys PATH for determination of rpmbuild executable

2006-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r395168 - /ant/core/trunk/src/etc/testcases/taskdefs/delete.xml

2006-04-19 Thread kevj
Author: kevj Date: Wed Apr 19 01:19:38 2006 New Revision: 395168 URL: http://svn.apache.org/viewcvs?rev=395168&view=rev Log: 2 more tests for bug#32738 Modified: ant/core/trunk/src/etc/testcases/taskdefs/delete.xml Modified: ant/core/trunk/src/etc/testcases/taskdefs/delete.xml URL: http://s

svn commit: r395169 - /ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/DeleteTest.java

2006-04-19 Thread kevj
Author: kevj Date: Wed Apr 19 01:20:47 2006 New Revision: 395169 URL: http://svn.apache.org/viewcvs?rev=395169&view=rev Log: 2 more tests for bug#32738 Modified: ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/DeleteTest.java Modified: ant/core/trunk/src/testcases/org/apache/tool

Adding a methof to StringUtils

2006-04-19 Thread Kev Jackson
Hi, As I've been hacking away today, I've been swapping a load of "" + "" + "" style code over to use StringBuffers. I thought that perhaps there's a potential use of a static method in StringUtils to construct these strings from an array StringUtils.messageAppender /** * Creates log m

AW: Adding a methof to StringUtils

2006-04-19 Thread Jan.Materne
>As I've been hacking away today, I've been swapping a load of >"" + "" + "" style code over to use StringBuffers. I thought >that perhaps there's a potential use of a static method in >StringUtils to construct these strings from an array For a significant performance boost we had to refactor

Re: AW: Adding a methof to StringUtils

2006-04-19 Thread Kev Jackson
[EMAIL PROTECTED] wrote: As I've been hacking away today, I've been swapping a load of "" + "" + "" style code over to use StringBuffers. I thought that perhaps there's a potential use of a static method in StringUtils to construct these strings from an array For a significant perform

Re: Adding a methof to StringUtils

2006-04-19 Thread Alexey Panchenko
Kev Jackson wrote: > As I've been hacking away today, I've been swapping a load of "" + "" + > "" style code over to use StringBuffers. I thought that perhaps there's > a potential use of a static method in StringUtils to construct these > strings from an array Please, don't. Modern compilers

Re[2]: AW: Adding a methof to StringUtils

2006-04-19 Thread Alexey Panchenko
Kev Jackson wrote: > It's less to do with speed performance and more to do with memory > performance. "a" + "b" + "c" creates "a" + "bc" <- intermediate String, > and then "abc" Many years ago - yes, but not now. java version "1.5.0_06" Java(TM) 2 Runtime Environment, Standard Edition (build

AW: Adding a methof to StringUtils

2006-04-19 Thread Jan.Materne
>Please, don't. > >Modern compilers already implement string addition using StringBuffer >(1.4 already have this optimization, I don't remember about >earlier versions). > >And 1.5 compiler can do it using StringBuilder which is faster. Mmh so we should do the performance tests on a ??? 1.4

svn commit: r395206 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2006-04-19 Thread peterreilly
Author: peterreilly Date: Wed Apr 19 03:50:02 2006 New Revision: 395206 URL: http://svn.apache.org/viewcvs?rev=395206&view=rev Log: escape none URL characters Modified: ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/lau

Re: # character causes problem parsing -lib paths

2006-04-19 Thread Peter Reilly
I have just checked. This is a problem - the ant launcher code does some conversion of file names to URLs. The '#' character is not converted The only work-around (at the moment) is to use symbolic links. I have made a change to ant SVN to fix this. Peter On 4/19/06, [EMAIL PROTECTED] <[EMAIL PRO

Re: AW: Adding a methof to StringUtils

2006-04-19 Thread Kev Jackson
javap -c AAA public java.lang.String concat(java.lang.String, java.lang.String, java.lang.String); Code: 0: new #2; //class java/lang/StringBuilder 3: dup 4: invokespecial #3; //Method java/lang/StringBuilder."":()V 7: aload_1 8: invokevirtual #4; //Method java/la

Re: svn commit: r395206 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2006-04-19 Thread Peter Reilly
Hi, Can someone on a windows system check that this works there? i.e. the -lib option to ant Peter On 4/19/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Author: peterreilly > Date: Wed Apr 19 03:50:02 2006 > New Revision: 395206 > > URL: http://svn.apache.org/viewcvs?rev=395206&view=rev

svn commit: r395230 - /ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/DeleteTest.java

2006-04-19 Thread bodewig
Author: bodewig Date: Wed Apr 19 05:31:09 2006 New Revision: 395230 URL: http://svn.apache.org/viewcvs?rev=395230&view=rev Log: 2006 Modified: ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/DeleteTest.java Modified: ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/Dele

Re: svn commit: r395206 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2006-04-19 Thread Antoine Levy-Lambert
Hello Peter, First of all your code change is very clean and looks like a simplification. :-) I have tried on Windows2000 with JDK 1.5 results : ant -f docs.xml -lib c:/opt/velocity\#1.4/velocity-dep-1.4.jar -lib c:/opt/velocity\#1.4/build/lib/jdom-b9.jar java.lang.IllegalArgumentException: U

Re: AW: Adding a methof to StringUtils

2006-04-19 Thread Steve Loughran
Kev Jackson wrote: [EMAIL PROTECTED] wrote: As I've been hacking away today, I've been swapping a load of "" + "" + "" style code over to use StringBuffers. I thought that perhaps there's a potential use of a static method in StringUtils to construct these strings from an array For a s

Fwd: Ant Website error? or feature?

2006-04-19 Thread Erik Hatcher
Passing on a private Ant documentation related issue. I'm guessing the only solution is to add a target="..." to the top browser window to such hyperlinks. Or eventually move away from using frames. Erik Begin forwarded message: From: Steve Meredith <[EMAIL PROTECTED]> Date: Ap

Re: AW: Adding a methof to StringUtils

2006-04-19 Thread Dominique Devienne
> The point about building the strings when they aren't used (because > logging verbosity is set too low) still stands though - this is less > than efficient The point, which Matt already raised, is that you can't know the level at which the logger and the listeners are set. There is nothing ATM i

Re: svn commit: r395206 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2006-04-19 Thread Antoine Levy-Lambert
Antoine Levy-Lambert wrote: > results : > > ant -f docs.xml -lib c:/opt/velocity\#1.4/velocity-dep-1.4.jar -lib > c:/opt/velocity\#1.4/build/lib/jdom-b9.jar > > I wonder whether the lines 146 to 181 in Locator.java which I copied > from a bug report of Jesse are good. > > If I remove the lines

AW: Ant Website error? or feature?

2006-04-19 Thread Jan.Materne
Was reported in Feb this year [1]. I fixed the manual in HEAD [2], but the site shows the 1.6.5 manual (and didnt want to change that ;-) Jan [1] http://marc.theaimsgroup.com/?l=ant-user&m=114119660927996&w=2 [2] http://marc.theaimsgroup.com/?l=ant-dev&m=114119647516675&w=2 >-Ursprünglich

DO NOT REPLY [Bug 39183] - Make source attribute of javac mandatory

2006-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r395248 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Launcher.java

2006-04-19 Thread peterreilly
Author: peterreilly Date: Wed Apr 19 07:11:26 2006 New Revision: 395248 URL: http://svn.apache.org/viewcvs?rev=395248&view=rev Log: compete toUri code for launcher Modified: ant/core/trunk/src/main/org/apache/tools/ant/launch/Launcher.java Modified: ant/core/trunk/src/main/org/apache/tools/a

Re: svn commit: r395206 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2006-04-19 Thread Peter Reilly
Hi Antoine, Thanks for checking. I had made a mistake! I had forgot to commit the other file that I changed - Launcher.java (assuming that it only had changes with printf statements!). Can you test now? I have tested by moving ant-contib.jar into ~/# and running with ant --execdebug -f x.xml -lib

Re: AW: Adding a methof to StringUtils

2006-04-19 Thread Matt Benson
--- Dominique Devienne <[EMAIL PROTECTED]> wrote: > > The point about building the strings when they > aren't used (because > > logging verbosity is set too low) still stands > though - this is less > > than efficient > > The point, which Matt already raised, is that you > can't know the level >

RE: # character causes problem parsing -lib paths

2006-04-19 Thread Paul.Mackay
Hi Peter, >I have made a change to ant SVN to fix this. So if I wanted to get a version of Ant with it fixed I could check it out from SVN? Is there any bug fix release schedule for Ant? I'm wondering because there has not been a new release for some time. cheers paul >-Original Message

RE: # character causes problem parsing -lib paths

2006-04-19 Thread Matt Benson
--- [EMAIL PROTECTED] wrote: > Hi Peter, > > >I have made a change to ant SVN to fix this. > > So if I wanted to get a version of Ant with it fixed > I could check it > out from SVN? > > Is there any bug fix release schedule for Ant? I'm > wondering because > there has not been a new release

Re: svn commit: r395206 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2006-04-19 Thread Antoine Levy-Lambert
Peter Reilly wrote: Hi Antoine, Thanks for checking. I had made a mistake! I had forgot to commit the other file that I changed - Launcher.java (assuming that it only had changes with printf statements!). Can you test now? Hello Peter, I have tweaked docs.xml to work with a classpath set wi

svn commit: r395304 - in /ant/core/trunk/src/main/org/apache/tools/ant: launch/Launcher.java launch/Locator.java taskdefs/ManifestClassPath.java util/FileUtils.java

2006-04-19 Thread peterreilly
Author: peterreilly Date: Wed Apr 19 09:31:30 2006 New Revision: 395304 URL: http://svn.apache.org/viewcvs?rev=395304&view=rev Log: change name of Locator.encodeUri to Locator.encodeURI Modified: ant/core/trunk/src/main/org/apache/tools/ant/launch/Launcher.java ant/core/trunk/src/main/or

DO NOT REPLY [Bug 39357] New: - ant-trax.jar includes Xalan2Executor from the junit package

2006-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 39357] - ant-trax.jar includes Xalan2Executor from the junit package

2006-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r395318 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/compilers/CompilerAdapterFactory.java

2006-04-19 Thread peterreilly
Author: peterreilly Date: Wed Apr 19 10:33:46 2006 New Revision: 395318 URL: http://svn.apache.org/viewcvs?rev=395318&view=rev Log: Support for mustang (todo.. use same defines as Javac.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/compilers/CompilerAdapterFactory.java

RE: AW: Adding a methof to StringUtils

2006-04-19 Thread Burgess, Benjamin
A good description of this comes from the JavaDocs for Log4j here: http://logging.apache.org/log4j/docs/api/org/apache/log4j/Category.html# isDebugEnabled() So actually, you would only wrap the debug log statement in an if(log.isDebug()) if the message itself is more than a simple String (ie. Con

RE: AW: Adding a methof to StringUtils

2006-04-19 Thread Matt Benson
--- "Burgess, Benjamin" <[EMAIL PROTECTED]> wrote: > A good description of this comes from the JavaDocs > for Log4j here: > > http://logging.apache.org/log4j/docs/api/org/apache/log4j/Category.html# > isDebugEnabled() > > So actually, you would only wrap the debug log > statement in an > if(log.

DO NOT REPLY [Bug 39359] New: - Problems with OSD-5 filespecs and return codes on OpenVMS

2006-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r395400 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/ArchiveResource.java

2006-04-19 Thread stevel
Author: stevel Date: Wed Apr 19 14:42:01 2006 New Revision: 395400 URL: http://svn.apache.org/viewcvs?rev=395400&view=rev Log: javadocs Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/ArchiveResource.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/r

DO NOT REPLY [Bug 32884] - [PATCH] PathConvert on Windows should process forward and back slashes equivalently

2006-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [VOTE] removal of icontract based task in ant

2006-04-19 Thread Conor MacNeill
> [X] Yes > > [ ] No > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] removal of Visual for Java based tasks

2006-04-19 Thread Conor MacNeill
> > [X] Yes > > [ ] No > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] removal of the test task based upon the org.apache.testlet framework

2006-04-19 Thread Conor MacNeill
> > [X] Yes > > [ ] No > Conor - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] removal of dependency to xslp

2006-04-19 Thread Conor MacNeill
> > [X] Yes > > [ ] No > Conor - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: AW: Adding a methof to StringUtils

2006-04-19 Thread Kev Jackson
Dominique Devienne wrote: The point about building the strings when they aren't used (because logging verbosity is set too low) still stands though - this is less than efficient The point, which Matt already raised, is that you can't know the level at which the logger and the listeners ar

Re: AW: Adding a methof to StringUtils

2006-04-19 Thread Matt Benson
--- Kev Jackson <[EMAIL PROTECTED]> wrote: > Dominique Devienne wrote: > > >>The point about building the strings when they > aren't used (because > >>logging verbosity is set too low) still stands > though - this is less > >>than efficient > >> > >> > > > >The point, which Matt already rai

Re: AW: Adding a methof to StringUtils

2006-04-19 Thread Antoine Levy-Lambert
Matt Benson wrote: > > Kev: I've asked some stuff about FileUtils before... > historically it was thought it might be pluggable, > hence all the instance methods. But that never > happened so the static methods crept in. I think it > was Martijn who really pushed in the FileUtils > singleton. Mo

DO NOT REPLY [Bug 32884] - [PATCH] PathConvert on Windows should process forward and back slashes equivalently

2006-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r395510 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Delete.java

2006-04-19 Thread kevj
Author: kevj Date: Wed Apr 19 23:44:38 2006 New Revision: 395510 URL: http://svn.apache.org/viewcvs?rev=395510&view=rev Log: fix bug#32738, implement quiet check for every message logged Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Delete.java Modified: ant/core/trunk/src/

svn commit: r395512 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java

2006-04-19 Thread kevj
Author: kevj Date: Wed Apr 19 23:51:49 2006 New Revision: 395512 URL: http://svn.apache.org/viewcvs?rev=395512&view=rev Log: use StringUtil.LINE_SEP Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java Modified: ant/core/trunk/src/main/org/a