Re: github PR builds

2018-02-08 Thread Jaikiran Pai
On 06/02/18 10:10 PM, Stefan Bodewig wrote: On 2018-02-06, Jaikiran Pai wrote: The PR build on Jenkins is backed by the github PR integration plugin[1]. One of the features of that plugin is to prevent some malicious/rogue PR (imagine someone creating a PR with code which does some odd things

Re: github PR builds

2018-02-06 Thread Stefan Bodewig
On 2018-02-06, Jaikiran Pai wrote: > The PR build on Jenkins is backed by the github PR integration > plugin[1]. One of the features of that plugin is to prevent some > malicious/rogue PR (imagine someone creating a PR with code which does > some odd things with the host on which it runs) being au

Re: github PR builds

2018-02-06 Thread Jaikiran Pai
So it looks like, although I did send a mail about this PR integration a while back[1], I did not include the details about this plugin which was used for the integration. Sorry about that. [1] https://www.mail-archive.com/dev@ant.apache.org/msg46284.html -Jaikiran On 06/02/18 5:12 PM, Jaiki

Re: github PR builds

2018-02-06 Thread Jaikiran Pai
The PR build on Jenkins is backed by the github PR integration plugin[1]. One of the features of that plugin is to prevent some malicious/rogue PR (imagine someone creating a PR with code which does some odd things with the host on which it runs) being auto-triggered against the Jenkins hosts.

github PR builds

2018-02-06 Thread Stefan Bodewig
Hi if I understand correctly our current PR build setup with Jenkins requires somebody to comment on the issue in order to have Jenkins build it. Do we really want this extra step? For Commons Compress I never thought about something like that. If we do, how does Jenkins know who is allowed to t