cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-08-23 Thread stevel
stevel 2005/08/23 02:43:07 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: extra javadocs, as requested by JHM Revision ChangesPath 1.62 +24 -0 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java ===

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java Diagnostics.java

2005-06-06 Thread jkf
jkf 2005/06/06 12:45:32 Modified:src/main/org/apache/tools/ant/launch Launcher.java src/main/org/apache/tools/ant ComponentHelper.java Diagnostics.java Log: PR: 35246 As suggested by Darin Swanson. (use USER_LIBDIR, and use File.separato

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-05-26 Thread mbenson
mbenson 2005/05/26 11:54:25 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Consistency and some spaces Revision ChangesPath 1.56 +19 -19ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java ===

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-05-23 Thread mbenson
mbenson 2005/05/23 12:27:30 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: add brief version of getElementName() Revision ChangesPath 1.55 +24 -6 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java =

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-05-16 Thread stevel
stevel 2005/05/16 05:11:44 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: merged antlib: strings to a single (currently private) constant. Revision ChangesPath 1.54 +3 -2 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: Compo

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-03 Thread jkf
jkf 2005/03/03 06:04:27 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: reduced visibility of the members not defined in super class of a private inner class removed unnecessary casts Revision ChangesPath 1.52 +7 -10 ant/src/main/org/apach

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-01 Thread Steve Loughran
[EMAIL PROTECTED] wrote: mbenson 2005/03/01 08:23:41 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Some space/punctuation cleanup. Like it, Steve. I got fed up with seeing the message myself. Plus I even got a support phone call on the problem last week, which rea

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-01 Thread Steve Loughran
Matt Benson wrote: //hey, there is nothing wrong with us -out.println("The component could be instantiated"); +out.println("The component could not be instantiated."); changes the meaning.. Sorry, didn't occur to me that a success messa

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-01 Thread mbenson
mbenson 2005/03/01 09:17:39 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Clean up spacing, remove erroneously inserted "not". Revision ChangesPath 1.51 +17 -16ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.j

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-01 Thread Matt Benson
--- Peter Reilly <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > >mbenson 2005/03/01 08:23:41 > > > > Modified:src/main/org/apache/tools/ant > ComponentHelper.java > > Log: > > Some space/punctuation cleanup. Like it, Steve. > > > > > > > snip > > >

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-01 Thread Peter Reilly
[EMAIL PROTECTED] wrote: mbenson 2005/03/01 08:23:41 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Some space/punctuation cleanup. Like it, Steve. snip //hey, there is nothing wrong with us -out.println("The component cou

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-01 Thread mbenson
mbenson 2005/03/01 08:23:41 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Some space/punctuation cleanup. Like it, Steve. Revision ChangesPath 1.50 +19 -24ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-28 Thread Antoine Levy-Lambert
[EMAIL PROTECTED] wrote: mbenson 2005/01/28 08:01:07 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Who'd have guessed that: boolean xor not boolean is equivalent to: boolean == boolean? Added a comment as well so Peter will be my friend again! I understand

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-28 Thread mbenson
mbenson 2005/01/28 08:02:02 Modified:src/main/org/apache/tools/ant Tag: ANT_16_BRANCH ComponentHelper.java Log: Merge Revision ChangesPath No revision No revision 1.28.2.10 +2 -1 ant/src/main/org/apache/

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-28 Thread mbenson
mbenson 2005/01/28 08:01:07 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Who'd have guessed that: boolean xor not boolean is equivalent to: boolean == boolean? Added a comment as well so Peter will be my friend again! Revision ChangesPath

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-28 Thread Peter Reilly
Matt Benson wrote: --- Peter Reilly <[EMAIL PROTECTED]> wrote: Do we really need code that has to be read five times to figure out what it does? You cut me deep, Peter. Would you settle for a comment? ;) I did not mean to be too criticial, it can be fun to replace if else type code wi

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-28 Thread Matt Benson
--- Peter Reilly <[EMAIL PROTECTED]> wrote: > Do we really need code that has to be read five > times > to figure out what it does? > You cut me deep, Peter. Would you settle for a comment? ;) -Matt > Peter > > [EMAIL PROTECTED] wrote: > > >mbenson 2005/01/27 13:53:27 > > > > Modified

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-28 Thread Peter Reilly
Do we really need code that has to be read five times to figure out what it does? Peter [EMAIL PROTECTED] wrote: mbenson 2005/01/27 13:53:27 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: -2 characters Revision ChangesPath 1.47 +1 -1 ant/src/main/org/

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-27 Thread mbenson
mbenson 2005/01/27 13:54:47 Modified:src/main/org/apache/tools/ant Tag: ANT_16_BRANCH ComponentHelper.java Log: Merge Revision ChangesPath No revision No revision 1.28.2.9 +1 -1 ant/src/main/org/apache/

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-27 Thread mbenson
mbenson 2005/01/27 13:53:27 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: -2 characters Revision ChangesPath 1.47 +1 -1 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java =

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-26 Thread mbenson
mbenson 2005/01/26 12:14:58 Modified:src/main/org/apache/tools/ant Tag: ANT_16_BRANCH ComponentHelper.java Log: Sync with HEAD Revision ChangesPath No revision No revision 1.28.2.8 +77 -120 ant/src/main/or

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-26 Thread mbenson
mbenson 2005/01/26 12:12:52 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Oops, got | and ^ confused... :( Revision ChangesPath 1.46 +1 -1 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java ==

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-20 Thread peterreilly
peterreilly2005/01/20 08:54:54 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: trailing space Revision ChangesPath 1.44 +1 -1 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java =

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2004-12-16 Thread mbenson
mbenson 2004/12/16 10:13:18 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Yet more bumming & javadoc. You'd think I'd have stopped by now... Revision ChangesPath 1.43 +27 -34ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: Co

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2004-12-16 Thread mbenson
mbenson 2004/12/16 08:51:11 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Same LOC count, minus 2 method calls, cute implementation. ;) Revision ChangesPath 1.42 +3 -3 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: Compone

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2004-12-16 Thread peterreilly
peterreilly2004/12/16 06:57:10 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Checkstyle Revision ChangesPath 1.41 +1 -1 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java =

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2004-06-16 Thread mbenson
mbenson 2004/06/16 08:41:51 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Code cleanup. Revision ChangesPath 1.37 +12 -27ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java =

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2004-02-23 Thread peterreilly
peterreilly2004/02/23 01:40:13 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Autoload of antlib.xml from default namespace Revision ChangesPath 1.34 +3 -4 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-12-24 Thread peterreilly
peterreilly2003/12/24 02:52:42 Modified:src/main/org/apache/tools/ant Tag: ANT_16_BRANCH ComponentHelper.java Log: Sync with head Revision ChangesPath No revision No revision 1.28.2.2 +3 -1 ant/src/main

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-12-24 Thread peterreilly
peterreilly2003/12/24 02:52:03 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: ComponentHelper. Logic for copying the checked namespaces to new projects was broken. Revision ChangesPath 1.30 +3 -1 ant/src/main/org/apache/tools/ant/ComponentHel

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-10-17 Thread peterreilly
peterreilly2003/10/17 01:13:03 Modified:src/main/org/apache/tools/ant Tag: ANT_16_BRANCH ComponentHelper.java Log: Merge with HEAD Revision ChangesPath No revision No revision 1.28.2.1 +1 -1 ant/src/mai

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-10-17 Thread peterreilly
peterreilly2003/10/17 01:09:46 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: synchonize ComponentHelper#checkNamespace() This fixes a bug with use of and xmlns:prefix="antlib:package echo hello echo hello - need a

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java AntTypeDefinition.java

2003-08-15 Thread peterreilly
peterreilly2003/08/15 01:40:37 Modified:src/main/org/apache/tools/ant ComponentHelper.java AntTypeDefinition.java Log: move same definition to AntTypeDefinition Revision ChangesPath 1.24 +1 -9 ant/src/main/org/apache/tools/ant/ComponentHe

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-07-04 Thread peterreilly
peterreilly2003/07/04 10:00:14 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: changed for checkstyle Revision ChangesPath 1.17 +82 -53ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java =

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-06-27 Thread peterreilly
peterreilly2003/06/27 11:16:59 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: quick fix for Ant.java use of property in Ant#reinit Revision ChangesPath 1.14 +9 -1 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelpe

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-05-05 Thread costin
costin 2003/05/05 06:59:24 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Last part of component helper merge ( including the fix contains -> containsKey for the test case ) Revision ChangesPath 1.9 +16 -7 ant/src/main/org/apache/tools/ant/Co

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-05-05 Thread costin
costin 2003/05/04 19:17:28 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Remove one method - it wasn't used, and it seems it's not powerfull enough for all cases discussed. The method that takes UnknownElement, ns, tag should be able to cover everything ( by h

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-05-03 Thread costin
costin 2003/05/02 23:27:00 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: The ctor takes Project as param. Revision ChangesPath 1.7 +1 -1 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java ==

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-05-03 Thread costin
costin 2003/05/02 22:59:35 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Update with the changes in Project. This makes ComponentHelper the almost exact duplication of the task creation code in Project. Revision ChangesPath 1.6 +12 -4