Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2005-08-08 Thread Matt Benson
I'm so ashamed. :) -Matt --- [EMAIL PROTECTED] wrote: > peterreilly2005/08/08 02:02:55 > > Modified: > src/main/org/apache/tools/ant/taskdefs Ant.java > Log: > Replace x == "" with "".equals(x) to check if we > are > looking at the empty target > Obtained from: Alexey Panchenko

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2005-08-08 Thread peterreilly
peterreilly2005/08/08 02:02:55 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Replace x == "" with "".equals(x) to check if we are looking at the empty target Obtained from: Alexey Panchenko Revision ChangesPath 1.124 +1 -1 ant/src/main/org/apa

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2005-06-10 Thread stevel
stevel 2005/06/10 16:06:11 Modified:src/main/org/apache/tools/ant MagicNames.java Main.java Project.java src/main/org/apache/tools/ant/taskdefs Ant.java Log: moving some magic names into place, using them where needed. Revision Changes

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2005-05-25 Thread mbenson
mbenson 2005/05/25 15:25:43 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Avoid multiple instantiations of equal File objects, and multiple resolveFile calls. Revision ChangesPath 1.121 +2 -3 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2005-05-22 Thread jkf
jkf 2005/05/22 12:48:25 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Avoiding Throwable while BuildException was actually meant Revision ChangesPath 1.120 +5 -7 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java ==

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2005-04-07 Thread mbenson
mbenson 2005/04/07 13:14:52 Modified:src/main/org/apache/tools/ant/helper Tag: ANT_16_BRANCH DefaultExecutor.java SingleCheckExecutor.java src/main/org/apache/tools/ant Tag: ANT_16_BRANCH Executor.java Project.java

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2005-01-14 Thread peterreilly
peterreilly2005/01/14 09:23:38 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: unneeded import Revision ChangesPath 1.116 +0 -1 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java ==

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java MacroDef.java MacroInstance.java

2005-01-13 Thread peterreilly
peterreilly2005/01/13 06:05:11 Modified:src/main/org/apache/tools/ant PropertyHelper.java src/main/org/apache/tools/ant/taskdefs Ant.java MacroDef.java MacroInstance.java Log: EXPERMINTAL add in local properties these can b

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2004-12-22 Thread peterreilly
peterreilly2004/12/22 01:47:56 Modified:src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH Ant.java Log: sync Revision ChangesPath No revision No revision 1.92.2.11 +1 -1 ant/src/main/org/apache/t

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2004-12-22 Thread peterreilly
peterreilly2004/12/22 01:47:37 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Invalid boolean test in "Calling Target(s) msg" of Ant task PR: 32792 Obtained from: Kevin Greiner Revision ChangesPath 1.112 +1 -1 ant/src/main/org/apache/tools/ant/

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java

2004-12-15 Thread Matt Benson
--- Matt Benson <[EMAIL PROTECTED]> wrote: > I rarely document overridden methods myself, but I > will admit that I may have accidentally deleted > information detailing how the subclass > implementation > differs or elaborates substantially upon the base > implementation. I will go back today a

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java

2004-12-15 Thread Matt Benson
I rarely document overridden methods myself, but I will admit that I may have accidentally deleted information detailing how the subclass implementation differs or elaborates substantially upon the base implementation. I will go back today and take a second look at what I deleted. --- Peter Rei

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java

2004-12-15 Thread Peter Reilly
Hi Matt, the following changes remove information from the javadoc. Peter [EMAIL PROTECTED] wrote: mbenson 2004/12/14 13:18:08 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java Log: Javadoc Revision ChangesPath 1.110 +31 -50a

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2004-12-14 Thread mbenson
mbenson 2004/12/14 15:51:27 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Lower-case HTML tags Revision ChangesPath 1.111 +2 -2 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java

2004-12-14 Thread mbenson
mbenson 2004/12/14 13:18:08 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java Log: Javadoc Revision ChangesPath 1.110 +31 -50ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java =

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2004-12-07 Thread jglick
jglick 2004/12/06 22:44:34 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Minor stylistic refactoring. Revision ChangesPath 1.109 +3 -2 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java Recorder.java RecorderEntry.java

2004-06-28 Thread bodewig
bodewig 2004/06/28 00:47:06 Modified:.Tag: ANT_16_BRANCH TODO docs/manual Tag: ANT_16_BRANCH develop.html src/main/org/apache/tools/ant Tag: ANT_16_BRANCH AntClassLoader.java Project.java src/main/org/apache/too

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java Recorder.java RecorderEntry.java

2004-06-24 Thread bodewig
bodewig 2004/06/24 04:16:41 Modified:src/main/org/apache/tools/ant AntClassLoader.java Project.java src/main/org/apache/tools/ant/taskdefs Ant.java Recorder.java RecorderEntry.java Added: src/main/org/apache/tools/ant

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java RecorderEntry.java

2004-06-23 Thread bodewig
bodewig 2004/06/23 07:08:26 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java RecorderEntry.java Log: Preliminary fix for 8689 Revision ChangesPath 1.101 +26 -4 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2004-04-08 Thread bodewig
bodewig 2004/04/08 07:59:52 Modified:src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH Ant.java Log: merge Revision ChangesPath No revision No revision 1.92.2.7 +4 -2 ant/src/main/org/apache/too

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2004-04-08 Thread bodewig
bodewig 2004/04/08 07:58:19 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Don't die if the ant.file property hasn't been set. Jelly's Ant tag library currently doesn't set this property and each task used in Jelly will result in an NPE otherwise. Revision

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java Definer.java ImportTask.java MacroInstance.java

2003-11-06 Thread peterreilly
peterreilly2003/11/06 07:01:22 Modified:src/main/org/apache/tools/ant Tag: ANT_16_BRANCH ProjectHelper.java src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH Ant.java Definer.java ImportTask.java

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java Definer.java ImportTask.java MacroInstance.java

2003-11-06 Thread peterreilly
peterreilly2003/11/06 06:57:10 Modified:src/main/org/apache/tools/ant ProjectHelper.java src/main/org/apache/tools/ant/taskdefs Ant.java Definer.java ImportTask.java MacroInstance.java Log: Provide error stack for [*]ant[*] and macro call use

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-10-10 Thread peter reilly
Opps, Well found! Peter On Friday 10 October 2003 14:19, [EMAIL PROTECTED] wrote: > bodewig 2003/10/10 06:19:46 > @@ -450,10 +450,12 @@ >Set set = new HashSet(); >for (int i = properties.size() - 1; i >= 0; --i) { >Property p = (Property) properties.ge

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-10-10 Thread bodewig
bodewig 2003/10/10 06:21:22 Modified:src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH Ant.java Log: Merge from HEAD Revision ChangesPath No revision No revision 1.92.2.1 +6 -4 ant/src/main/org/

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-10-10 Thread bodewig
bodewig 2003/10/10 06:19:46 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: with more than one child didn't work, PR 23601 Revision ChangesPath 1.93 +6 -4 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-17 Thread Steve Loughran
Conor MacNeill wrote: On Sat, 13 Sep 2003 12:04 am, [EMAIL PROTECTED] wrote: conor 2003/09/12 07:04:46 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Mark entry and exit of and PR:22718 Submitted by: Jesse Glick This gives a message on entry and exit to a sub-b

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-12 Thread conor
conor 2003/09/12 08:42:22 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Verbose it is ... Revision ChangesPath 1.91 +2 -2 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java ===

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-12 Thread Stefan Bodewig
On Sat, 13 Sep 2003, Conor MacNeill <[EMAIL PROTECTED]> wrote: > The question I have is whether to log at INFO or VERBOSE level. I'd say VERBOSE. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mai

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-12 Thread Conor MacNeill
On Sat, 13 Sep 2003 12:04 am, [EMAIL PROTECTED] wrote: > conor 2003/09/12 07:04:46 > > Modified:src/main/org/apache/tools/ant/taskdefs Ant.java > Log: > Mark entry and exit of and > > PR: 22718 > Submitted by: Jesse Glick > This gives a message on entry and exit to a su

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-12 Thread conor
conor 2003/09/12 07:04:46 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Mark entry and exit of and PR: 22718 Submitted by: Jesse Glick Revision ChangesPath 1.90 +9 -7 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: An

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-10 Thread Stefan Bodewig
On Wed, 10 Sep 2003, peter reilly <[EMAIL PROTECTED]> wrote: > The solution is not to execute the target if > the target is "". I agree. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-10 Thread peter reilly
This reminds me of another bug I forgot to report. If is called without setting target, the default target is called. If there is no default target, the "" target is called. This means that the top-level tasks are called twice. Example: hello.xml Hello world build.xml ... The solutio

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-10 Thread bodewig
bodewig 2003/09/10 06:17:00 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: It is legal to omit the target attribute in , don't die with a NPE Revision ChangesPath 1.88 +17 -10ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java AntStructure.java Concat.java Copydir.java Expand.java Jar.java Javadoc.java Replace.java UpToDate.java Zip.java

2003-08-13 Thread peterreilly
peterreilly2003/08/13 07:46:15 Modified:src/main/org/apache/tools/ant ComponentHelper.java RuntimeConfigurable.java Task.java src/main/org/apache/tools/ant/input DefaultInputHandler.java src/main/org/apache/tools/ant/taskdefs Ant.java

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-08-05 Thread peterreilly
peterreilly2003/08/05 04:47:33 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Remove unneeded setting of properties in reinit() Revision ChangesPath 1.84 +1 -30 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-04-03 Thread conor
conor 2003/04/03 06:44:02 Modified:src/main/org/apache/tools/ant Project.java src/main/org/apache/tools/ant/taskdefs Ant.java Log: Fix up handling of input in nested builds. PR: 18642 Revision ChangesPath 1.133 +13 -2 ant/src/main/org/apach