RE: concat teardown failing

2003-09-23 Thread Jan . Materne
> > Because we have a 1.6 version and a head version on cvs. How should > > I commit the changes? > > Twice. > > The easiest way for you probably is to copy your ant workspace and > inside your copy run cvs up -r ANT_16_BRANCH. After that the copy > will be working on the branch while your old c

RE: concat teardown failing

2003-09-23 Thread Jan . Materne
> > Because we have a 1.6 version and a head version on cvs. How should > > I commit the changes? > > On both versions. > The easiest is to make the changes on HEAD, make a diff file (before > the commit on HEAD), and apply the changes to 1.6, and then commit > in both. - changes on HEAD: ok, tha

Re: concat teardown failing

2003-09-23 Thread Stefan Bodewig
On Tue, 23 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote: > Because we have a 1.6 version and a head version on cvs. How should > I commit the changes? Twice. The easiest way for you probably is to copy your ant workspace and inside your copy run cvs up -r ANT_16_BRANCH. After that the copy w

Re: concat teardown failing

2003-09-23 Thread peter reilly
tember 23, 2003 3:24 PM > > To: [EMAIL PROTECTED] > > Subject: Re: concat teardown failing > > > > On Tue, 23 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote: > > > I have modified the FileUtils.readFully(Reader rdr, int bufferSize) > > > so that it clo

RE: concat teardown failing

2003-09-23 Thread Jan . Materne
tember 23, 2003 3:24 PM > To: [EMAIL PROTECTED] > Subject: Re: concat teardown failing > > > On Tue, 23 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote: > > > I have modified the FileUtils.readFully(Reader rdr, int bufferSize) > > so that it closes the reader

Re: concat teardown failing

2003-09-23 Thread Stefan Bodewig
On Tue, 23 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote: > I have modified the FileUtils.readFully(Reader rdr, int bufferSize) > so that it closes the reader and all works. I think that would be the wrong place. It may be my old C thinking coming from explicit memory managment, but I think th

RE: concat teardown failing

2003-09-23 Thread Jan . Materne
ect: Re: concat teardown failing > > > Bingo, I think. > > The tests in ConcatFilterTest do this: > String resultContent = fu.readFully( > new java.io.FileReader(resultFile)); > so nothing closes the resultfile. > > Peter > > On Tuesd

Re: concat teardown failing

2003-09-23 Thread peter reilly
Bingo, I think. The tests in ConcatFilterTest do this: String resultContent = fu.readFully( new java.io.FileReader(resultFile)); so nothing closes the resultfile. Peter On Tuesday 23 September 2003 10:17, [EMAIL PROTECTED] wrote: > co > > > > ncat.filterReaderPrepend.tes -

RE: concat teardown failing

2003-09-23 Thread Jan . Materne
nal Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Tuesday, September 23, 2003 12:50 PM > To: [EMAIL PROTECTED] > Subject: RE: concat teardown failing > > > Difference to my solution is only that you´re setting the append- and > prepend read

RE: concat teardown failing

2003-09-23 Thread Jan . Materne
Difference to my solution is only that you´re setting the append- and prepend reader to null. But that don´t work on my machine :-( But I don´t get the error while deleting the append- or prepend file. I get the error while deleting the resulting file. But if I add a "super.close()" I´ll get othe

Re: concat teardown failing

2003-09-23 Thread peter reilly
On Tuesday 23 September 2003 11:10, [EMAIL PROTECTED] wrote: > I have tried with closing them, but it doesn´t work. > But send me your code please. Maybe you have done some different :-) > > Attached. PeterIndex: ConcatFilter.java ===

RE: concat teardown failing

2003-09-23 Thread Jan . Materne
lete file > > > C:\seu\cvs-downloads\ant\ant\src\etc\testcases\filters\result\ > concat.filter > >R eaderPrepend.test > > > > > > The concat.filterReaderPrepend.test can´t be deleted but > it´s closed in > > line 669. > > > > Any ideas? &g

Re: concat teardown failing

2003-09-23 Thread peter reilly
y ideas? > > > Jan > > > -Original Message- > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > Sent: Tuesday, September 23, 2003 9:05 AM > > To: [EMAIL PROTECTED] > > Subject: RE: concat teardown failing > > > > > > And I

RE: concat teardown failing

2003-09-23 Thread Jan . Materne
23, 2003 9:05 AM > To: [EMAIL PROTECTED] > Subject: RE: concat teardown failing > > > And I thought that´s only on my machine ... (that´s why I put that > into a try-catch block in the tearDown() - the _real_ test shouldn´t > fail only because the cleanup fails ...) > >

RE: concat teardown failing

2003-09-23 Thread Jan . Materne
List > Subject: concat teardown failing > > > > the cleanup script in concat.xml is failing. Looks to me like > the files > are still open when the delete task takes action. Could set > failonerror > flags to ignore it, but it may be a symptom of the task not

concat teardown failing

2003-09-23 Thread Steve Loughran
the cleanup script in concat.xml is failing. Looks to me like the files are still open when the delete task takes action. Could set failonerror flags to ignore it, but it may be a symptom of the task not closing things. platform: winxp, java1.4.2 [junit] - Standard Error